Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4402859ioa; Wed, 27 Apr 2022 03:07:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHIkUx1AwuNCNtee/W3azgKx0aXZAGKy1Vb5qRt4ORy3kE+2QJpzmTvALTjTtOfy3U97V3 X-Received: by 2002:aa7:88cf:0:b0:50d:4685:844 with SMTP id k15-20020aa788cf000000b0050d46850844mr12730455pff.41.1651054024857; Wed, 27 Apr 2022 03:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651054024; cv=none; d=google.com; s=arc-20160816; b=PQ/kF/Z//g3Q4yQzkXsO9AIKm2rL/K2w9c5QLkdhrIOCHTx6MLP8UPYIyUHftRZ/tV DX68ums3qJooOGsqfT8kvKL4y5vDQ8ZFC4XG7KEg1zPUWXniFmAHrZBEiQJN4712U51w +3FYQq+bT9hmgL0ybcBM65fQdJ6lRsDSN9RAUB+6OeB6U38jBDCcfx2+IYUg1dn4csRH vKWN2xt2pjxU80QSrBh343Dzl9Yv4aaiZ4RrtIcv/IXEG/YBLqYCONeUuFFmbsOLxRcq VmMUHQp6V0hEzpHDv9qpvSoxjTdSvytGgztLOh1BZu0Aci2xzTwSSbZ4L1M6PRsHyQcO MXMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=P8TnfAKaWXwsEVz2IHHsmMbXLBYv3keX8jHJkboUhfo=; b=EsPv79fYQZ1Y0AwC/3QXwsZLjzdaX9fpt8Vivkz2X4C7N4PuM3T1Uyf0ZasHDyuBa3 f55giwzdYm3Al2VZOlV4ZbZ/3U05kb1U3s4Y2sUhoM1BWqYDgyyDpvIh/ZaGOo94ksS2 tOmLyldqTAqi0Z/DPaJqG6eZiJgjvggAr92jYll1BMP4RpibrtBc5ROnyLPFEfjjq583 XU2gvGcwrdIFUv+A9jWvc6tlB7+8kMBLbIsprxMuE2M7jB4oRw7zb6dQtwe99zpmL0WB 2skAiGvrZevVTpsBEmH+9QnDjYGjxkwZp0yTvb/UylwQqTy1Qe1Q+RmM0U4vL76xpSgJ R0OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qZNiSAaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u1-20020a170902e5c100b0015bfd115dcesi1274239plf.455.2022.04.27.03.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 03:07:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qZNiSAaI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED55C2F7E05; Wed, 27 Apr 2022 02:30:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357529AbiD0DiU (ORCPT + 99 others); Tue, 26 Apr 2022 23:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357512AbiD0DiS (ORCPT ); Tue, 26 Apr 2022 23:38:18 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325E62AD8; Tue, 26 Apr 2022 20:35:09 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id v12-20020a9d7d0c000000b006054b51c3d4so282835otn.8; Tue, 26 Apr 2022 20:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P8TnfAKaWXwsEVz2IHHsmMbXLBYv3keX8jHJkboUhfo=; b=qZNiSAaIYWoTPpTYxcwpNXefkEf7mNKLxvCwi1xVh2iChN4ze5MCJtEHxRLgTNJb5F mm752QHptJJ6JK6+Jn3x3G3OOZqX4a2SXWXYGuUMQCdNlaJMpS41uBLUwpyI0c2d/0qg DNULQ4TzSTEuhVWAddkQegR46qfmDsiIn/y82/C2p2Oya8jUuOLRaAeSY409BlprWHsK rtWsWiqT3INPvItI2M4+Fl65W2TVO9uW3lztKgS2hMQp64dbd0VVDB/VXP78iEliHcyX 8ZnjcT3G3+jbmmXtU0ss4wCV4GI9oQnStxLd2vlGuJoHluGsCSareOeM+ImifjMvzy8z KwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P8TnfAKaWXwsEVz2IHHsmMbXLBYv3keX8jHJkboUhfo=; b=ilbCrxFHe/BYzJNXlxPtIMEzjtA6j3SutHoFBnHBERWU438TRXrFiLHDgK/Sv3/Dt8 +vpfBNp7s3gbORrdgIl3bxjd7GxHHeC0B8cPmoI+pMXDDYSPjCSq7jsfJPTh9WgygJuz Wmt6LwS2zPA3+t+Znd1zmFaMwRcizIDVeWqyqGnwcb/8OdbJyc9lSiIlkcE34dR9u+vj XBstQpflpu8+OJdxKxYLPqFTvPCHf1fQzXynT+R3Z3kWzDNWij398q00QIyhGQMimf4x qqp2MrbjxIgBZGsQRersW6QAXoaSHb0KwPHHjSWVtvnGo61OEbkxJDuW+zvxQjNBkuSZ ZpTA== X-Gm-Message-State: AOAM533SN2PQEhw+4ijChRYfApKvZbVVK7mEdL8qyptn/dttUisLMURF C7c4xVg2R8CnaWnq747k9gQ= X-Received: by 2002:a05:6830:2007:b0:605:8c49:a3f3 with SMTP id e7-20020a056830200700b006058c49a3f3mr8625422otp.366.1651030508495; Tue, 26 Apr 2022 20:35:08 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id q203-20020acad9d4000000b002f8ee3f69e2sm5598621oig.52.2022.04.26.20.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 20:35:07 -0700 (PDT) Sender: Guenter Roeck Message-ID: <2563e20b-7800-086e-73d4-e4cbc7a53c5b@roeck-us.net> Date: Tue, 26 Apr 2022 20:35:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 0/3] hwmon: (dell-smm) Improve init code Content-Language: en-US To: Armin Wolf , pali@kernel.org Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220426213154.724708-1-W_Armin@gmx.de> From: Guenter Roeck In-Reply-To: <20220426213154.724708-1-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/26/22 14:31, Armin Wolf wrote: > This patch series improves the init code of the dell_smm_hwmon > driver. The first patch speeds up device initialisation by avoiding > unnecessary SMM calls during init, which might be slow on some > machines. The second patch is a small cleanup patch, while the > third patch allows for easier diagnosis of audio problems caused > by really slow SMM calls. > > Tested on a Dell Inspiron 3505. Series applied to hwmon-next. Thanks, Guenter > > Changes in v2: > - replace pr_warn() with pr_warn_once() > > Armin Wolf (3): > hwmon: (dell-smm) Avoid unnecessary SMM calls during init > hwmon: (dell-smm) Cleanup init code > hwmon: (dell-smm) Warn if SMM call took a very long time to execute > > drivers/hwmon/dell-smm-hwmon.c | 50 +++++++++++++++------------------- > 1 file changed, 22 insertions(+), 28 deletions(-) > > -- > 2.30.2 >