Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <13df1664-fc52-4772-afa1-4f75019b7830@quicinc.com>
Date:   Tue, 26 Apr 2022 19:34:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 ] devcoredump : Serialize devcd_del work
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        <linux-kernel@vger.kernel.org>
CC:     <sboyd@kernel.org>, <rafael@kernel.org>,
        <gregkh@linuxfoundation.org>, Kees Cook <keescook@chromium.org>
References: <87levt14kn.ffs@tglx>
 <8186de033c87f0cdec296ae272a72c5b9a2880a3.camel@sipsolutions.net>
 <878rrt0xa2.ffs@tglx>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <878rrt0xa2.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/26/2022 1:07 AM, Thomas Gleixner wrote:
> Cc+: Kees
> 
> On Mon, Apr 25 2022 at 19:19, Johannes Berg wrote:
>> On Mon, 2022-04-25 at 19:00 +0200, Thomas Gleixner wrote:
>>>
>>> Johannes, can you please explain whether this immediate flush in
>>> disabled_store() is really required and if so, why?
>>>
>> I don't really know, as I remember that requirement (or maybe even code,
>> not sure) came from Kees, who needed the lockdown.
>>
>> Given the use case (ChromeOS?) I'm not sure I see a need to flush all of
>> them, since I guess a typical system would set the lockdown early in
>> boot and hopefully not have a crash-dump around already.
>>
>> That said, I don't think the diagram you made works - fn() during the
>> iteration is guaranteed to be invoked with a reference of its own, so
>> the put_device() there can't be the last reference, only as fn() returns
>> you'd put the last reference *there*, freeing it.
> 
> Bah, you are right, it's magically protected by the klist ref, which
> prevents devcd from going away. Damned obvious.
> 
> This really needs comments why this all can magically "work".
> 
> Thanks,
> 
>          tglx
> 

Thanks you all for your time in reviewing this.
I tried to address few comments in v3 here.

https://lore.kernel.org/lkml/1650981343-11739-1-git-send-email-quic_mojha@quicinc.com/

While, we would like to hear from Kees about reason of immediate flush 
from disabled_store().

Regards,
-Mukesh
> 
> 
>