Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <691c863c-0923-73f2-eab5-65b4238f545a@nvidia.com>
Date:   Tue, 26 Apr 2022 13:02:26 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [Patch v8 1/4] memory: tegra: Add memory controller channels
 support
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        krzysztof.kozlowski@linaro.org, thierry.reding@gmail.com,
        jonathanh@nvidia.com, digetx@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220425075036.30098-1-amhetre@nvidia.com>
 <20220425075036.30098-2-amhetre@nvidia.com>
 <5ddaf113-c8f6-7c9c-5bf6-27f2f7855d24@collabora.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <5ddaf113-c8f6-7c9c-5bf6-27f2f7855d24@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE1hZm9sYUR2dWlUa2JTSU9FajV6S1hZeWY2ZXZEME03cmtselgxY0Y5bVhn?=
 =?utf-8?B?bDE4R0N0eGNZZHpWTnZ3L2xzRmc2elFEOWw5M0xDb1ZEVWE1Uko1Q2hwQW13?=
 =?utf-8?B?blBPRDAvRGI4Z2VuM1R6SlM1MUtQdy9Vc0Uxa1UwWFJ3ZXdma3A2b2xKOTh6?=
 =?utf-8?B?T2szRGc1WElRd3QrWHNnWVhCRjFlMjVZZEVzejdKSXN4OGJabmxuYWdhVDlZ?=
 =?utf-8?B?WXN2V0tENGFaZmpKQlA3WmRSRFJRTHZvRjlNZlZGQjBjQ1JrbXplczE0U0JT?=
 =?utf-8?B?S1BDbE5rRWVFQzNOVjlsY3NkTncwTHQ0TitjdWdZbGFCRi9SQWpLMTZJMnhR?=
 =?utf-8?B?U0VQOFpSYTdURDRVTFN2NjlrSE1Hb0xidXpoT1dmb0RLdFlWRFdWc1pzVGE1?=
 =?utf-8?B?OFk4TEh5QnJPUlZrTDJrU1lUdHkvb2dVSW1CaWZXL1RJYjBNM1RNZzZCQ2Qv?=
 =?utf-8?B?dUNkdWdLZUhweXBUUXdnNjViazRmMUQrM251R0JkWXcvaU1IZEdFQlhoa2Nm?=
 =?utf-8?B?V2FKaVFraVhIRWZydEdKck9UOTNhdy96TnFqY2Z6OHFoaXR0VFhqWE1NaDNq?=
 =?utf-8?B?Y2ZVUGFKZ2ZGVW1MTmJSdUQ0NmZORjZNeTdPNFdVZU43MVdkODcvcmJGa3dG?=
 =?utf-8?B?ckF3bDJuUDdrcWVST0ZERW9QU1JKQ1RaUi96MUxqQjA2SmtYRHlsdk1YYUFh?=
 =?utf-8?B?TWVEK2FuemxyOWxxdldndjdDSEVGVkNzWUJ5QXF5SS9vc1lsYWxaY29ZOXdE?=
 =?utf-8?B?WnJhaVZoVkl4Vm1tTnZnbUtmZjJjTDVaTG8vaTNIWFVlbE45SjZJTGpSQ3Uz?=
 =?utf-8?B?TkVMcGtacGdDZ3VhQ2Y3OGtJZGF0VUxIZjVmWUZQNzA3UnZiQkpSa2hZK2Fi?=
 =?utf-8?B?ZlBJbHE5YTJJUWlVV1lJTUpnamhFS0hYR0kxWmcyaWVmeVJhZmFYb3luNjJW?=
 =?utf-8?B?NUt5RkVtY0hjUDJ5TENsNDZmekJXbHY1TzJzRDBKL0p4aWY2N1lER24rdzMy?=
 =?utf-8?B?cHZTSFRSRjMxYXMzWUVMdDI5K2VvV2pYMWU0aHNtWUFKMTVqQnltL2NmZDB0?=
 =?utf-8?B?MFVIYWhoazYwUDZsMnlTcDk5TFo4ZHBPakJLcVJZOUc5YzRyVW5YN1BVRDF1?=
 =?utf-8?B?Q29lcG1GZExibmY0ejdiZVVzdng1SHVReFNlWUUyRkhqb0FPUEtMekYxcnlM?=
 =?utf-8?B?UXkydWR0clBZTjZOQUlVa05BMWlyclhRWmZCakxQVzZWSVBwY1JkdnpNczlH?=
 =?utf-8?B?MDVGMEtKemtJYWowTkN0MzJ0SVEvakNEYk5vak1SSnNkYlI5QnhKNWlTajdl?=
 =?utf-8?B?Y3BSSzNyTDRLc1lpQmYvZFBPOFE4blJBVFd4L0wxNnJWejUrbVVZTWtURG5I?=
 =?utf-8?B?dkhqZ3hxM0ErQ0F5blI3emdCSWx5UFhGY3ZsRmRiRVF4M09OaWVIREFGaGh6?=
 =?utf-8?B?R1pGY2V2eTB3aUp3d09xMENaTUNIWm02MVJGWVVjVVMyMEdqT0w1ays0Wkc3?=
 =?utf-8?B?SHBVRlBDWGEzd2ZBN1ZMUkVqTXFPcEpkbkVKQmRqOU1ia1kxdlFzVjNIM1hy?=
 =?utf-8?B?bVE0WGs0b3VYZER0eVZUOVRreUkzRXY2a3ZDS0E0QVpHQWRBRVR3eS82Qkgv?=
 =?utf-8?B?dEZiSXd6b3NKZ21IaU9ydGdkWExWRmJwNmNtbTA1eDY0TDAxM2w0Mjc2NFBl?=
 =?utf-8?B?aHh4S1hOdTk2YkU5eDl5NFdmOWlDKytuM2IyWjd1RVpldVBMdjh4SjlvcWRi?=
 =?utf-8?B?VVNEM0N3dmc4emRqQWxmYkRnQXMydWdOWDFFVEh6L0lhbDVYQ1A2WWNuckpv?=
 =?utf-8?B?M0RzL3ZKRkY4VXZwSG5KTVhCbUxQdDdKMVQ5R3Z3VjNRT2Mvenhma3RENFY3?=
 =?utf-8?B?UWhUYmhObU9OZlFEMXk3KzRlRFhscHBxbTdtQ21CaXljdE84algrOXB3b0Ey?=
 =?utf-8?B?LzdnK2RhaWNzNFAxeXl0RUlaOVFEakMxL1FmQzVKdEo0RXV6WlRBZ2t1Qzkv?=
 =?utf-8?B?WC9sQzBLQkNoMkhmcU9QbFNuNG1kQzY4ZEdiZlVkeGxna1VPRW5ELzRpeEt1?=
 =?utf-8?B?VXV1NU5IYUxmTFczN3kyUXhBSkxCczJwb0RMWWF5cWxBb01JbFA1cVAzVGcv?=
 =?utf-8?B?RjQwMXQ4NkUyOVM1MGxuc2dhN05zNW1jVzNRZGFsWTBpQ2hZdjkxRGFxR3NP?=
 =?utf-8?B?ZDFTc1VVc3l1WTNqK0t5a2cwR21vdVNGK0RHV0I2ZnUrdDcyZjZqUlhSeFBS?=
 =?utf-8?B?bmFWVi9KQmFFS08vOUpkcitMWTVobFBrMUh4Tk15c0MxYmhuU0huQ1A1Q2Vx?=
 =?utf-8?B?Y21DUmEyWElCZUE3WVpZUmJraXB5djNuNUw4L0hadURyUzlrZk84dz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b19c926e-c3ce-45c9-b674-08da2756f0bc
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 07:32:38.9822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y40NhL9Xq45Rwl5fg4cBcvmoea9WZThK34DwTBaOPjzgNvriJ0SvT34xnWqcdj7WZdEpR69R5saVnKZXgMJJJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5663
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/26/2022 12:55 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 4/25/22 10:50, Ashish Mhetre wrote:
>> +static int tegra186_mc_map_regs(struct tegra_mc *mc)
>> +{
>> +     struct platform_device *pdev = to_platform_device(mc->dev);
>> +     int i;
>> +
>> +     mc->bcast_ch_regs = devm_platform_ioremap_resource_byname(pdev, "broadcast");
>> +     if (IS_ERR(mc->bcast_ch_regs)) {
>> +             if (PTR_ERR(mc->bcast_ch_regs) == -EINVAL) {
>> +                     dev_warn(&pdev->dev, "Broadcast channel is missing, please update your device-tree\n");
>> +                     mc->bcast_ch_regs = NULL;
>> +                     return 0;
>> +             }
>> +             return PTR_ERR(mc->bcast_ch_regs);
>> +     }
>> +
>> +     mc->ch_regs = devm_kcalloc(mc->dev, mc->soc->num_channels,
>> +                                sizeof(void __iomem *), GFP_KERNEL);
> 
> You should use sizeof(*mc->ch_regs) in general to prevent mistakes.
> 
Okay, I will update this in v9.
>> +     if (!mc->ch_regs)
>> +             return -ENOMEM;
>> +
>> +     for (i = 0; i < mc->soc->num_channels; i++) {
>> +             char name[5];
>> +
>> +             snprintf(name, sizeof(name), "ch%u", i);
> 
> The type of "i" variable is int, change it to unsigned int.
> 
Okay, I will update in next version.

> With that:
> 
> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Thanks Dmitry.