Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
To:     cgel.zte@gmail.com
Cc:     james.smart@broadcom.com, dick.kennedy@broadcom.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] scsi: lpfc: fix error check return value of
 debugfs_create_file()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v8uwro3h.fsf@ca-mkp.ca.oracle.com>
References: <20220419014526.2561899-1-lv.ruyi@zte.com.cn>
Date:   Tue, 26 Apr 2022 09:06:21 -0400
In-Reply-To: <20220419014526.2561899-1-lv.ruyi@zte.com.cn> (cgel zte's message
        of "Tue, 19 Apr 2022 01:45:26 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OmtQS/BWrMCIJW6CHPf/uvEOE80ui5l0i1LwPNxcwREwTAjfBls0VbxeY2AK?=
 =?us-ascii?Q?ta+7dJX/FkVu5sF1JO6pVXWglGVrBxgpWUQWxdTrtveEmAmGQ1BA9+2mgl7e?=
 =?us-ascii?Q?0aJz/FviHOPMs6LXsmhOYFfPYjCHTYtizg8eIZVDVdqO7vkDCYWX6Argodkl?=
 =?us-ascii?Q?Rzquc0QBk1H1l5ozd4GtlWjABX7NnXeGN6vaym3iH7lGy89dfZVWV879fDpJ?=
 =?us-ascii?Q?rxaeMST+NuZjlLBOHHMjJ+AufDdm2Zujt5kQJ3Oxpllu0ZyguJmGwSafD2Qp?=
 =?us-ascii?Q?UJwdzgi4nvB5nRYV2MHAYm7smb1D1vGtk32UQrKg7KVXEiE3H0AX1yzxxRPb?=
 =?us-ascii?Q?HxgO17p3QdB0Lq9HVJfskcKjx0fpE2A9DsBa1/ni12x1tPaVWp1wLKEO+3Vb?=
 =?us-ascii?Q?sHxyywZP4e3o9vD/UMJa6Vx3Ar2mwg0HFY8BMd+tjqQdd/HYYZQ3D8Rnjx/U?=
 =?us-ascii?Q?oti9QTMJfGEz3JjdbNQhJw/i+LlO0RcgdqPYyL47s9gnHJ4gDlvjetwMpVbK?=
 =?us-ascii?Q?2r1ktL6fWyK8vlZyZ0d+by/8ICO/o/bT9Y1kuv1dvveZtpbuJodBFx6aEaEp?=
 =?us-ascii?Q?E40+JXI8AmL4VxoSn2PKcMDVyM2t9raddIJmtJxO+LsStaJ7tmgFMwtPML89?=
 =?us-ascii?Q?AcU9//qlupXhIf3zef4QDF13uBJ5kuJay2wKtovMSt8ZVRhfltW+WFlJmA7T?=
 =?us-ascii?Q?GS3fDsBns3swVNvY2nW8xt9g2NGK40LfYuXObnUB7n0GSo+reVJac/tFEC3g?=
 =?us-ascii?Q?55N5xEu4XcM6NlReYYd0gZ8cPY9vCj3MCGwhi2usJ3XI3O0TilYPvD6LsYTE?=
 =?us-ascii?Q?LsaMytoyQSpejgjrV0ebbUShlh68yuoOASuNbn8jUrCXpZIKYFxElZ686P4p?=
 =?us-ascii?Q?Wgq4nsk/4YjZE3AlKG0Kx9gk+QWyvfFbIJPqEiieyZVxGr1YPXS+G32HgYW5?=
 =?us-ascii?Q?U7wftTKuDeO2WAGOINVZom8oX+X6Ue8tCbI24zQGgnG7AtPxNalIV1u4iWlM?=
 =?us-ascii?Q?D5bZgo9ERl29sLxGKUdTy9Xqm98oJEuSja7vqqVFre84xEmstYNKcJCo6e3b?=
 =?us-ascii?Q?SFcXiuI3ULdKakivF+jQD0DPO0ttlGZ6fNZJB1R/Q9UZHz/yWkQIBNBFPPMY?=
 =?us-ascii?Q?Pxp8CSTfEuN4mnwkamMR7f0tWx69G+8YJ6l0N1vyYuw/iuN1rzFAjKnw6nK8?=
 =?us-ascii?Q?IbYCaSl4XhjO1wt0JZekviYutjNPjriucMJOZUbeeE4oCEgimKaDFrXd+wz6?=
 =?us-ascii?Q?K9Q63F0aScHlqpzot5kdvbTGuMd0g7yzLgTisZ1WVvdPYsv8qgoYuK/27jgK?=
 =?us-ascii?Q?c3sURY5J+Z71cPPkl+nYvijZJ7ywkKoDI9sB3OImAWlFkmgH67D9vRNWvzXv?=
 =?us-ascii?Q?TAikQyQuWq7o8SRyL6woAaBFCwMCNpYfEfae7VReiIxbrAyXNN7eTjkzmd9p?=
 =?us-ascii?Q?d5x1BXz+sVmkGzZk/fz6q93NyvjROnFxncLkiYm54vem4sQiNvHksY1K1JU1?=
 =?us-ascii?Q?NchldezbgkP7q85MniK1KEX114FFyOw5XwxsewlFNOENctt28u/q5U3CHE0C?=
 =?us-ascii?Q?AngOs6HkeWUbXmtpQ2fhGKhWIgJsRPGt7k8BNYtb+PIWAtU2UC1bX360NT4f?=
 =?us-ascii?Q?oqKK/QL0T6pGMO9LDGKzY8i8g+55hq4CQZXLoOgMMyoW/ePJ6UvjBitGUlRI?=
 =?us-ascii?Q?7vXo8Bmc0uHoq+1iSHeUN7BSkMLb5szQSoDYUcO8ZCBW+5OYuZhEFAzhINE5?=
 =?us-ascii?Q?zH89lyaLWESCkONsj8M9WTR9U9zKmyI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bceac44b-c737-43ac-b3a4-08da2785907b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 13:06:23.6380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ScTFzLAEXZF8t0wSRFdHFdemm+SS/BfvQ0jReh3kajsgoI5RHFyncBVp7Nl+UVyKJ0Ks6dMDrhuiW1fTceAumXf2NeikytOS+KlBOALxb9c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5000
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-26_02:2022-04-26,2022-04-26 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=694
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204260083
X-Proofpoint-GUID: d0AOTVaHoyysmEo-q2zeVqH0JOjHDt-u
X-Proofpoint-ORIG-GUID: d0AOTVaHoyysmEo-q2zeVqH0JOjHDt-u
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR),
> so use IS_ERR() to check it.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering