Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220427074351.391580-1-juergh@protonmail.com>
References: <20220427074351.391580-1-juergh@protonmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Juerg Haefliger <juergh@protonmail.com>
To:     Juerg Haefliger <juerg.haefliger@canonical.com>,
        davem@davemloft.net, herbert@gondor.apana.org.au,
        linux-crypto@vger.kernel.org
From:   Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH v2] crypto: inside-secure - Add MODULE_FIRMWARE macros
Message-ID: <165104586605.3327.5179101284332639573@kwain>
Date:   Wed, 27 Apr 2022 09:51:06 +0200
Precedence: bulk

Quoting Juerg Haefliger (2022-04-27 09:43:51)
> The safexcel module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
>=20
> Signed-off-by: Juerg Haefliger <juergh@protonmail.com>

LGTM, thanks!

Acked-by: Antoine Tenart <atenart@kernel.org>

> ---
> v2:
>  Add legacy fallback firmware locations.
> ---
>  drivers/crypto/inside-secure/safexcel.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/ins=
ide-secure/safexcel.c
> index 9ff885d50edf..9b1a158aec29 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1997,3 +1997,12 @@ MODULE_AUTHOR("Igal Liberman <igall@marvell.com>");
>  MODULE_DESCRIPTION("Support for SafeXcel cryptographic engines: EIP97 & =
EIP197");
>  MODULE_LICENSE("GPL v2");
>  MODULE_IMPORT_NS(CRYPTO_INTERNAL);
> +
> +MODULE_FIRMWARE("ifpp.bin");
> +MODULE_FIRMWARE("ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197b/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197d/ipue.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ifpp.bin");
> +MODULE_FIRMWARE("inside-secure/eip197_minifw/ipue.bin");
> --=20
> 2.32.0
>=20