Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     Ira Weiny <ira.weiny@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Will Deacon <will@kernel.org>,
        Peter Collingbourne <pcc@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        outreachy@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 4/4] Documentation/vm: Rework "Temporary Virtual Mappings" section
Date:   Tue, 26 Apr 2022 20:31:12 +0200
Message-ID: <3429395.iIbC2pHGDl@leap>
In-Reply-To: <Ymfb1saaHVuq4IUl@linutronix.de>
References: <20220425162400.11334-1-fmdefrancesco@gmail.com> <3610796.MHq7AAxBmi@leap> <Ymfb1saaHVuq4IUl@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk

On marted=C3=AC 26 aprile 2022 13:47:34 CEST Sebastian Andrzej Siewior wrot=
e:
>=20
> Hmm. It is thread-local in the end. There are slots 0 =E2=80=A6 KM_MAX_ID=
X for
> the mappings. Slot 0 for task A can be different from slot 0 for task B
> while both run on CPU0. So the same address, that is returned from
> kmap_local(), will point to a different page for both tasks. Both tasks
> can't be migrated to another CPU while the mapping is active.
> "CPU local" sounds like something that is same to everyone on the same
> CPU which is what this_cpu_read() for instance does.
>=20

OK, I agree with you :)=20

I just got three notices from Greg K-H stating that he has applied three of=
=20
my driver / Android patches. The patches are some conversions from kmap()=20
and / or kmap_atomic() to kmap_local_page() (or wrappers around it):

https://lore.kernel.org/lkml/20220425175754.8180-4-fmdefrancesco@gmail.com/
https://lore.kernel.org/lkml/20220425175754.8180-3-fmdefrancesco@gmail.com/
https://lore.kernel.org/lkml/20220425175754.8180-2-fmdefrancesco@gmail.com/

I had forgotten that I wrote the following sentence in all three commit=20
messages: "[] With kmap_local_page(), the mapping is per thread, CPU local=
=20
and not globally visible. []"

Therefore, I'll add "thread-local" or "per thread". I probably like your=20
wording more than mine: "thread-local" is more suitable.

=46or consistency (again) I like the other change you proposed, which is to=
=20
add "deprecated!" also in kunmap_atomic(), exactly as it is already in=20
kmap_atomic() kernel-docs.

However, I will wait one more day before sending v3, in case there are=20
other people who want to suggest further changes.

If I remember correctly, I'm overlooking nothing else. Do I overlook=20
something?

Thanks for your help,

=46abio