Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 26 Apr 2022 12:53:18 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Wang, Zhi A" <zhi.a.wang@intel.com>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PULL] gvt-next
Message-ID: <20220426155318.GQ2125828@nvidia.com>
References: <c5cf6773-e7a2-8ba8-4cde-0bb14007bc6b@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c5cf6773-e7a2-8ba8-4cde-0bb14007bc6b@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bxqqY8w+h1y6yoHLli5Z6lmChgVpQE4+RZal09Jds+crNyboh7MCoV6YbaBs?=
 =?us-ascii?Q?4FEYHxEVqiDzxwiNtrKqZ0hU11SRZz6EVpZf+6vr3OwjOtOfQ50oikFE+jo4?=
 =?us-ascii?Q?jWC5A34ipEHq/mIZoiMb2JbjqvGvALny49+0nv4ZReR25rKzOzQ8YewaQi/z?=
 =?us-ascii?Q?Vd0IjnXUkEO3/3V9IJCVObUMY2O30mxXXweyEBysoUBotkEptRrgqdYNgHXf?=
 =?us-ascii?Q?BzXgE2zvDhlIyedqQo+W65/Q//j8+h/u8Z1TY/itRBp+DzJBCWG1QmOOvYyL?=
 =?us-ascii?Q?slPlUjSFSNuwxQCj4gvU38scHGwRWjkqh0trw+/+JFueR5ezxtYl2C+EMoCK?=
 =?us-ascii?Q?YrKk0N/4V6BhoFSZrHl+PYv/z8X64KRn1837b2nNq/rv9ioJaG5A15Tssx8D?=
 =?us-ascii?Q?bU5SjPoy2L66GRah6E/dn+srJ2ffBQH/kqNZnhctgtisv4vjN21Hn3ZskAqg?=
 =?us-ascii?Q?7ekZbpQ/OqQRFnAjdFb16NvAWPCOgCDIGCkJ/g2R8eiEMKN1Yan0NwShQMWA?=
 =?us-ascii?Q?pbQQH+/qa6ypbh9cUxSyFTqQqS+s8rHdTiV/u/LO07P6o6LB8V4TV8upGI/2?=
 =?us-ascii?Q?tmB+Lr0iZr0Y7KMVhyL4fjq2QcfyZ6JoTT/zyRYIDcu45UyESbLDfSMQrqqk?=
 =?us-ascii?Q?llWtDAqYdNEGQHA9LtBDLgML5zDQ6naeEz+4UtsCdDCy8vDtrUkZHkd/7oVS?=
 =?us-ascii?Q?GIXGckLP9q60qMgZztK+0Hdd5rMWuUS2NIsmTJi2rlrUayEnycO+ZcKpW/XM?=
 =?us-ascii?Q?3tOwgcKksQPGvwSwR7bcyjN+d0AT34/DJ3qJQNhlpiFyVtcg0nQPvfegaY6w?=
 =?us-ascii?Q?JHJX9GdU0KdVg+g0zGPHy4vMdIA3ar10+pI9cpmXrfMjF9EymMh5a85cwQLg?=
 =?us-ascii?Q?Wu30Q/lot9sglG0Mrwz2t3bhBZQKouCUK4bcbg6Kp1XHs0CsWUjoL6JfoH/x?=
 =?us-ascii?Q?Pa4K0HtkAcXNGWOmFGzhkDQwElW3TlNi2CUJADAA0ZzFeEjh9tILHQZPlEYi?=
 =?us-ascii?Q?ZqPwgz6IKSieBpf1R4WJlajgqdlaQD64HlVpJv5XW/SIbIXdfEin7qtVXdYh?=
 =?us-ascii?Q?faJdaujk/cn/Me4/ZJBIoyIM0Y6CSDG2DY3M0qLfq/FKaKlrId73SHxgSsMf?=
 =?us-ascii?Q?+wuDlrltC8xMKVNpOTBJMMYNkkQEJ/otrcjidpxu8NkKpCpzikO6tJxkUKPI?=
 =?us-ascii?Q?IGW4fFSQqB68QCbKbm8iTkx0R92BhUV1gO+Ma3ulFr+o8pY5VikC98W+cYm0?=
 =?us-ascii?Q?kTb7bg5d4Wg79UoDrnuqFlXM41/7Q0XDQd+CMjRmVcxldLQtHjFUxjJyLEoR?=
 =?us-ascii?Q?tMZSjXYssxs7TDUGAimqnYsIJmL/EA7M0HXMznIlwEepyLqwQg4kYopWP39D?=
 =?us-ascii?Q?lKT57VLwHqqYi9dA6+2+QZojQfQ6L+vxB6YAIhdh/r7WAVTqx9Eg3CdQrvrJ?=
 =?us-ascii?Q?vKI+5V/BDfdQy4BkxvaJl3OEUIIrBDfjZIe2wAIOepL0D3lyBxWpsubdlD4k?=
 =?us-ascii?Q?DXTmk2C1Z73T/uuAGWOCc7J3RKaYz/QDbEe2U9NaN5gaPGBKkXf/YghqUacn?=
 =?us-ascii?Q?KY6sk+sWE4zVnOdBgIBTm79zdvgFkv9ErCu3PHuxaqzOjmno8EYqmJ1H6vfe?=
 =?us-ascii?Q?01MeRS0U15aYSD/mVFbEi53qn2qWZW8arcOw84jN1E9z963PcWQxNRggwuk8?=
 =?us-ascii?Q?2VtljqEJdvQCeXtGTN4wFzON21q4u7gDQjZ8xgKItwuPxZz22jusqbOqOSA3?=
 =?us-ascii?Q?+bYxQV/vaQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80e45027-ea87-44b7-1ff7-08da279ce277
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 15:53:19.7791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7BLCQ00Sa8Nazr1NwL6j7Sb0LvexgOpP1vNrnLPmymsLpaVjcybOcOfZu1K24+RM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6292
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 26, 2022 at 07:58:59AM +0000, Wang, Zhi A wrote:
> Hi folks:
> 
> Here is the pull of gvt-next which fixs the compilation error when i915 debug
> is open after the GVT-g refactor patches.
> 
> Thanks so much for the efforts.
> 
> Thanks,
> Zhi.
> 
> The following changes since commit 2917f53113be3b7a0f374e02cebe6d6b749366b5:
> 
>   vfio/mdev: Remove mdev drvdata (2022-04-21 07:36:56 -0400)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux tags/gvt-next-2022-04-26
> 
> for you to fetch changes up to 2da299cee780ea797b3f72558687868072cf5eb5:
> 
>   drm/i915/gvt: Add missing export of symbols. (2022-04-25 18:03:04 -0400)
> 
> gvt-next-2022-04-26
> 
> - Add two missing exports of symbols when i915 debug is enabled.
> 
> Zhi Wang (1):
>       drm/i915/gvt: Add missing export of symbols.
> 
>  drivers/gpu/drm/i915/intel_gvt.c | 2 ++
>  1 file changed, 2 insertions(+)

This still has another compile problem:

ERROR: modpost: "intel_runtime_pm_put" [vmlinux] is a static EXPORT_SYMBOL_GPL

Because:

#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
void intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref);
#else
static inline void
intel_runtime_pm_put(struct intel_runtime_pm *rpm, intel_wakeref_t wref)
{
        intel_runtime_pm_put_unchecked(rpm);
}
#endif

Looks like it happens if CONFIG_DRM_I915_DEBUG_RUNTIME_PM=n

I think you probably want to #ifdef the export in the same way:

--- a/drivers/gpu/drm/i915/intel_gvt.c
+++ b/drivers/gpu/drm/i915/intel_gvt.c
@@ -309,7 +309,9 @@ EXPORT_SYMBOL_NS_GPL(__intel_context_do_pin, I915_GVT);
 EXPORT_SYMBOL_NS_GPL(__intel_context_do_unpin, I915_GVT);
 EXPORT_SYMBOL_NS_GPL(intel_ring_begin, I915_GVT);
 EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_get, I915_GVT);
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
 EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put, I915_GVT);
+#endif
 EXPORT_SYMBOL_NS_GPL(intel_runtime_pm_put_unchecked, I915_GVT);
 EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_for_reg, I915_GVT);
 EXPORT_SYMBOL_NS_GPL(intel_uncore_forcewake_get, I915_GVT);

Jason