Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4429691ioa; Wed, 27 Apr 2022 03:48:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMhPwStXLfGmUJxWemWnR9xuDwKd0eJBrceDyR5XpRw2P6B1Q2CEnbdPA8V19XGgK1GBOc X-Received: by 2002:a17:902:ea0d:b0:15c:eceb:de38 with SMTP id s13-20020a170902ea0d00b0015cecebde38mr20453072plg.37.1651056517834; Wed, 27 Apr 2022 03:48:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651056517; cv=none; d=google.com; s=arc-20160816; b=MScQs/RUbyl+HN/O6Z7uQpLhr8kuAXFSRpl0NodJA9RN8sD+XSLm4OaMqWenx2XEmM zzh+fgKqWJZYilNF0Z1tQgOWaeU80/KEU9PsnCoHrFP6Nbzsq7+hhTPTpSTMitb7WqeJ r9RVVyXWmxrGTg1Sp8h0ix4WDAcpcPS9+1cm5gl5ZfkoRR3mv9skXFPUrI+ZkUSPrPD4 isv7cuwtjKEaFUXW+7nbGEX0wJujXTU+GdZBm63EeGa81TXLsKotlr45l/AITMvaQsZ3 K0cYMWh9N4Ja+CSQq02HJ9/jHG+LLRJJP2UpeKX/VRi5oJx8SnFyD7JJDXunDR4o1j38 gnUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cpdMDhdETrLPO+0lYtKXqDQD+qs3opUgU/Zd3utPHGE=; b=O3laAHWWsIGFvjJ1tCPs7tTd0nRlTSC4EYX8oPNsPZl1AftyYz+6RGlcwddDbQOp2S Jsl+tQtdJ7ebh1Qi3bqVzC7n1H8wSnochpomn4XjdYJTV74lo/MzXS4qqogpyHCocrgK KgEE4ul07kfJEiaYiOZovJ7ruUfMKL/s/H5c1BfgvxC0qTEvS1+evK4YGQ1YPHzf889W YOE+VpIZrpVfH1LyXnWvq+f5dQvR975b2lIIxuEzaR/Jd4LWp3mqD8s+4ff2fICmgU+4 pbmmM5VY/mnA6ArItiOayUd9oZSGVZPa5Q2uyklHVOEfJzGX+lhvbtORLCOyFV8BUjmm yZ5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QPkyHwPJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d3-20020a63fd03000000b003816043ef2bsi1166300pgh.288.2022.04.27.03.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 03:48:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QPkyHwPJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 668983F6123; Wed, 27 Apr 2022 02:55:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347068AbiDZJFO (ORCPT + 99 others); Tue, 26 Apr 2022 05:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346669AbiDZIpR (ORCPT ); Tue, 26 Apr 2022 04:45:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65985659C; Tue, 26 Apr 2022 01:35:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2AC1EB81D09; Tue, 26 Apr 2022 08:35:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 948C6C385A4; Tue, 26 Apr 2022 08:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650962115; bh=o/R0aJ4jPfYY10v7Gc2Gjzn6zzboIP/onUXcr2KTwLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QPkyHwPJ75Y/d/EVJsy0pRzAzxJATuAAsKJoRUF4ZsPNWIGptgiMNZ+Mf1MwqlUEu mfnoxoydeccwVp5YAGsID8EFc5ZKlIiRET82fy8u6sE+JgDNXthItOQTz9wvsyVEZH l5V0eCyeGXzzAl7UCZNExq55Qp4G5ouR7iK/PpDw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Howells , Steve French , Shyam Prasad N , Rohith Surabattula , linux-cifs@vger.kernel.org, Steve French , Sasha Levin Subject: [PATCH 5.10 40/86] cifs: Check the IOCB_DIRECT flag, not O_DIRECT Date: Tue, 26 Apr 2022 10:21:08 +0200 Message-Id: <20220426081742.362639259@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426081741.202366502@linuxfoundation.org> References: <20220426081741.202366502@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells [ Upstream commit 994fd530a512597ffcd713b0f6d5bc916c5698f0 ] Use the IOCB_DIRECT indicator flag on the I/O context rather than checking to see if the file was opened O_DIRECT. Signed-off-by: David Howells cc: Steve French cc: Shyam Prasad N cc: Rohith Surabattula cc: linux-cifs@vger.kernel.org Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/cifsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index aa5a4d759ca2..370188b2a55d 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -898,7 +898,7 @@ cifs_loose_read_iter(struct kiocb *iocb, struct iov_iter *iter) ssize_t rc; struct inode *inode = file_inode(iocb->ki_filp); - if (iocb->ki_filp->f_flags & O_DIRECT) + if (iocb->ki_flags & IOCB_DIRECT) return cifs_user_readv(iocb, iter); rc = cifs_revalidate_mapping(inode); -- 2.35.1