Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4432679ioa; Wed, 27 Apr 2022 03:52:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWPXr8AB+IRnDSW9onvYH5IEkBnw7y8unTPKAeBXA/Oyvt2d7hO/IsiuqDJc6RnMjz2Y7A X-Received: by 2002:a17:90a:9308:b0:1cb:a048:c140 with SMTP id p8-20020a17090a930800b001cba048c140mr32595160pjo.221.1651056762962; Wed, 27 Apr 2022 03:52:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651056762; cv=none; d=google.com; s=arc-20160816; b=v3LtG/N4Bi6dLL/GZdJkn6Y0xzVhf/PBDiWZulmDBPXPcwGFrqUIQCjaTRoehJ83d8 wuKtlJ3OlsKfbFMiZW/MaA7g6VE6PpGmORCFHRGjmZROedO6r8Lnimra2yXwK/nb0J+f laAZ7+5DlMppapfN8cBLvayLFlNlljD+EyyyYk9ik5Y2VzOd9RUzVvwoME3JMt8k2mOY rAjYX/zC7piaF6zq7iDzgXB0hJr2rIrLVsbnVGPfIS9wzRYbx4aEokDJbC9KY5I44/Vd fPuixdDIWvBgRKYr8oSl6pYZ7fCxvBzONf2bJL5OXhHVoTeMKwNJYvzfxF+gvzHsp/mi tZGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=7AQ9pDgmUR3/5GMyR8/qw5HmgtauCGUA6F4/hdOHZ/Y=; b=h2nxMIeIAiHFGUHs+RFy075bYP5ICtVNUX8HnIROppj8zXttAUkjfBHOA7CNvKof3s ZYSvKfjL+T8Nf+wOxC0wvLht1sesM2RkO+3FDivghCWSyt6Pz4Fp9FyYZo3ZJLVHaC1L t5E24Xdys+fm1Xc9YFi+aRfplfDesksrqbYxaeQ8l6ZX6ZCRu4iPo+bykvs1EkqN2a+/ vtZSOmcDEaPa8YiT4skF9wTZEAdtPX8CePI9JFL5Uj9JEA9GVeFJPaPA0UNS7lQeA8VQ KUIoGNwYgpbzATaPdMNxuOOfKssF1GNCbQ/DYXhiPgeQxDKwS9/p0dIEgQNW7B1yNBRW sHTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id w7-20020a63a747000000b003816043ef0dsi1232799pgo.258.2022.04.27.03.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 03:52:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DA292407EEC; Wed, 27 Apr 2022 02:58:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346865AbiDZLMb (ORCPT + 99 others); Tue, 26 Apr 2022 07:12:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240024AbiDZLM1 (ORCPT ); Tue, 26 Apr 2022 07:12:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 368433B3C5; Tue, 26 Apr 2022 04:09:19 -0700 (PDT) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KnfJx3RflzhYs4; Tue, 26 Apr 2022 19:09:05 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 19:09:17 +0800 From: Yuan Can To: CC: , , , Subject: [PATCH -next] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram Date: Tue, 26 Apr 2022 11:05:13 +0000 Message-ID: <20220426110513.49575-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns. Fixs: 86559400b3ef9d (rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U) Signed-off-by: Yuan Can --- drivers/rtc/rtc-gamecube.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c index 18ca3b38b2d0..c2717bb52b2b 100644 --- a/drivers/rtc/rtc-gamecube.c +++ b/drivers/rtc/rtc-gamecube.c @@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d) ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias); if (ret) { pr_err("failed to get the RTC bias\n"); + iounmap(hw_srnprot); return -1; } -- 2.17.1