Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4433139ioa; Wed, 27 Apr 2022 03:53:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNJny0RGHoISmN+bJDkXGdq1auXMojqTjTlcszfHP587eHJ/JlyNwtYEn2PRbDJKAniuck X-Received: by 2002:a17:90b:3445:b0:1d6:91a5:29fe with SMTP id lj5-20020a17090b344500b001d691a529femr35062300pjb.138.1651056814507; Wed, 27 Apr 2022 03:53:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651056814; cv=none; d=google.com; s=arc-20160816; b=Q1uCIgrdCBZzjIJBr8UKluYvwEFZiXcUs3nkE3BBli28NMOYj6FjnwECyWOYEwmGFm +vtb40iJb61M5eiHy98nt/g8R494l8Z1QT2e38PBzZAp5E34pduU5nULqCkfQn03s5wl uI3JmrYOk2HXc5ZhLHFskUikMEBlWjF7qA2oMyb+QIE5D02MLSlJXGx1MIXqeUHbkFSb WcciTmGsvUin7POM+N01jpf/UlMkOkg5R3LdLNg5SUGoXNDzT/Npuihalei3/VEirY1s ZrEbjK218xXXfkVYngm+FL3WpSCcQgc1JC8TAZ+5xbJEkenrjxjrKa15NAYwvTB9rdfu 8Yaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cq2Z0tEUie6skAAHOz0eGUYyIhz+Bb5sglCwxsSckqI=; b=wMtasUkca1AuRK536ymVyrtkRrEXEggEnqSekeryoM24dRnlQv3XM1i7TZcvDGfzUr i/NJaxlkf/M3ZGw0wxnxW3Ov5qb+x0JmlNhtQeHUyIsRAtU4tS3BA8s79HX4a9N+g2Mn /BNXPhmasichWulWZA8byBktXQ8B14ao90oqb/nj+gDnEqMr40Q7/Bj73GVi9MNpYDvZ 59lDXw5i3IhBZ2jAdxKtZe/xcE1AD06hTDcHwVX7EE0ZGqUm1LlEFYCBiLtlLJUikkiu r+UTC3kcdoDEdLCAfShUx02Pe1ZMqOmUL6FP8vrEvAyDZj39t+GllnEBbVXPP4eXnaqL GEMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YfUx0XBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h30-20020a63121e000000b003ab894f4e5dsi1050259pgl.526.2022.04.27.03.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 03:53:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YfUx0XBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DCD48A9C5; Wed, 27 Apr 2022 02:59:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350344AbiDZNBW (ORCPT + 99 others); Tue, 26 Apr 2022 09:01:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350315AbiDZNBO (ORCPT ); Tue, 26 Apr 2022 09:01:14 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E38417E21D; Tue, 26 Apr 2022 05:58:03 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nicolas) with ESMTPSA id 357771F4398F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1650977882; bh=CR0Uld+xP65yR8nRZHFwyooNDEbFE3R+SnqsqiS63yI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YfUx0XBD1y7yy1+Nfm9IpGmZ9onovXxyqFs5+/7/NUnbcF92hMSndIS3Bw49UATy3 MiDj9S6OLVmUMPZOmD5YMFCChSuuDUnaV3nOtlmdrptn6WlGZMQUXCGVcnxi1a0QYx TjdKAhI5PkBqat5/wCZfnKT3vvvYNYMpxCnDeuKOfBldx7Djsyo1ulZybWEU4NLt1N KMMQUrp55POy6wnaFDscb7yiMUJYe6Ny68u/rDSv3qhUZIVYpPZg4jNVvQEkXv/z/a eI3NGaO5BK+yf4XWoaErYP+zpvEbtmZcjYmCoIsbCBIkd+sZdbtVBre7WihsX0yYAh wjaaZAMkzOxPA== From: Nicolas Dufresne To: Mauro Carvalho Chehab Cc: nicolas@ndufresne.ca, linux-media@vger.kernel.org, Sebastian Fricke , Ezequiel Garcia , linux-kernel@vger.kernel.org Subject: [PATCH v4 02/24] media: v4l2-mem2mem: Trace on implicit un-hold Date: Tue, 26 Apr 2022 08:57:28 -0400 Message-Id: <20220426125751.108293-3-nicolas.dufresne@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220426125751.108293-1-nicolas.dufresne@collabora.com> References: <20220426125751.108293-1-nicolas.dufresne@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the timestamp of the src buffer differs from the timestamp of a held dst buffer, the held buffer is implicitly removed and marked as done. Add a trace to help debugging if someone hits that case. Signed-off-by: Nicolas Dufresne Reviewed-by: Sebastian Fricke Reviewed-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-mem2mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 675e22895ebe..d1d29d6ab024 100644 --- a/drivers/media/v4l2-core/v4l2-mem2mem.c +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c @@ -336,6 +336,7 @@ static void __v4l2_m2m_try_queue(struct v4l2_m2m_dev *m2m_dev, if (src && dst && dst->is_held && dst->vb2_buf.copied_timestamp && dst->vb2_buf.timestamp != src->vb2_buf.timestamp) { + dprintk("Timestamp mismatch, returning held capture buffer\n"); dst->is_held = false; v4l2_m2m_dst_buf_remove(m2m_ctx); v4l2_m2m_buf_done(dst, VB2_BUF_STATE_DONE); -- 2.34.1