Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 26 Apr 2022 09:14:03 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     kernel test robot <lkp@intel.com>
Cc:     Abhishek Sahu <abhsahu@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>, kbuild-all@lists.01.org,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/8] vfio/pci: Invalidate mmaps and block the access
 in D3hot power state
Message-ID: <20220426141403.GA1723756@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202204260928.TsUAxMD3-lkp@intel.com>
Precedence: bulk

On Tue, Apr 26, 2022 at 09:42:45AM +0800, kernel test robot wrote:
> ...

> sparse warnings: (new ones prefixed by >>)
> >> drivers/vfio/pci/vfio_pci_config.c:703:13: sparse: sparse: restricted pci_power_t degrades to integer
>    drivers/vfio/pci/vfio_pci_config.c:703:22: sparse: sparse: restricted pci_power_t degrades to integer

I dunno what Alex thinks, but we have several of these warnings in
drivers/pci/.  I'd like to get rid of them, but we haven't figured out
a good way yet.  So this might be something we just live with for now.

> vim +703 drivers/vfio/pci/vfio_pci_config.c
> 
>    694	
>    695	/*
>    696	 * It takes all the required locks to protect the access of power related
>    697	 * variables and then invokes vfio_pci_set_power_state().
>    698	 */
>    699	static void
>    700	vfio_lock_and_set_power_state(struct vfio_pci_core_device *vdev,
>    701				      pci_power_t state)
>    702	{
>  > 703		if (state >= PCI_D3hot)
>    704			vfio_pci_zap_and_down_write_memory_lock(vdev);
>    705		else
>    706			down_write(&vdev->memory_lock);
>    707	
>    708		vfio_pci_set_power_state(vdev, state);
>    709		up_write(&vdev->memory_lock);
>    710	}
>    711	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp