Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <1976e57f-d9b6-a6cb-3565-bab5aa9f215d@linux.ibm.com>
Date:   Tue, 26 Apr 2022 10:46:06 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 2/2] hwmon (occ): Retry for checksum failure
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        "'Guenter Roeck'" <linux@roeck-us.net>
Cc:     "linux-fsi@lists.ozlabs.org" <linux-fsi@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "joel@jms.id.au" <joel@jms.id.au>, "jk@ozlabs.org" <jk@ozlabs.org>,
        "alistair@popple.id.au" <alistair@popple.id.au>
References: <20220321153112.12199-1-eajames@linux.ibm.com>
 <20220321153112.12199-3-eajames@linux.ibm.com>
 <20220424171816.GA749761@roeck-us.net>
 <44d4f10249064a28b6cc461e7cbdd402@AcuMS.aculab.com>
From:   Eddie James <eajames@linux.ibm.com>
In-Reply-To: <44d4f10249064a28b6cc461e7cbdd402@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/25/22 04:10, David Laight wrote:
> From: Guenter Roeck
>> Sent: 24 April 2022 18:18
>>
>> On Mon, Mar 21, 2022 at 10:31:12AM -0500, Eddie James wrote:
>>> Due to the OCC communication design with a shared SRAM area,
>>> checkum errors are expected due to corrupted buffer from OCC
>>> communications with other system components. Therefore, retry
>>> the command twice in the event of a checksum failure.
>>>
>>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> I assume this will be applied together with patch 1 of the series.
>>
>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Guenter
>>
>>> ---
>>>   drivers/hwmon/occ/p9_sbe.c | 28 ++++++++++++++++++----------
>>>   1 file changed, 18 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/drivers/hwmon/occ/p9_sbe.c b/drivers/hwmon/occ/p9_sbe.c
>>> index 49b13cc01073..7f4c3f979c54 100644
>>> --- a/drivers/hwmon/occ/p9_sbe.c
>>> +++ b/drivers/hwmon/occ/p9_sbe.c
>>> @@ -84,17 +84,25 @@ static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd, size_t len)
>>>   	struct p9_sbe_occ *ctx = to_p9_sbe_occ(occ);
>>>   	size_t resp_len = sizeof(*resp);
>>>   	int rc;
>>> -
>>> -	rc = fsi_occ_submit(ctx->sbe, cmd, len, resp, &resp_len);
>>> -	if (rc < 0) {
>>> -		if (resp_len) {
>>> -			if (p9_sbe_occ_save_ffdc(ctx, resp, resp_len))
>>> -				sysfs_notify(&occ->bus_dev->kobj, NULL,
>>> -					     bin_attr_ffdc.attr.name);
>>> +	int tries = 0;
>>> +
>>> +	do {
> Why not use a for() loop?
>
>>> +		rc = fsi_occ_submit(ctx->sbe, cmd, len, resp, &resp_len);
>>> +		if (rc < 0) {
>>> +			if (resp_len) {
>>> +				if (p9_sbe_occ_save_ffdc(ctx, resp, resp_len))
>>> +					sysfs_notify(&occ->bus_dev->kobj, NULL,
>>> +						     bin_attr_ffdc.attr.name);
>>> +
>>> +				return rc;
>>> +			} else if (rc != -EBADE) {
>>> +				return rc;
>>> +			}
> No need for else after return.
>
>>> +			/* retry twice for checksum failures */
>>> +		} else {
>>> +			break;
> I'd break on the success path after testing (rc >= 0).
> Saves a level of indent.
>
>>>   		}
>>> -
>>> -		return rc;
>>> -	}
>>> +	} while (++tries < 3);
>>>
>>>   	switch (resp->return_status) {
>>>   	case OCC_RESP_CMD_IN_PRG:
> Probably end up with something like:
> 	for (tries = 0; tries < 3; tries++) {
> 		rc = ...;
> 		if (rc >= 0)
> 			break;
> 		if (resp_len) {
> 			...
> 			return rc;
> 		}
> 		if (rc != -EBADE)
> 			return rc;
> 	}
>
> 	David


Thanks David, Ack.


>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>