Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220425085127.2009-1-etienne.carriere@linaro.org> <YmgiQmeQSkglljEl@e120937-lin>
In-Reply-To: <YmgiQmeQSkglljEl@e120937-lin>
From:   Etienne Carriere <etienne.carriere@linaro.org>
Date:   Wed, 27 Apr 2022 08:16:58 +0200
Message-ID: <CAN5uoS-djeP+79Gqsy7cO3RR6p55C=X8Net6jvL98X6P-S3q1g@mail.gmail.com>
Subject: Re: [PATCH v3] firmware: arm_scmi: support optee shared memory in
 optee transport
To:     Cristian Marussi <cristian.marussi@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 26 Apr 2022 at 18:48, Cristian Marussi <cristian.marussi@arm.com> wrote:
>
> On Mon, Apr 25, 2022 at 10:51:27AM +0200, Etienne Carriere wrote:
> > Adds support for tee shared memory in optee scmi transport. When using
> > tee shared memory, scmi optee transport manages SCMI messages using
> > msg protocol (from msg.c) in shared memory, whereas smt (from shmem.c)
> > protocol is used with static IOMEM shared buffers.
> >
> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> > ---
> > Changes since v2:
> > - Select configuration switch ARM_SCMI_HAVE_MSG when
> >   ARM_SCMI_TRANSPORT_OPTEE is enabled.
> > - Don't consider tee_shm in invoke_process_smt_channel() since
> >   this function now assumes TEE shared memory is not used for SMT
> >   based channel.
> >
> > Changes since v1:
> > - Remove call to scmi_rx_callback() in scmi_optee_send_message().
> > ---
>
> LGTM
>
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>
> Thanks,

Thanks for the help.

br,
etienne

> Cristian
>