Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <55c946ad-5d19-1d38-3484-1ab059a27642@gmail.com>
Date:   Wed, 27 Apr 2022 10:50:42 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 3/3] rpmsg: virtio: Fix the unregistration of the
 device rpmsg_ctrl
Content-Language: en-US
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
Cc:     bjorn.andersson@linaro.org, arnaud.pouliquen@foss.st.com,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220426060536.15594-1-hbh25y@gmail.com>
 <20220426060536.15594-4-hbh25y@gmail.com> <20220426165613.GA2007637@p14s>
From:   Hangyu Hua <hbh25y@gmail.com>
In-Reply-To: <20220426165613.GA2007637@p14s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/4/27 00:56, Mathieu Poirier wrote:
> On Tue, Apr 26, 2022 at 02:05:36PM +0800, Hangyu Hua wrote:
>> Unregister the rpmsg_ctrl device instead of just freeing the
>> the virtio_rpmsg_channel structure.
>> This will properly unregister the device and call
>> virtio_rpmsg_release_device() that frees the structure.
>>
>> Fixes: c486682ae1e2 ("rpmsg: virtio: Register the rpmsg_char device")
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
>> Cc: Hangyu Hua <hbh25y@gmail.com>
>> Reviewed-by: Hangyu Hua <hbh25y@gmail.com>
>> ---
>>   drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
>> index 291fc1cfab7f..485e95f506df 100644
>> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
>> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
>> @@ -862,7 +862,7 @@ static void rpmsg_virtio_del_ctrl_dev(struct rpmsg_device *rpdev_ctrl)
>>   {
>>   	if (!rpdev_ctrl)
>>   		return;
>> -	kfree(to_virtio_rpmsg_channel(rpdev_ctrl));
>> +	device_unregister(&rpdev_ctrl->dev);
> 
> The author of this patch should have been Arnaud, something I have fixed before
> applying this set.
> 
> Thanks,
> Mathieu
> 

I get it. I'm sorry i thought Signed-off-by and a description in cover 
letter are enough to express. Do i need to do anything else?

Thanks,
Hangyu
>>   }
>>   
>>   static int rpmsg_probe(struct virtio_device *vdev)
>> -- 
>> 2.25.1
>>