Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4438028ioa; Wed, 27 Apr 2022 04:01:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgS2K9M478JyJ7y0+x9vL16UjiGIqPBI18qZZHryl6D12tjQ3MHFDOaIZuSNlZJebvtyfb X-Received: by 2002:a17:90a:cf:b0:1d9:44ad:2607 with SMTP id v15-20020a17090a00cf00b001d944ad2607mr22537482pjd.25.1651057278130; Wed, 27 Apr 2022 04:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651057278; cv=none; d=google.com; s=arc-20160816; b=Dyt6kz9y2D/Zrbr1HnoC2mSpbVWptmmeCh/0Gb/b16sU7c9NBC3cPf4jwGcFgFYjIH hsHzex2eBPzyVUmV+nxMvlBnCF9uPi/haGYnl6s5Yfa7NBY7s/XfEWwXNYVUFpMDyInC N4eaQ6DBYG7JPLM5qN6F34wFyUqZnUi1VFfUMKnWVInsndf9rOwsCs1CHG4HNZhRJaQH dsznvwFwokQzs2okafh3xhhXZheU6RIhtJX/JuAG014Kyv5cXdZywmMf/FQduhn8dg7w IzNsQ7HU77AUcHDQ3l2Oe1ZXYKcv+Wb0CjZiK22SBxiSskHa9+RZx55nkOPq0CQNvH11 Kl4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wTj8AKCs3zuRDbDEYEDKE14JrakEZyuCT3UgfuvzLgw=; b=lclYKAkMzrk/3aUugQ8Rb10Nz8yyDWhPT19gm5NvpXWZ180FAF+eR+7B4HpBXaLqkx /kmAG4thEDmjJKkwMA6Iy6tSdZjSxwHEiZbTJQIWNKrEWcFZ4E7G2V933YXXW8RR7huW mWOY7Pj+MecmrKOBnDE1wYIzk40F5PY7Dz8itnLHtirIrNeBppISEmqvfSIxm4NN1r4m zWtt9E0XPVXFVmLp5nYVQzuvmmmQ7FWuaIHkbOnIY/kACTkJ3Nm3pom49On5zN1VEAu9 LCg4Q8qI/03jxGyZpNfjR7VTM0ylY5KU3kHdqI2Eib8C71sCI81MEbUtMVTpiF+UQ2h1 E1QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k14-20020a170902d58e00b00156b1cd8b9dsi719071plh.206.2022.04.27.04.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:01:18 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 462213010C7; Wed, 27 Apr 2022 03:09:59 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356489AbiD0Aw0 (ORCPT + 99 others); Tue, 26 Apr 2022 20:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347338AbiD0AwU (ORCPT ); Tue, 26 Apr 2022 20:52:20 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C23FA5F8CE; Tue, 26 Apr 2022 17:49:10 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R511e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VBPajTW_1651020547; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VBPajTW_1651020547) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Apr 2022 08:49:08 +0800 From: Yang Li To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] Input: Remove unnecessary print function dev_err() Date: Wed, 27 Apr 2022 08:49:06 +0800 Message-Id: <20220427004906.129893-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/input/joystick/sensehat-joystick.c:102:2-9: line 102 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/input/joystick/sensehat-joystick.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/joystick/sensehat-joystick.c b/drivers/input/joystick/sensehat-joystick.c index 5ad1fe4ff496..a84df39d3b2f 100644 --- a/drivers/input/joystick/sensehat-joystick.c +++ b/drivers/input/joystick/sensehat-joystick.c @@ -98,10 +98,8 @@ static int sensehat_joystick_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Could not retrieve interrupt request"); + if (irq < 0) return irq; - } error = devm_request_threaded_irq(&pdev->dev, irq, NULL, sensehat_joystick_report, -- 2.20.1.7.g153144c