Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 26 Apr 2022 14:06:41 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Wan Jiabing <wanjiabing@vivo.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        David Howells <dhowells@redhat.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@inria.fr>
Subject: Re: [PATCH] mm/filemap: Fix NULL pointer dereference in
 pagecache_get_page
Message-Id: <20220426140641.cc78a429e1fa32ed0e15520b@linux-foundation.org>
In-Reply-To: <YmfgqKcMmstgfz+0@casper.infradead.org>
References: <20220426082549.590899-1-wanjiabing@vivo.com>
        <YmfgqKcMmstgfz+0@casper.infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 26 Apr 2022 13:08:08 +0100 Matthew Wilcox <willy@infradead.org> wrote:

> On Tue, Apr 26, 2022 at 04:25:48PM +0800, Wan Jiabing wrote:
> > Fix following coccicheck error:
> > mm/folio-compat.c:128:17-21: ERROR: folio is NULL but dereferenced.
> >  	folio = __filemap_get_folio(mapping, index, fgp_flags, gfp);
> > -	if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio))
> > +	if (!folio)
> > +		return NULL;
> > +	if ((fgp_flags & FGP_HEAD) || xa_is_value(folio))
> >  		return &folio->page;
> 
> That doesn't dereference the folio.  Coccicheck is wrong.

Doing

		return &(0->page);

is a rather obscure way of doing `return NULL;'.

I agree the patch doesn't fix anything, but it results in saner-looking code?