Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH v6] media: vimc: get pixformat info from v4l2_format_info
To:     Hans Verkuil <hverkuil@xs4all.nl>,
        "Carlos E. C. Barbosa" <climacobarbosacee@gmail.com>,
        Helen Koike <helen.koike@collabora.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220311111657.56038-1-barbosa.carlos.ec@gmail.com>
 <3665efc7-0b47-1adf-5639-93229af04e95@xs4all.nl>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <07f415c4-addb-73e8-6604-60e7eeb63abf@linuxfoundation.org>
Date:   Tue, 26 Apr 2022 09:34:28 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <3665efc7-0b47-1adf-5639-93229af04e95@xs4all.nl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Carlos,

On 4/26/22 3:02 AM, Hans Verkuil wrote:
> Hi Carlos,
> 
> On 11/03/2022 12:16, Carlos E. C. Barbosa wrote:
>> Removes overlapping structures
>>
>> Repurposes vimc_pix_map to strictly mapping formats, making it
>> a local structure.
>>
>> Replaces all of its functions and remaps the calls to the matching
>> v4l2_format_info.
>>
>> ---
>>
>> Changes in v6:
>> - replace all vimc_pix_map returning functions with v4l2_format_info
>>    ones (as previously suggested by Dafna)
>> - adds is_on_table functions to verify support (to be used only when
>>    no other info is required)
>>
>> Changes in v5:
>> - .bayer member was removed and replaced by v4l2 functions calls
>>
>> Changes in v4:
>> - Unused variables were removed
>>
>> Changes in v3:
>> - Change declaration order of variables and some minor style changes
>>
>> Changes in v2:
>> - Const qualifiers are not removed
>> - Bayer flag is kept
>> - Unnecessary changes are not made anymore
>>
>> v4l2-compliance -m /dev/media0 output:
>> https://pastebin.com/BRjMP3wP
>>
>> Signed-off-by: Carlos E. C. Barbosa <barbosa.carlos.ec@gmail.com>
> 
> Your Signed-off-by should go before the '---'.
> 
> Also, it doesn't match your 'From' email.
> 
> Regards,
> 
> 	Hans
> 
>
Sorry for the delay on this. In addition to Han's comments,
please provide more information in your commit log on the
changes and how they help in more detail. Are these changes
fix any problems you may have found.

thanks,
-- Shuah