Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 26 Apr 2022 23:06:19 +0800
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Ludovic Desroches <ludovic.desroches@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] mmc: atmel-mci: simplify if-if to if-else
Message-ID: <YmgKa4xQ+pOd2xfh@myhostname>
References: <20220424090422.97070-1-wanjiabing@vivo.com>
 <CAPDyKFreW44ou8O4R53XUf7iZTGBBMM+1jmrOeh9cyEOTU-r1Q@mail.gmail.com>
Content-Type: multipart/mixed; boundary="10FwTIgmx2zT3VD7"
Content-Disposition: inline
In-Reply-To: <CAPDyKFreW44ou8O4R53XUf7iZTGBBMM+1jmrOeh9cyEOTU-r1Q@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?92OXtxQ88rJ5hZsZqDP/FnGuj8Tv4SrG5k4hA26IlHs6HEWtXy9u+STbTheH?=
 =?us-ascii?Q?9fuGZEtDeyK27ahYbZHCKdh50/ZVIEfA9zYhit+LqVN8fnHZGxARaW5fVNcw?=
 =?us-ascii?Q?T/yBH6OwrRaFpuncVoALz06JxG005HL8Lne0XRCVYX2cUgf9eiCEGAZiPEvO?=
 =?us-ascii?Q?fgBa4vjOvoNir7sDmTIr1FKLjTdREijTrZkFDbt83nIqQdcf8G8sJUrvRpqC?=
 =?us-ascii?Q?btzS2VZ6LuezCfzfrDikfdf6z1i046MPI3CMhG1KGQzZB4RYtTEDRROKzT/H?=
 =?us-ascii?Q?7FsEt5gXGIUaXBiywIXeSlgulBTCXVXpuf4oWB8A71Ki07TfLrNhc0JZgQu8?=
 =?us-ascii?Q?hiBcmofqzk9lRXqDM27Xw16MwDwSpRlqmZ9wtDLlLFdnNDRz+LYtTRTluIbd?=
 =?us-ascii?Q?jz1zIY4j1SiF+uLRh1GL5jwOwmVc6kfWNxpcNe01gfvj4RprDAxu5CvfDttV?=
 =?us-ascii?Q?zX3DozwZbGPOiLXv1D0TXbxxtifbrOToiLMT8PSljYHBH7EehHOwAZnaJwtw?=
 =?us-ascii?Q?Tf0CP7bSqu59g+ip5akEaip7LeMjBdYXXfcwjiwCnDkUdmEfTNDeY9vg5NbY?=
 =?us-ascii?Q?A4I3SGsOJETTzuDj2sKKhniR4gOW2SdhZAij2ZvpJ8mWFfcWLT33ffxGebbh?=
 =?us-ascii?Q?iPy9QhSdJCjIwwXnUXBVTveBXn8SqxDOUNfHfyPnDOmiCsVvhuwnhHbJpmaP?=
 =?us-ascii?Q?WUa8xycorqBP6ICwKW63iq2/HCnHwcwhZORiCfvBmBOuYVjieez7KLBqAFJI?=
 =?us-ascii?Q?lS6vrCtEVqUnQtoec8BybnalowEiGVF28l+2hZcKj+ihDB5qdtZS2NsW8WRN?=
 =?us-ascii?Q?AQw1ksAkuUvxJg99eLxGiQX9LkTFPfJCFrpDXEHxhBRMtYA6y7h0JAtFQbpC?=
 =?us-ascii?Q?u6/qeOjbhTKL63v0ewwbBtFe7zXtX9rFMHSwqvT064A79JjCCKuBD+e7jMIz?=
 =?us-ascii?Q?WIywK18Q7MTLdWul0seQCS7L4mn84OyI2f7Nq2uO2+oKalsXKyS4bczCZv9/?=
 =?us-ascii?Q?q0ANxHeVfepkUyfUPJUtuaEQ3lRDVlIkOKe2qtqpU0SPujyuKpoa5kuFZE3M?=
 =?us-ascii?Q?jBfebGTOXXvfdsvmQbyRH1ZPYd+XvHYwUuLvKJWZPAy5m+h2ul1dDyJUygkk?=
 =?us-ascii?Q?7CSApt+W98WoNrn40vcbci0zDwcW6kvEnXmd4oDY2GYLGisDF+IDSeVSkaB2?=
 =?us-ascii?Q?6QlKKrquR3cAifEku6mGcpHhktcK+iBRPEnevVA/c8vEYHTwhlqsR7m4NIur?=
 =?us-ascii?Q?6LO/vKgj/FJAM6VZZ0+Xdv3ePXgLijYDYogQQUPoJWJOPg096owf3tfC1byd?=
 =?us-ascii?Q?HirAnHEx90keZYgzWuMbY+TmcthIOJd6sASuAboQdAgdWV5PBtjH9kKg3rWl?=
 =?us-ascii?Q?l9aQOyJ4ez0vRH4ocEWeGjQmHtSXDIEuOJBu0WDYjV+pVHwNkjj0GwXKvahB?=
 =?us-ascii?Q?2whWTBQAO4SNhjIy9o0T+aczLt+kjCtfdpkQs8HIOJ+o8vAr3vC8qACAmrCX?=
 =?us-ascii?Q?aS4M4nYIb8pAoBIMovBwdPNYW54QmRSdyNVqzW0VkarowVR97uFgJT239bAg?=
 =?us-ascii?Q?gIUwxhY3PZLaRxYB2rPK0sze634v22sMOL8x6g7tlHBfdOBSzFftdwCThav0?=
 =?us-ascii?Q?j6DJryfuoP5rEb77LSDWSDivumKcOXeY8JpwrXNmhc/HVtEHQR4kI9bEoLu/?=
 =?us-ascii?Q?Sf6OqA1HsNZyQnxrC8vB6uV96ENfr+oP5qyIlEkIf6u/CKYQUjuvBm+bNo4Y?=
 =?us-ascii?Q?ZMi2lcj8SA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17605721-8aef-4c4a-e581-08da2796542d
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 15:06:24.0499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FPlDhYbe0MDOlvTxtEGBwwqIyhOO2JUoWAIBkKuRaIifS2k0+kWT+YgNxsLoQbFu6RM0rN4UD1DNrY3F2xjSUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB4804
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--10FwTIgmx2zT3VD7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 26, 2022 at 03:53:09PM +0200, Ulf Hansson wrote:
> On Sun, 24 Apr 2022 at 11:04, Wan Jiabing <wanjiabing@vivo.com> wrote:
> >
> > Use if and else instead of if(A) and if (!A).
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> > ---
> >  drivers/mmc/host/atmel-mci.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> > index 807177c953f3..98893ccad4bd 100644
> > --- a/drivers/mmc/host/atmel-mci.c
> > +++ b/drivers/mmc/host/atmel-mci.c
> > @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
> >         chan = host->dma.chan;
> >         if (chan)
> >                 host->data_chan = chan;
> > -
> > -       if (!chan)
> > +       else
> >                 return -ENODEV;
> 
> To make a slightly better improvement of the code, I suggest we add an
> early bail out point in the atmci_prepare_data_dma() function. Like
> below:
> 
> if (!host->dma.chan)
>      return -ENODEV;
> 
> [...]
> 
> Kind regards
> Uffe

OK

How about this new patch?

Thanks,
Wan Jiabing


--10FwTIgmx2zT3VD7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-mmc-atmel-mci-Simplify-if-chan-and-if-chan.patch"

From ce6f779033c9a8aa2489f59c860bb2a49a67c278 Mon Sep 17 00:00:00 2001
From: Wan Jiabing <wanjiabing@vivo.com>
Date: Tue, 26 Apr 2022 23:01:18 +0800
Subject: [PATCH] mmc: atmel-mci: Simplify if(chan) and if(!chan)

Use if(!host->dma.chan) instead of if(chan) and if(!chan) to make
code better.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mmc/host/atmel-mci.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 807177c953f3..91d52ba7a39f 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1122,13 +1122,12 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
 	}
 
 	/* If we don't have a channel, we can't do DMA */
-	chan = host->dma.chan;
-	if (chan)
-		host->data_chan = chan;
-
-	if (!chan)
+	if (!host->dma.chan)
 		return -ENODEV;
 
+	chan = host->dma.chan;
+	host->data_chan = chan;
+
 	if (data->flags & MMC_DATA_READ) {
 		host->dma_conf.direction = slave_dirn = DMA_DEV_TO_MEM;
 		maxburst = atmci_convert_chksize(host,
-- 
2.35.3


--10FwTIgmx2zT3VD7--