Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 27 Apr 2022 10:44:17 +0800
From:   kernel test robot <lkp@intel.com>
To:     Min Li <min.li.xe@renesas.com>, richardcochran@gmail.com,
        lee.jones@linaro.org
Cc:     kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH net 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS
 support
Message-ID: <202204271014.NroTeynI-lkp@intel.com>
References: <1651001574-32457-1-git-send-email-min.li.xe@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651001574-32457-1-git-send-email-min.li.xe@renesas.com>
Precedence: bulk

Hi Min,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Min-Li/ptp-ptp_clockmatrix-Add-PTP_CLK_REQ_EXTTS-support/20220427-033506
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git acb16b395c3f3d7502443e0c799c2b42df645642
config: i386-randconfig-a012-20220425 (https://download.01.org/0day-ci/archive/20220427/202204271014.NroTeynI-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/afadc4edd1bf64b40cb61b38dedf67354baeb147
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Min-Li/ptp-ptp_clockmatrix-Add-PTP_CLK_REQ_EXTTS-support/20220427-033506
        git checkout afadc4edd1bf64b40cb61b38dedf67354baeb147
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/ptp/ptp_clockmatrix.o: in function `idtcm_get_dco_delay':
>> drivers/ptp/ptp_clockmatrix.c:2222: undefined reference to `__udivdi3'
>> ld: drivers/ptp/ptp_clockmatrix.c:2225: undefined reference to `__udivdi3'


vim +2222 drivers/ptp/ptp_clockmatrix.c

  2191	
  2192	/*
  2193	 * Compensate for the PTP DCO input-to-output delay.
  2194	 * This delay is 18 FOD cycles.
  2195	 */
  2196	static u32 idtcm_get_dco_delay(struct idtcm_channel *channel)
  2197	{
  2198		struct idtcm *idtcm = channel->idtcm;
  2199		u8 mbuf[8] = {0};
  2200		u8 nbuf[2] = {0};
  2201		u32 fodFreq;
  2202		int err;
  2203		u64 m;
  2204		u16 n;
  2205	
  2206		err = idtcm_read(idtcm, channel->dpll_ctrl_n,
  2207				 DPLL_CTRL_DPLL_FOD_FREQ, mbuf, 6);
  2208		if (err)
  2209			return 0;
  2210	
  2211		err = idtcm_read(idtcm, channel->dpll_ctrl_n,
  2212				 DPLL_CTRL_DPLL_FOD_FREQ + 6, nbuf, 2);
  2213		if (err)
  2214			return 0;
  2215	
  2216		m = get_unaligned_le64(mbuf);
  2217		n = get_unaligned_le16(nbuf);
  2218	
  2219		if (n == 0)
  2220			n = 1;
  2221	
> 2222		fodFreq = m / n;
  2223	
  2224		if (fodFreq >= 500000000)
> 2225			return 18 * (u64)NSEC_PER_SEC / fodFreq;
  2226	
  2227		return 0;
  2228	}
  2229	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp