Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4446513ioa; Wed, 27 Apr 2022 04:11:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx69dQp94t40gYt+XETe49Iovgf5UPe0/Rze/Ki8V9FIz92ALdm5AucZMVcHiBdq8pCY7dJ X-Received: by 2002:a17:902:d510:b0:15c:ecd2:e7fc with SMTP id b16-20020a170902d51000b0015cecd2e7fcmr20901535plg.132.1651057861026; Wed, 27 Apr 2022 04:11:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651057861; cv=none; d=google.com; s=arc-20160816; b=ckGdt/wepVY2cjne8QHP4InVgdAd/HHaNpU6HXVz5swJoYtYQ+rlQHjN8yjyt6GXlT 0puoO2sShRir725XjMmdFNci14CshJGXC+ReBPgKq6ecNXc/AX6eawuAosqLI0HnTrBb PTusEYCMU0yZfdI97yV+1iZ943Lfl+veZ/nbKHgqA8rpy4M2Q27E71g4f+IsU4o3UISu k+vqICH23vkI6x4WzMJEXa4gPiSb9MWHCrib7UxvCxQ+qr7NFafx/Qyx28XIcMFPfTVL iPBEnIKlSZ18oXCsAw14Wnm1+nrcmX0XwLJlPVxwLyyT5nrRFKJ2CH3ZtQVRwA9L0Isx EGvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=+rzanixEDr3hZJaBzsTiSEyUsFzeLAiZBAmW4yYyL+M=; b=hKn1A97YijFp3M3Jc1jFeWT0s4BQcA8WgX/l05EF3i1ziQSZfOP7ZKc9AZ5S3/TR0C u/qtFP8pyLmw+i6Wi161TCJ/1A4noIfNqKlAX4MaqlCZDQEkM18nCBBU6PmFuYcGHMuG ss5xokR7D02ukqaBWPzlcv/LLOqNdbDI3qG/bPxvlbSDnHEaMnSdCRJ/X9QucB22sPvn UdYsSAsLOCDsM5A3qwNqdPD9PhBBCok1oaSzvYOaCcroNDT+/HwBdmi/dYwINm6g+ttK 1pR+zsr/YgZPLck8ywWr6m95BD1Td5Sxn3db0tSLlTwYUUtYraeLKdDFIoLaJ8WbaTDM dKHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AsCel1eB; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b8-20020a056a000cc800b0050a8e9acae6si1203568pfv.102.2022.04.27.04.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:11:01 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AsCel1eB; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 937D13EA88A; Wed, 27 Apr 2022 03:04:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355994AbiDZXOP (ORCPT + 99 others); Tue, 26 Apr 2022 19:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbiDZXON (ORCPT ); Tue, 26 Apr 2022 19:14:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 013D15F4E for ; Tue, 26 Apr 2022 16:11:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F709B823EF for ; Tue, 26 Apr 2022 23:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49A8FC385AC; Tue, 26 Apr 2022 23:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651014661; bh=sqQfYjjF/r86CeFsB63WxaaPTzmwp2vYEsl7OATmzNQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=AsCel1eBnB72AQnTInD6rZXEgUskgLbFriBxFq7lhRjUiS0uhTSd0ySHV569l7uz7 NKh4+8BLI14VKNIzdgObSUKJH84dEubCGXiEe0lVxK9Wt+Re9LaCHbvNvUlFDnQu3d A2dRMQAKR0irtjQ+dpHJl7IB62L7/hxqtwbCLNOj5B3ncar4JCsj+N/gq/4N9jXj0u jK7+HbJnU4AOM91fLG4YyQzjGosmrTKtSeZGrBEJlFYe61P1KEKrX6viN/UoNeH3TP qCFxmNePlsod0GQ0igPdAvJEhohoy0v28H80CVI0p+Qw6p2e7xgIZA8G+UOwDayQqG vDwQd1EGabydg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E92785C0530; Tue, 26 Apr 2022 16:11:00 -0700 (PDT) Date: Tue, 26 Apr 2022 16:11:00 -0700 From: "Paul E. McKenney" To: Christoph Bartoschek Cc: Chris Mason , Giuseppe Scrivano , linux-kernel@vger.kernel.org, "riel@surriel.com" , "viro@zeniv.linux.org.uk" Subject: Re: [PATCH RFC fs/namespace] Make kern_unmount() use synchronize_rcu_expedited() Message-ID: <20220426231100.GL4285@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <8E281DF1-248F-4861-A3C0-2573A5EFEE61@fb.com> <20220426065917.3123488-1-bartoschek@google.com> <20220426140919.GD4285@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 12:58:34AM +0200, Christoph Bartoschek wrote: > > 3. https://lore.kernel.org/lkml/20220218183114.2867528-1-riel@surriel.com/ > > Refined queue_rcu_work() approach. > > > > #1 should work, but the resulting IPIs are not going to make the real-time > > guys happy. #2 and #3 have been subject to reasonably heavy testing > > and did fix a very similar issue to the one that you are reporting, > > but last I knew there were doubts about the concurrency consequences. > > > > Could you please give at least #3 a shot and see if it helps you? > > I have tried #3 and it works well with my testcases as far as I can see it. Thank you for giving it a try! Al, are further adjustments needed to make this patch cover all the corner cases? Thanx, Paul