Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4447217ioa; Wed, 27 Apr 2022 04:11:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoawzhPF2kyfhbk+iv/UfygbZiF4udbEFYj0GjtOuW10hA3l1oUDanHQJSvAr4Ic2gwbtU X-Received: by 2002:a17:90b:224b:b0:1d9:a277:c076 with SMTP id hk11-20020a17090b224b00b001d9a277c076mr11523439pjb.134.1651057906070; Wed, 27 Apr 2022 04:11:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651057906; cv=none; d=google.com; s=arc-20160816; b=Sf5ERjkOA3nNBoLB8jTeGYsstwmSj76dhB+5BJkxlr9EiLl+XmVbdfZaab252rHPYO 3buFSOaLjFJUqCQmby0rSSSBs1XOapBBRvjStiYTHDwlhDLZPJ9Rl4xXyLhEgNrDtyhi 4Um520homdZTdokCZVLs+Mu1P7zWjfHTjS2QfTuP1lqnRQwCXZsYnm6B5k4ZKUSFYDXD 1BaZPpJbMtnv9EFEp9A2udnRkCbDDRG2/Lc6OVS7F6Yhi7n7cTD8u0FuRWkaT5JUvxRh ODrmSFXXJVcgqWTgFx2TjZdhJ+Zfb293oqg0YajS5hpKPSqNro9pKguc6IkUNUqE68xy wW5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ja/P7HufblxMyYSgMyziBQoxmRiotAcYG58mo0y4N3w=; b=nf390xZVWaOVctdZwFtUYltp7V+Ve9JF/v847hDmBLv2kiTwJmNg/x7ekY09KZSTEV UeAQyO8pSjaB1T1aIIR+k/Y9ihVA1ts5o02hYA5Dsq0WUxwP7pyLgikDo8Cw7LPssiU6 PbsX3Yy274kPami4V4lrzDDQTsgCB4why01Ls2291dsYjTE1EgSs4ei7p14yNAdMN6dE RL5LvZb/SbOLI2nNgDPRMQXto4n/cFPqIBSKYfhTYuCacOMXAlRCff6Wtsa/Ltl/ot2u BsE9KfdAIhOhBlzWXCbAi4LXiFDnoLue/FcZ6SSKb5quEQZ9mqy3whMsMzCGwUh/KjSQ FYIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2IvDGzM7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i16-20020a170902c95000b0015872db9713si1533232pla.131.2022.04.27.04.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:11:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2IvDGzM7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3B1F1431A09; Wed, 27 Apr 2022 03:05:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349229AbiDZKiK (ORCPT + 99 others); Tue, 26 Apr 2022 06:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349175AbiDZKhY (ORCPT ); Tue, 26 Apr 2022 06:37:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F1F93B7; Tue, 26 Apr 2022 03:21:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DEDEC615AB; Tue, 26 Apr 2022 10:20:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D23B3C385A0; Tue, 26 Apr 2022 10:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650968459; bh=upRt5cWmk45sKqQhG085JLpi7qzRTD4ZA5fWWha7b9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2IvDGzM7d6NMwW8m92qobOdm0KxYklDlSURqj6xlGZ0Lip7LGAnU2Fpks5QkSrft4 sASZeINeZGJUxM4cpu/oZrFdKN0962p2fvAgOqkUzmgArFQNca0JSbPF7qTKRuQR6a eKgsPIxgjxGnv46EGxVygB2m+AiB2KNXn5o0unmQ= Date: Tue, 26 Apr 2022 12:20:56 +0200 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Mathias Nyman , "open list:USB XHCI DRIVER" , open list , Howard Yen , Jack Pham , Puma Hsu , "J . Avila" , sc.suh@samsung.com, Krzysztof Kozlowski Subject: Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver Message-ID: References: <1650964728-175347-1-git-send-email-dh10.jung@samsung.com> <1650964728-175347-6-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650964728-175347-6-git-send-email-dh10.jung@samsung.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 06:18:48PM +0900, Daehwan Jung wrote: > This driver is for Samsung Exynos xhci host conroller. It uses xhci-plat > driver mainly and extends some functions by xhci hooks and overrides. > > It supports USB Audio offload with Co-processor. It only cares DCBAA, > Device Context, Transfer Ring, Event Ring, and ERST. They are allocated > on specific address with xhci hooks. Co-processor could use them directly > without xhci driver after then. > > Signed-off-by: Daehwan Jung > --- > drivers/usb/host/Kconfig | 8 + > drivers/usb/host/Makefile | 1 + > drivers/usb/host/xhci-exynos.c | 567 +++++++++++++++++++++++++++++++++ > drivers/usb/host/xhci-exynos.h | 50 +++ Why do you need a .h file for a simple single driver like this? Just put it all into the .c file please. thanks, greg k-h