Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <47accf18-ca39-8b36-100e-a6dbfd8705fe@kernel.org>
Date:   Tue, 26 Apr 2022 09:29:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] tty/hvc_opal: simplify if-if to if-else
Content-Language: en-US
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
References: <20220426071041.168282-1-wanjiabing@vivo.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220426071041.168282-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26. 04. 22, 9:10, Wan Jiabing wrote:
> Use if and else instead of if(A) and if (!A).

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Change log:
> v2:
> - add braces to the if block.
> ---
>   drivers/tty/hvc/hvc_opal.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 84776bc641e6..794c7b18aa06 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -342,9 +342,9 @@ void __init hvc_opal_init_early(void)
>   		 * path, so we hard wire it
>   		 */
>   		opal = of_find_node_by_path("/ibm,opal/consoles");
> -		if (opal)
> +		if (opal) {
>   			pr_devel("hvc_opal: Found consoles in new location\n");
> -		if (!opal) {
> +		} else {
>   			opal = of_find_node_by_path("/ibm,opal");
>   			if (opal)
>   				pr_devel("hvc_opal: "


-- 
js
suse labs