Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4447500ioa; Wed, 27 Apr 2022 04:12:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxL/3jJX2jKJPXLFdC5dadbsLwyRAGbyaLjfprELgQYd1Vdws/lDA2euWu04SYlamqeTj4J X-Received: by 2002:a05:6a00:849:b0:50d:4069:60b with SMTP id q9-20020a056a00084900b0050d4069060bmr15174917pfk.76.1651057928517; Wed, 27 Apr 2022 04:12:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651057928; cv=none; d=google.com; s=arc-20160816; b=H71FfV8Ylq83QcMTJdKEA6HAAFbXEYBkV5ej1y/5AfoA/rFNYO/0JPuG+4drox9xVB s2ogWX0nrY3kjq2LGZl/TCTg5E8U9TKwjkqHITazJRc/zwt/85C5tvtIt8SdXUJWrL67 ZBvm1tJBTBE6Bb0ik5Ypq0CZ7ylnC7f9DlZMtZBru8I7CU/xy6V1kVcDCO5to67HpAxl Ke8UHqYkizOypSuhlRQmu0XZTKK8bpXxWHJH4+TtzN1+xR+WgFT3twGIZxjuNC0D/eUf 4mm8cfuN/KTviNaxzoLRzoLBiejM+EBqXLjqRKfcfcgFmb47Patgp8rPYAnT7Z7aQ1pv kYxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XRsu/ussswt/LIrflZJyacP4e2z+gM39yV+1fzyWCuw=; b=v1O2omAZk8OGBoq0kY73Fl2bALfRGlz5sHmA9KsbS9lTMH+GZcv1Ql7FMUWORuQzcE AXjGS9hyxLcMI1EjjRGjaHeHLicfwhKZGJozWt3kFQGeYZ/gVqMSv5Z6vD7VKIBhETt8 IMxjlT8gPu9PbGauPGRPcP1TJpRrMrXYO7HCGvvEk1saA6pcnr8Fsb/b8qwPDc0ZfmV3 FjeP4psKXZElRIbw2vHW3IYjWK1w921hF0QhGbW7Xz9A6gztP9Nrl3iLs6lGrXKib3Ao fmj7wZIdjM6KJIFRZHPubKNvL2mxN0OLx3fK6Di8l4T8KTFL4oM/Mh7yiIGiZWO4Ffzu U9fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XLPvEl+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id w24-20020a170902a71800b0015cbb6e943fsi1255547plq.299.2022.04.27.04.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XLPvEl+k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7DE0C2F64CA; Wed, 27 Apr 2022 03:05:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351619AbiDZSEi (ORCPT + 99 others); Tue, 26 Apr 2022 14:04:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351468AbiDZSEf (ORCPT ); Tue, 26 Apr 2022 14:04:35 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D326927B18 for ; Tue, 26 Apr 2022 11:01:26 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id y38so2920023pfa.6 for ; Tue, 26 Apr 2022 11:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XRsu/ussswt/LIrflZJyacP4e2z+gM39yV+1fzyWCuw=; b=XLPvEl+krom+vUGXLLaM9U5FMvMXJDtCpmsgMIMmsaMdInWzeTqMzVZIuAysv57Ob+ 4X5WXx9T58lNI5xuusGfrtE38Ta1uE2xmgiTdklo/jLzQ8BLnvsyWxZ3lcudjHrGsSIC 937A84Dat2VCWHdClpkuzhwjGY51zChKfOIig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XRsu/ussswt/LIrflZJyacP4e2z+gM39yV+1fzyWCuw=; b=Re+LC8nQsebzgmSZA70u5aeZr0SrRNdlMYj1LLgs+egSNWME88owEHQdWKwKNEWQ71 FeF4EcRLw7WGd0GAZnQXBYALJuMoCwiNC1oJ9vVeern862s2B7o/numlRzu/EW3j+/fZ F1Hq4eYTULklOLWZ+XztYDdyLZsMhmVvd+ulgolJGcTu7aSvOIgbwcx3nA3YaB+wtn1/ TNry60jp59gRjPRFteqQDHNRhn/TGWwsgiSwo1WhXzFxjGezHDp6fgnuaEhiHL1Xmf6I u6r21NzHypZD3qYDHFvwyycqFiCWg7USFMx6fmb2uxxXnJtmzx7Sxlk97EiJ6/CLRHhw 5c2g== X-Gm-Message-State: AOAM533RzWMsZZgJPtXLK6yikQmyO01YCUBrM+NvAHJpXdrqtwQns36L XlmNXa0Ozcn/f5xkwOjO4IzXVg== X-Received: by 2002:a05:6a02:10d:b0:381:f4c8:ad26 with SMTP id bg13-20020a056a02010d00b00381f4c8ad26mr20497541pgb.135.1650996085751; Tue, 26 Apr 2022 11:01:25 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y2-20020a17090a784200b001cd4989ff42sm3408312pjl.9.2022.04.26.11.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:01:25 -0700 (PDT) Date: Tue, 26 Apr 2022 11:01:24 -0700 From: Kees Cook To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, alex.popov@linux.com, catalin.marinas@arm.com, luto@kernel.org, will@kernel.org Subject: Re: [PATCH 0/8] stackleak: fixes and rework Message-ID: <202204261101.D3DC3333@keescook> References: <20220425115603.781311-1-mark.rutland@arm.com> <202204251551.0CFE01DF4@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 05:01:27PM +0100, Mark Rutland wrote: > On Mon, Apr 25, 2022 at 03:54:00PM -0700, Kees Cook wrote: > > On Mon, Apr 25, 2022 at 12:55:55PM +0100, Mark Rutland wrote: > > > This series reworks the stackleak code. The first patch fixes some > > > latent issues on arm64, and the subsequent patches improve the code to > > > improve clarity and permit better code generation. > > > > This looks nice; thanks! I'll put this through build testing and get it > > applied shortly... > > FWIW, looking at testing I've spotted a fencepost error, so I'll spin a > v2 with that fixed (and with updates to the LKDTM test). Ah! Oops, ok, I'll unpush the series, I missed this. :) -- Kees Cook