Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 27 Apr 2022 10:13:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: net/dsa/tag_sja1105.c:432 sja1105_rcv() error: uninitialized symbol
 'vid'.
Message-ID: <202204270649.Eun9P40C-lkp@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2V2WGV1MHZNSGgxWVdoQWgrbzhCUzdkem9FM2d4RTdKYi9ZRHJ5KzJ1Y25Z?=
 =?utf-8?B?Y293TUN3TFZBbUVjMERmdjc4REVNaXlIaFRjSk50ZzhVcUNBc0gzYmN2U1Zl?=
 =?utf-8?B?Y1JxeElKenJyL2tuSTJKT2M5eUFRWkRNT1MxN1lPZklEMElReXp1MzM3UVpY?=
 =?utf-8?B?eTBOTVYxQnUvczJQNmMxa1R0YTd4bURSM3R5VHhjTmY3VGc5Z1dHUnd2dUMw?=
 =?utf-8?B?VUdvRVlCTmdFZG02ZjM4ODdCZkhpcXB2SHRoRjJMUk42ZTVOZWlWN1QwWFdu?=
 =?utf-8?B?b013VnErTDJDVE8rMVAvcnIvcVBDUGgreUlLVWg3b01EWHIwMW5hMldHdU9w?=
 =?utf-8?B?Uzh1UitwSS9tMTVjQXJNWWl3TlJlNDY2dXkyZ1ZDVlB6dzV6UVdVbnNoY2hO?=
 =?utf-8?B?c05QdjU0VWF3ejlSSzVaamxleXlMZ2F3S01UWWhwSU9jQUVFbTFWNWhzcTVq?=
 =?utf-8?B?eXY0cnNtbGg3eDJwUm51bC9TTmNKVDJPQ3hpUDRnUC9uSkR4UHduN2dNNHFJ?=
 =?utf-8?B?eUdpdG4wek84NmlmNlpIM3hJN05qbVpNd2FDMGFST1NwdlQ2bjI4azI4M1Q5?=
 =?utf-8?B?WCtiMDR5RWFRMXpyYjFkVkFrZU9kQ2lVT3VxVGlUejZZaHFBbGhnVUxHVGtF?=
 =?utf-8?B?ckhtTjR0Z3NkMG4yVE1JVHloU2NaYnQxazltR2k5cmJqTThKRGwrVFNoakJO?=
 =?utf-8?B?SmJpalBRVmRQNzFMSUJLaXlEQ1hwTlpFSGNOc0t6Um1IZHlaOTBJaEluT2hn?=
 =?utf-8?B?eFpzUjlESURYS24zQk5TdnBOaDlpNkZTcnFTdkZSYVhJc0ZZNnlXNnZsVE1z?=
 =?utf-8?B?VFU2OVdvVHJ5aDMrMzh3NUVmSkhqRVljM01TdzI4QktNZURTT2pmQURpRllk?=
 =?utf-8?B?dGYxa1VETTYydDZmKytndUxjS2ZGQm84L242WWI5SVc2eFMrTVpBdVdJNEpJ?=
 =?utf-8?B?dVlPSGc2MFd6WW9vUHFxY2xNYitkSElnS29YUUNKOGlsNGdQT1NLYjRFb2p3?=
 =?utf-8?B?dUd3NnI0WUl1andiTTRzUW5EY3diQnFvclA1dkpOeTBmcFlMU1ZKVmQ0WHdW?=
 =?utf-8?B?RnZBcGhQMDBvVVNUd3ZYMkpyN1lhVUE0alFUbnBvZE1vSTFSU1crbFdzckZo?=
 =?utf-8?B?N0NzWWNGVGZ1ZHN3QUp3TlFzbWFUaEJ4cGdEM3B3OTFaaXlHbFUzc1NCOXdP?=
 =?utf-8?B?ZEJvdWxBWGNMUEt4QXRxMmJvaWV3WWlTczVWWHMvbUxtUEwzZnRDZkJwVkhx?=
 =?utf-8?B?SFRuRWJhQXFQRXFtRER2MWNOS3NFOHdGUnFiRWhhU1ZSU1czUTZtZ1F0aDAy?=
 =?utf-8?B?eGs4QlN1ZjVIOXE1Vysxcld5eVQ0ME5XS0JzcWRxMjhYZExMb3dhRGNHeENj?=
 =?utf-8?B?NzVtYitWWTBWRUhiWnByMmRIeC9uVEJXOGRGS0IyUmswTThqSmM4dldDNkhI?=
 =?utf-8?B?b3ZSQ21scDduY0MrNGE1S0x4b0NaTStNWlZmWnlVS21kNFVPL2ZnWXNneWVM?=
 =?utf-8?B?dGZQcHJaMWN1Qyt1dnNxQmFPSnhjWkRjRmwxSUluZU5yMFZYUDRtbUMxaU8z?=
 =?utf-8?B?ejJJWnA3emh4MGVxUFl2ZkZqT3ArbW0zNFdweU5URXpTaXhXbGltN2hFSmNH?=
 =?utf-8?B?cWpMNE9Pa2Q4U0hHRUErWnNzUGNmeHZiZm1hcmhkM2Z3d2NkQnl2T09tQXkw?=
 =?utf-8?B?djhTRW9UUThrVkJTVStFbjA5SDFtN3JxYVdRSEFoTWNKZXUwQkpGMGh6VmR3?=
 =?utf-8?B?ZkVOdi9ERDExZzFvemFOMXBWYjA2MWY0NUxqWnVEaWJKZGRPV2dhRE5nc3Z5?=
 =?utf-8?B?TVdray9LQ2l4N0VRVzBoVnRIdUNpTXlzVWlJYS9KRi9NQkovTFI0bFg2WDVX?=
 =?utf-8?B?LzQ2eXRGWVRSbGExc25vSndhcTB5RWdvMjUvVzY2T1NvaGxYMHVEKzBscis2?=
 =?utf-8?B?YklTajlNNFozV1VieWV2SjV0ZTVZN243VzNvV1UrYzRTRzNjdlRKcjR1eFlz?=
 =?utf-8?B?MmlqWVoxaHlmK2lZaStoYzFTWGVpaUFyL1g3b0h3QkRtTVc0UURIUk54REZ0?=
 =?utf-8?B?TjNMQW4zQitKbVFoUEtIUnVyUzV2aTlQeXpkNzYxbnNiMkhGaDZpYmtLNHFP?=
 =?utf-8?B?QXB6ZUYxdGFpdlVhQVNnNldaaXBWejhwdFd4UjcxeXlzY3cvcHdwdURwZW5K?=
 =?utf-8?B?NFAzTDMzWldDRTd2NUNRQWpKNEtYbGRiVnVWNkhjK0NnL21lbU1zR0N1M0h3?=
 =?utf-8?B?cHRmb1dvL09nNkdaTE1Cc1drOXlUZTY1VzBqOFNHYWtiQnNnd2x6YS8rcUdj?=
 =?utf-8?B?SXA5cmRJY3dyeWt3dmJka3d2REhEZHJOOFVob21QWEFIb01RZVluRjl5MkZ1?=
 =?utf-8?Q?cbTWnjjoC77V/Whc=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4fcb997-b121-45a3-ffeb-08da281d7afe
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 07:13:51.3259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bG8LTPy7wiTpbTssrmtgAJ7v16I1DMo1hCtpoRbaZX0dVzKCEPEsA3lOw2GCfLB2qv9uhaXWJplxF51gojuOrDvXBqdIh7rt6pYdiZWi93o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1435
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-27_02:2022-04-26,2022-04-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204270048
X-Proofpoint-ORIG-GUID: Aalkh4td4_sm5hXHfTeSmPRpXKUXWboC
X-Proofpoint-GUID: Aalkh4td4_sm5hXHfTeSmPRpXKUXWboC
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cf424ef014ac30b0da27125dd1fbdf10b0d3a520
commit: 04a1758348a87eb73b8a4554d0c227831e2bb33e net: dsa: tag_sja1105: fix control packets on SJA1110 being received on an imprecise port
config: openrisc-randconfig-m031-20220425 (https://download.01.org/0day-ci/archive/20220427/202204270649.Eun9P40C-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/dsa/tag_sja1105.c:432 sja1105_rcv() error: uninitialized symbol 'vid'.

Old smatch warnings:
net/dsa/tag_sja1105.c:564 sja1110_rcv() error: uninitialized symbol 'vid'.

vim +/vid +432 net/dsa/tag_sja1105.c

227d07a07ef1262 Vladimir Oltean 2019-05-05  393  static struct sk_buff *sja1105_rcv(struct sk_buff *skb,
227d07a07ef1262 Vladimir Oltean 2019-05-05  394  				   struct net_device *netdev,
227d07a07ef1262 Vladimir Oltean 2019-05-05  395  				   struct packet_type *pt)
227d07a07ef1262 Vladimir Oltean 2019-05-05  396  {
884be12f85666c6 Vladimir Oltean 2021-07-26  397  	int source_port = -1, switch_id = -1;
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  398  	struct sja1105_meta meta = {0};
e80f40cbe4dd513 Vladimir Oltean 2020-03-24  399  	struct ethhdr *hdr;
42824463d38d273 Vladimir Oltean 2019-06-08  400  	bool is_link_local;
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  401  	bool is_meta;
884be12f85666c6 Vladimir Oltean 2021-07-26  402  	u16 vid;
227d07a07ef1262 Vladimir Oltean 2019-05-05  403  
e80f40cbe4dd513 Vladimir Oltean 2020-03-24  404  	hdr = eth_hdr(skb);
42824463d38d273 Vladimir Oltean 2019-06-08  405  	is_link_local = sja1105_is_link_local(skb);
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  406  	is_meta = sja1105_is_meta_frame(skb);
227d07a07ef1262 Vladimir Oltean 2019-05-05  407  
227d07a07ef1262 Vladimir Oltean 2019-05-05  408  	skb->offload_fwd_mark = 1;
227d07a07ef1262 Vladimir Oltean 2019-05-05  409  
233697b3b3f60b1 Vladimir Oltean 2021-06-11  410  	if (sja1105_skb_has_tag_8021q(skb)) {
42824463d38d273 Vladimir Oltean 2019-06-08  411  		/* Normal traffic path. */
04a1758348a87eb Vladimir Oltean 2021-07-29  412  		sja1105_vlan_rcv(skb, &source_port, &switch_id, &vid);

There is a return where *vid is not set

42824463d38d273 Vladimir Oltean 2019-06-08  413  	} else if (is_link_local) {
227d07a07ef1262 Vladimir Oltean 2019-05-05  414  		/* Management traffic path. Switch embeds the switch ID and
227d07a07ef1262 Vladimir Oltean 2019-05-05  415  		 * port ID into bytes of the destination MAC, courtesy of
227d07a07ef1262 Vladimir Oltean 2019-05-05  416  		 * the incl_srcpt options.
227d07a07ef1262 Vladimir Oltean 2019-05-05  417  		 */
227d07a07ef1262 Vladimir Oltean 2019-05-05  418  		source_port = hdr->h_dest[3];
227d07a07ef1262 Vladimir Oltean 2019-05-05  419  		switch_id = hdr->h_dest[4];
227d07a07ef1262 Vladimir Oltean 2019-05-05  420  		/* Clear the DMAC bytes that were mangled by the switch */
227d07a07ef1262 Vladimir Oltean 2019-05-05  421  		hdr->h_dest[3] = 0;
227d07a07ef1262 Vladimir Oltean 2019-05-05  422  		hdr->h_dest[4] = 0;

Not set here

e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  423  	} else if (is_meta) {
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  424  		sja1105_meta_unpack(skb, &meta);
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  425  		source_port = meta.source_port;
e53e18a6fe4d3ae Vladimir Oltean 2019-06-08  426  		switch_id = meta.switch_id;

Or here

227d07a07ef1262 Vladimir Oltean 2019-05-05  427  	} else {
42824463d38d273 Vladimir Oltean 2019-06-08  428  		return NULL;
227d07a07ef1262 Vladimir Oltean 2019-05-05  429  	}
227d07a07ef1262 Vladimir Oltean 2019-05-05  430  
04a1758348a87eb Vladimir Oltean 2021-07-29  431  	if (source_port == -1 || switch_id == -1)
884be12f85666c6 Vladimir Oltean 2021-07-26 @432  		skb->dev = dsa_find_designated_bridge_port_by_vid(netdev, vid);
                                                                                                                          ^^^
So the static checker complains

GCC would also complain if we enabled -Wmaybe-uninitialized

net/dsa/tag_sja1105.c: In function ‘sja1105_rcv’:
net/dsa/tag_sja1105.c:567:28: warning: ‘vid’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  567 |                 skb->dev = dsa_find_designated_bridge_port_by_vid(netdev, vid);
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

884be12f85666c6 Vladimir Oltean 2021-07-26  433  	else
227d07a07ef1262 Vladimir Oltean 2019-05-05  434  		skb->dev = dsa_master_find_slave(netdev, switch_id, source_port);
227d07a07ef1262 Vladimir Oltean 2019-05-05  435  	if (!skb->dev) {
227d07a07ef1262 Vladimir Oltean 2019-05-05  436  		netdev_warn(netdev, "Couldn't decode source port\n");
227d07a07ef1262 Vladimir Oltean 2019-05-05  437  		return NULL;
227d07a07ef1262 Vladimir Oltean 2019-05-05  438  	}
227d07a07ef1262 Vladimir Oltean 2019-05-05  439  
f3097be21bf17ae Vladimir Oltean 2019-06-08  440  	return sja1105_rcv_meta_state_machine(skb, &meta, is_link_local,
f3097be21bf17ae Vladimir Oltean 2019-06-08  441  					      is_meta);
227d07a07ef1262 Vladimir Oltean 2019-05-05  442  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp