Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH 3/5] selftests: firmware: Fix the
 request_firmware_into_buf() test for XZ format
To:     Takashi Iwai <tiwai@suse.de>, Luis Chamberlain <mcgrof@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Nick Terrell <terrelln@fb.com>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220421152908.4718-1-tiwai@suse.de>
 <20220421152908.4718-4-tiwai@suse.de>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <da541a1d-8d09-7eb1-fa12-9416d1da3366@linuxfoundation.org>
Date:   Mon, 25 Apr 2022 13:45:47 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220421152908.4718-4-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/21/22 9:29 AM, Takashi Iwai wrote:
> The test uses a different firmware name, and we forgot to adapt for
> the XZ compressed file tests.
> 
> Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests")
> https://lore.kernel.org/all/20210127154939.13288-1-tiwai@suse.de/
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   tools/testing/selftests/firmware/fw_filesystem.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> index 731f011def78..3ac09b401a83 100755
> --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> @@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0
>   
>   # test with both files present
>   $RUN_XZ -k $FW
> +$RUN_XZ -k $FW_INTO_BUF
>   config_set_name $NAME
>   echo
>   echo "Testing with both plain and xz files present..."
> @@ -529,6 +530,7 @@ done
>   
>   # test with only xz file present
>   mv "$FW" "${FW}-orig"
> +mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig"
>   echo
>   echo "Testing with only xz file present..."
>   for i in $(seq 1 5); do
> 

Thank you. Looks good to me.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah