Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4451581ioa; Wed, 27 Apr 2022 04:17:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2X2Xfew1V+xYWgsTag/YSxZOgyOCOPk7Bd3iSRA/u9iyYyRhGFTwsswXVzJsTLcCtiwQ/ X-Received: by 2002:a63:7414:0:b0:39d:adec:1764 with SMTP id p20-20020a637414000000b0039dadec1764mr10549903pgc.113.1651058247246; Wed, 27 Apr 2022 04:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651058247; cv=none; d=google.com; s=arc-20160816; b=gZ0F+J/2+p5XuHpwkV+bMI1eRY2OgD5U+08MZs/7oW2pVIX3PuFoer2F8qo724Ijti NeCk3r8W/jlEWEi69prMF7/mHvXvN6isyqWIvkrEEwKTJsycjSPgIfquTJEM5ra9yhuM YYkf8RZVkj0gK4zP6GvdJiVDy96ImDUNQewAFmMqsN/WfsBGEZBMXXivkdCCHHnUEsNf yBuEPlpCk7FADzoDSBgqsqnBkuNRQPtPYbJM1e6Cg7Jo9JAPo6z86eeciWY5X1trkCIO O2IvFw8wzlJNfXxNt14W3GOmKrFcaoiVSHV937GZxX6C3jyVRiWm5LbZ2E34zcG9U62a gDkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=m1+l/UGo7OHrjM3HAPBBJI03KFTiilbKvsV44XOQqzw=; b=cb6BnJbp2gOwz3jByornQ8CIQevsFn0HjHAymHxtIn+rVv77/DFGHPi/ecWQGJ3IuL mhJQtjUefl0RIxC//oM45wnde44KCS6bXDlZrQeDZHEMrPa2GHswuH4hcMuZvlrCTNU0 hpO3KZn6Kspjg6kjzLboEH+LIPkXHvg37Y+FLcC08bU+mJL2B2Sxr52U0TVk6D9Etq33 F91LDljBqZWgDL8tCAEhmkXPwjuAMGpbbGd7n5jg9UEU24RH+FdGn7vgWg41nPKdtVzb Wwaqto2dixqF3YLpaLd94EXNSjY454FSCctJeJQ6qB598lMn2+s/RLxpRmIxp1Dk0bl+ 1tPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lrvden76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t17-20020a17090340d100b0015d325df192si1286859pld.277.2022.04.27.04.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lrvden76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 06A8559975; Wed, 27 Apr 2022 03:10:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351782AbiDZO6G (ORCPT + 99 others); Tue, 26 Apr 2022 10:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241776AbiDZO6F (ORCPT ); Tue, 26 Apr 2022 10:58:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A362E64BC0 for ; Tue, 26 Apr 2022 07:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650984896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=m1+l/UGo7OHrjM3HAPBBJI03KFTiilbKvsV44XOQqzw=; b=Lrvden761pPoBIctdhkbVJnOBojvQ+3dhZs2nQuLuJnC06DyXEK5C5Q8z2w5HumGw8PHu6 9o0oM/ExkPnLqXURdENwm+6TFcSutTg5mxOWLhmPWeYk6bWR9Ue3ZrgqiGr8+y1KiYVAAA Ucj7d4M8TaOFkJMUnxvfxTL1HfKxXpU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-T44Ke54uMte1libj1AoAjQ-1; Tue, 26 Apr 2022 10:54:49 -0400 X-MC-Unique: T44Ke54uMte1libj1AoAjQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06C7E80D2A3; Tue, 26 Apr 2022 14:54:48 +0000 (UTC) Received: from max.localdomain (unknown [10.40.194.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2126E14682C8; Tue, 26 Apr 2022 14:54:45 +0000 (UTC) From: Andreas Gruenbacher To: Linus Torvalds Cc: Andreas Gruenbacher , cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: [GIT PULL] gfs2 fix Date: Tue, 26 Apr 2022 16:54:45 +0200 Message-Id: <20220426145445.2282274-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, please consider pulling the following gfs2 fix for 5.18-rc5. Also, note that we're fighting with a rare case of data corruption that seems to have been introduced by commit 00bfe02f4796 ("gfs2: Fix mmap + page fault deadlocks for buffered I/O"; merged in v5.16). The corruption seems to occur in gfs2_file_buffered_write() when fault_in_iov_iter_readable() is involved. We do end up with data that's written at an offset, as if after a fault-in, the position in the iocb got out of sync with the position in the iov_iter. The user buffer the iov_iter points at isn't page aligned, so the corruption also isn't page aligned. The code all seems correct and we couldn't figure out what's going on so far. Thanks, Andreas The following changes since commit af2d861d4cd2a4da5137f795ee3509e6f944a25b: Linux 5.18-rc4 (2022-04-24 14:51:22 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc4-fix for you to fetch changes up to e57f9af73d6b0ffb5f1aeaf6cec9a751dd8535c9: gfs2: Don't re-check for write past EOF unnecessarily (2022-04-26 15:38:00 +0200) ---------------------------------------------------------------- gfs2 fix - Only re-check for direct I/O writes past the end of the file after re-acquiring the inode glock. ---------------------------------------------------------------- Andreas Gruenbacher (1): gfs2: Don't re-check for write past EOF unnecessarily fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)