Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220425095742-mutt-send-email-mst@kernel.org>
 <20220426042911.544477f9.pasic@linux.ibm.com> <20220425233434-mutt-send-email-mst@kernel.org>
 <20220425233604-mutt-send-email-mst@kernel.org> <ba0c3977-c471-3275-2327-c5910cdd506a@redhat.com>
 <20220425235134-mutt-send-email-mst@kernel.org> <20220425235415-mutt-send-email-mst@kernel.org>
 <CACGkMEve+3ugK-Kgao3_2wbjb=fbF7AO2uEuArGjKgEAQcGdiQ@mail.gmail.com>
 <20220426022420-mutt-send-email-mst@kernel.org> <CACGkMEtt8irvYVx482Zc4vkjtDANXFvUYHGFoCh=C-Xf3C2JUg@mail.gmail.com>
 <20220427022907-mutt-send-email-mst@kernel.org>
In-Reply-To: <20220427022907-mutt-send-email-mst@kernel.org>
From:   Jason Wang <jasowang@redhat.com>
Date:   Wed, 27 Apr 2022 15:57:57 +0800
Message-ID: <CACGkMEvfWA9vzVWU6yVdGNwueAAR9MhW8sFAAnGaRB7T+3GYeQ@mail.gmail.com>
Subject: Re: [PATCH V3 6/9] virtio-ccw: implement synchronize_cbs()
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Halil Pasic <pasic@linux.ibm.com>,
        Cornelia Huck <cohuck@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        virtualization <virtualization@lists.linux-foundation.org>,
        Stefano Garzarella <sgarzare@redhat.com>,
        eperezma <eperezma@redhat.com>, Cindy Lu <lulu@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Marc Zyngier <maz@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Apr 27, 2022 at 2:30 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Wed, Apr 27, 2022 at 11:53:25AM +0800, Jason Wang wrote:
> > On Tue, Apr 26, 2022 at 2:30 PM Michael S. Tsirkin <mst@redhat.com> wro=
te:
> > >
> > > On Tue, Apr 26, 2022 at 12:07:39PM +0800, Jason Wang wrote:
> > > > On Tue, Apr 26, 2022 at 11:55 AM Michael S. Tsirkin <mst@redhat.com=
> wrote:
> > > > >
> > > > > On Mon, Apr 25, 2022 at 11:53:24PM -0400, Michael S. Tsirkin wrot=
e:
> > > > > > On Tue, Apr 26, 2022 at 11:42:45AM +0800, Jason Wang wrote:
> > > > > > >
> > > > > > > =E5=9C=A8 2022/4/26 11:38, Michael S. Tsirkin =E5=86=99=E9=81=
=93:
> > > > > > > > On Mon, Apr 25, 2022 at 11:35:41PM -0400, Michael S. Tsirki=
n wrote:
> > > > > > > > > On Tue, Apr 26, 2022 at 04:29:11AM +0200, Halil Pasic wro=
te:
> > > > > > > > > > On Mon, 25 Apr 2022 09:59:55 -0400
> > > > > > > > > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > > > > > > > > >
> > > > > > > > > > > On Mon, Apr 25, 2022 at 10:54:24AM +0200, Cornelia Hu=
ck wrote:
> > > > > > > > > > > > On Mon, Apr 25 2022, "Michael S. Tsirkin" <mst@redh=
at.com> wrote:
> > > > > > > > > > > > > On Mon, Apr 25, 2022 at 10:44:15AM +0800, Jason W=
ang wrote:
> > > > > > > > > > > > > > This patch tries to implement the synchronize_c=
bs() for ccw. For the
> > > > > > > > > > > > > > vring_interrupt() that is called via virtio_air=
q_handler(), the
> > > > > > > > > > > > > > synchronization is simply done via the airq_inf=
o's lock. For the
> > > > > > > > > > > > > > vring_interrupt() that is called via virtio_ccw=
_int_handler(), a per
> > > > > > > > > > > > > > device spinlock for irq is introduced ans used =
in the synchronization
> > > > > > > > > > > > > > method.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > > > > > > > > > > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > > > > > > > > > > > > Cc: "Paul E. McKenney" <paulmck@kernel.org>
> > > > > > > > > > > > > > Cc: Marc Zyngier <maz@kernel.org>
> > > > > > > > > > > > > > Cc: Halil Pasic <pasic@linux.ibm.com>
> > > > > > > > > > > > > > Cc: Cornelia Huck <cohuck@redhat.com>
> > > > > > > > > > > > > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > > > > > > > > > > > >
> > > > > > > > > > > > > This is the only one that is giving me pause. Hal=
il, Cornelia,
> > > > > > > > > > > > > should we be concerned about the performance impa=
ct here?
> > > > > > > > > > > > > Any chance it can be tested?
> > > > > > > > > > > > We can have a bunch of devices using the same airq =
structure, and the
> > > > > > > > > > > > sync cb creates a choke point, same as registering/=
unregistering.
> > > > > > > > > > > BTW can callbacks for multiple VQs run on multiple CP=
Us at the moment?
> > > > > > > > > > I'm not sure I understand the question.
> > > > > > > > > >
> > > > > > > > > > I do think we can have multiple CPUs that are executing=
 some portion of
> > > > > > > > > > virtio_ccw_int_handler(). So I guess the answer is yes.=
 Connie what do you think?
> > > > > > > > > >
> > > > > > > > > > On the other hand we could also end up serializing sync=
hronize_cbs()
> > > > > > > > > > calls for different devices if they happen to use the s=
ame airq_info. But
> > > > > > > > > > this probably was not your question
> > > > > > > > >
> > > > > > > > > I am less concerned about  synchronize_cbs being slow and=
 more about
> > > > > > > > > the slowdown in interrupt processing itself.
> > > > > > > > >
> > > > > > > > > > > this patch serializes them on a spinlock.
> > > > > > > > > > >
> > > > > > > > > > Those could then pile up on the newly introduced spinlo=
ck.
> > > > > > > > > >
> > > > > > > > > > Regards,
> > > > > > > > > > Halil
> > > > > > > > > Hmm yea ... not good.
> > > > > > > > Is there any other way to synchronize with all callbacks?
> > > > > > >
> > > > > > >
> > > > > > > Maybe using rwlock as airq handler?
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > >
> > > > > > rwlock is still a shared cacheline bouncing between CPUs and
> > > > > > a bunch of ordering instructions.
> > > >
> > > > Yes, but it should be faster than spinlocks anyhow.
> > > >
> > > > > > Maybe something per-cpu + some IPIs to run things on all CPUs i=
nstead?
> > > >
> > > > Is this something like a customized version of synchronzie_rcu_expe=
dited()?
> > >
> > > With interrupts running in an RCU read size critical section?
> >
> > For vring_interrupt(), yes.
> >
> >
> > > Quite possibly that is also an option.
> > > This will need a bunch of documentation since this is not
> > > a standard use of RCU,
> >
> > According to Documentation/RCU/requirements.rst, it looks like a legal =
case:
> >
> > "
> > The Linux kernel has interrupts, and RCU read-side critical sections ar=
e
> > legal within interrupt handlers and within interrupt-disabled regions o=
f
> > code, as are invocations of call_rcu().
> > "
>
> My problem is it is not clear what data is protected by rcu here.
> Nothing is tagged with __rcu or uses rcu_dereference.

It should be the vq->broken here. We can rcuify it.


> We need at least an ack from rcu maintainers that this is
> a valid use of rcu and not an undocumented side effect.

Yes.

Thanks


>
> > And as discussed, synchronize_rcu_expedited() is not friendly to real
> > time workload. I think we can simply
> >
> > 1) protect vring_interrupt() with rcu_read_lock()
> > 2) use synchronize_rcu() in synchronize_cbs for ccw
> >
> > And if we care about the long delay we can use per device srcu to reduc=
e that?
> >
> > Thanks
> >
> > > and probably get a confirmation
> > > from RCU maintainers that whatever assumptions we make
> > > are guaranteed to hold down the road.
> > >
> > > > >
> > > > > ... and I think classic and device interrupts are different enoug=
h
> > > > > here ...
> > > >
> > > > Yes.
> > > >
> > > > Thanks
> > > >
> > > > >
> > > > > > > >
> > > > > > > > > --
> > > > > > > > > MST
> > > > >
> > >
>