Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4456788ioa; Wed, 27 Apr 2022 04:24:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQk6iW5BFMol9NUDlgqplqseT66ZAP79o5Zev8VD9fuDTkwkxPcpE3O0qMa1uLy6O9Eai5 X-Received: by 2002:a17:902:8306:b0:158:2d58:a36a with SMTP id bd6-20020a170902830600b001582d58a36amr28153006plb.55.1651058694675; Wed, 27 Apr 2022 04:24:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651058694; cv=none; d=google.com; s=arc-20160816; b=k6GxL+3uU6Dq0nhxyqMvkYUKzTFja5XiuaAelIevUc1aanC7tfa58D8Eg2Heb/wi5O p0gTsMPUmp0Ul4JEthPXd9W4K+7/+OLFKq14d5LgW6kxOzmp97jh1lQmj4z+2TMstHGB fHfLTPX7Y34zxPWa9EFxnonQeergthIpkVAfbRSCscJUhNYWrwN6AXjToLWEjEmXyCk0 x1ij2TvOOIJ4eoCqR4BthGtksIN9AUG4hlV+bcmrQptiFxWQGzA2qD1dp5taUPtnq32m dzcPoDkppSPLsEtm8fdAF+E/Bw9AAB04qYvtwKbCusJU3MQdQaI8P4TCIS8Ib62Y6r+n FREA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:cc:to:from :date:references:in-reply-to:message-id:mime-version:user-agent :dkim-signature:dkim-signature; bh=U9DAiEYbrUd9tFuzbQeFQ00nB7pzlike5TcMqRrzras=; b=o0ayBGw8NawCJ9KIRk/1yoE+/7Rtu8Aq+L5tuYL4/woDBdseZY4bSdq9RLuDb/yyix ACozdcdeYvTrNGua1dOh9JsjtO2PWTf41n7E1r/oyZTtu6Mk0JNTVJfwVCALBdl3oyQ2 gT3tysCueb80MPOh6Qf3kHSPlxDAUPnqEZ06erDVblDCdld6K+8DI6buWEZ+b6HYv9sK ibjfR1HRvb5NtKw7GI5k5v+ItmwlAq9dlN5TR4GNHJ5qDOr3nFF6qpjISKIrc97t8R1Z DI8Q7Y8xbtE1E/id1n2jWko+PQgyMbkmHwwH4xcXp6ZHb9Q+sqJ9Mo1Ked5cviG6C1jf 6zcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=yC+vjIVy; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=j+A319KT; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=svenpeter.dev Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f10-20020a63f10a000000b003a27ebd2526si1229913pgi.306.2022.04.27.04.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:24:54 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=yC+vjIVy; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=j+A319KT; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=svenpeter.dev Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFE1D4842D3; Wed, 27 Apr 2022 03:19:50 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355053AbiDZUZh (ORCPT + 99 others); Tue, 26 Apr 2022 16:25:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353740AbiDZUZf (ORCPT ); Tue, 26 Apr 2022 16:25:35 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C056506C3 for ; Tue, 26 Apr 2022 13:22:27 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 794575C00F8; Tue, 26 Apr 2022 16:22:26 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute2.internal (MEProxy); Tue, 26 Apr 2022 16:22:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1651004546; x= 1651090946; bh=U9DAiEYbrUd9tFuzbQeFQ00nB7pzlike5TcMqRrzras=; b=y C+vjIVy2d9e7Sp46ooWs2Kf2JARy6m6H0M3Xd867jqFUFrWAub+aj7SmwPvDRvls 1DHyHII593Q4xvg4Xy2tMprzaDtRY2ZkIFmeWOhKe0+MFXAVSJfxQIEFXjaer0yQ 41QVqTL3P2wgPbde/8FgEnD/EF/aCeXOQp3Ip8ZxHT8TS21nm9z5kIfGiKZRifau JbQgApmxegzLS83kaQkNkL1STmnPP3YkFHu6D8Yvi1Jk0HnSuQvAEAgykmKH5uGX oEDZY90QlHxxv9EGEH7kGoNXBg3FNYrTS0NCYQ66bDNivt71VkzjkvDJZg1xa44z qc8ULf5+Q02xvSWoh799w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651004546; x=1651090946; bh=U9DAiEYbrUd9t FuzbQeFQ00nB7pzlike5TcMqRrzras=; b=j+A319KTz1azrMQcygW79Tcn4Ddw5 mZulvNtYgdmTUoanzc5l51g0ypyiFKmJbgBQ7jTvgwemimfZhnt+8+M4aNyCPzoh BraX414CEZ/UBPmHexd9g75WKbpGdaqCTqJ04YstqKUTpYP3KEMl9Q2adYVRN/sI njmyc0Ocdkr448o9YI6pQrRl9u4zPNbbBkZhnOi6bsMS052eJ3JxbY/So1rgNaHG y6NqX1+lmlNgO2/oG3bBcLtxWCdaP88KRnJKHgeoR6hzP1K7DAC5lqxc2W4tU31U JYeP6V17IpwfNz2Z1c7TNDTrBBAXSoUwDJZSqYZVe4IYh3KIELKkHoT4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqmhdtreerjeenucfhrhhomhepfdfu vhgvnhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtf frrghtthgvrhhnpefgveevteefveekteffhfejgfevheetffejgeehgfejfeetledtjeeg ffejuefhveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 014402740386; Tue, 26 Apr 2022 16:22:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-569-g7622ad95cc-fm-20220421.002-g7622ad95 Mime-Version: 1.0 Message-Id: In-Reply-To: <20220425090826.2532165-1-yangyingliang@huawei.com> References: <20220425090826.2532165-1-yangyingliang@huawei.com> Date: Tue, 26 Apr 2022 22:22:05 +0200 From: "Sven Peter" To: "Yang Yingliang" Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, will@kernel.org, joro@8bytes.org, alyssa@rosenzweig.io Subject: Re: [PATCH] iommu/dart: check return value after calling platform_get_resource() Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 25. Apr 2022, at 10:56, Yang Yingliang w= rote: >=20 > =EF=BB=BFIt will cause null-ptr-deref in resource_size(), if platform_= get_resource() > returns NULL, move calling resource_size() after devm_ioremap_resource= () that > will check 'res' to avoid null-ptr-deref. > And use devm_platform_get_and_ioremap_resource() to simplify code. >=20 > Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver") > Signed-off-by: Yang Yingliang Reviewed-by: Sven Peter Thanks, Sven