Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>
Subject: [PATCH v8 47/70] acct: use VMA iterator instead of linked list
Thread-Topic: [PATCH v8 47/70] acct: use VMA iterator instead of linked list
Thread-Index: AQHYWX8+ZwoIhkdhFk24Oy0hqsh2VQ==
Date:   Tue, 26 Apr 2022 15:06:45 +0000
Message-ID: <20220426150616.3937571-48-Liam.Howlett@oracle.com>
References: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220426150616.3937571-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dqs4KL2Af2GHDZ8fimLJ4EULopwGDsX97i/vEmsv1IJ5CUcUFqt1XKuNvI?=
 =?iso-8859-1?Q?TPcZ3RTwDEF1ED/qf/cLFBOyHJaH3HMpfbqD5efFu/V50juQiUCcAS0dGh?=
 =?iso-8859-1?Q?4mAW9szGv8rb2ItxxuvrRPV/4hGOuzoOiSCfEpUgPij/N0yxfSIOMwhfNr?=
 =?iso-8859-1?Q?2wQwRbwDoPBlb4iwk4Se2SYiPKNTnSIheilXVL8qp2YHuxnvFMWgJrNouw?=
 =?iso-8859-1?Q?lGhfMlLzBvlI9AY6yE7K+OmGnqQQ3wuLJ1rYoTrsfF0YCBn7MRlQX0+Kz4?=
 =?iso-8859-1?Q?99YEUiG5tblh0tK7afoqGL7V5gc1ix89GBYzAuOZvu6fdyw3TmLR1sCSpk?=
 =?iso-8859-1?Q?ltagGX2auL0RzeNaNgS6PgV52t5Vbp/tcMobEDpB1wBuEYwCCzv3i9Lisu?=
 =?iso-8859-1?Q?186Uk4+wIwfwZptZ5zirhe2YM9MrLdXf6SASqLDo7Z2wtKeP2psmMedo1J?=
 =?iso-8859-1?Q?4rzZtwOQoDUBpWYPjfHFrsFmJi5cEpbLleYDWMYwoml7dRaJ35YQTa/PRZ?=
 =?iso-8859-1?Q?dphQ9qZtrJ0gVso0Nu6FrhwhKgN9seP3akeidjdYcgu1AypRMJYln454TJ?=
 =?iso-8859-1?Q?uwwNVADYijW+zdYC0Cad3cDx5g9IX4nJhN5Y+E86xceM55VaFNICsCagmk?=
 =?iso-8859-1?Q?5/mgpmXtyJrhcJlJblPteo1TUg9oUcBW38MuilGuZzxnHCvqBwjcgtSWU6?=
 =?iso-8859-1?Q?rFZrY71ScH65uKToH/K9IDTbPWpzxTaPZ9cakqHWaFJxrCzVmyh/jkgv9j?=
 =?iso-8859-1?Q?KN9FFRmM1saDui+UVIXCyqA1Lwvc2DEt7742tZ2hif3c57XLwAyzvqufvH?=
 =?iso-8859-1?Q?BS97+U2NZSMrbte+ZGMLBnA9n3vtfpwdp8dfYnUimYYWUobN3I9G2y37o0?=
 =?iso-8859-1?Q?WPClDGAb70EkqpmWt6IqwreU17pczbdIz5nERuit2i26conPYaRjSLObov?=
 =?iso-8859-1?Q?jEnmPD6+H+2FoxqcjEC2sU9WA81kK5r3uaWJeoGUv/AfUTNKdh/K9vxsJI?=
 =?iso-8859-1?Q?4B1hnu4UIuoEmkn3Vp1f4a68wXHltxm1Md6LcJ39a0FuZ544aSCw/zB+lJ?=
 =?iso-8859-1?Q?HhrW4yW5y/eEPzIGiyY1XP4fC7ObxAAH6DHAhLklbD2yRo9pGAmzy2sl8t?=
 =?iso-8859-1?Q?BDSRPo+XyeqKNSGVUbpFEBbyZ2zJE4daiKiMyYnLxD765B3v3DTLghcMmD?=
 =?iso-8859-1?Q?CIip08kbBZyqLSQwcqqcjfg3y2ncIOrAcQftMA81BU6FoWM8hyqqXqE3W+?=
 =?iso-8859-1?Q?FKEpZqW/zr/LtoODoFU57vZILMZR01iCM9uxqZkjCk3osqcS8J4o7HLvs4?=
 =?iso-8859-1?Q?0TjnwV3/eZpH/ZKmpSijlC+Wt/LB7xnAFbLTP2Zyj0Jva2B7o27JRQWzd9?=
 =?iso-8859-1?Q?sZiq2udJaYnIufTFqS1k1VKNBkQenZ9WkYd4xkOkhSCpFAw0rw8Kt4wyA3?=
 =?iso-8859-1?Q?s2QCR7Kpsr9uuCvg6frNt5CpV76V1eXCz6W12yXCbtl7T3E2pyHrVhPZny?=
 =?iso-8859-1?Q?YZLinAcuqJkjNYnNETwrVcIphuSeON2u73hFn4409Wp1fv6vUMamlju1kl?=
 =?iso-8859-1?Q?Lg5hgSNT4xcncf0GQUhdhUqwUpKKqkN5Ze6aqyEYJ3OshPPfrI5IYQkuXN?=
 =?iso-8859-1?Q?8dSY9ohtUmkyZnmqox8pl2/EUJlRAl96vcubIAdzmoTDhSo3/dQwYXkT6B?=
 =?iso-8859-1?Q?9mUgth7r/q4frzj74TUVHlinISrbkchbZB86mxWHgs0XJpY3+uaDRt24Q8?=
 =?iso-8859-1?Q?LwRjhS4e8rFAmM7Cjp62KY8D++WAIfwdx2GujIHgU1Kff08crGVDbWIjST?=
 =?iso-8859-1?Q?S/8FRwgkGOJGul0Lu2Cc2tIunEcy93w=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8503fd6c-8c5c-47fb-3bfa-08da27967a6b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 15:06:45.4269
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xawviSvbS2QruI8Sbdiyjhfa6IGvstesZujLNiQDWlt5/rDXeqo7uiYRlO8YtQ40hjr1kvEz1AXCDN63vP4E+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2929
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-26_04:2022-04-26,2022-04-26 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204260096
X-Proofpoint-ORIG-GUID: dI6IXTJs-7SE1k7aNOzXfqa1WUaeoRjv
X-Proofpoint-GUID: dI6IXTJs-7SE1k7aNOzXfqa1WUaeoRjv
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

The VMA iterator is faster than the linked list.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 3df53cf1dcd5..2e7bf8d41f04 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -535,15 +535,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.35.1