Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] dt-bindings: net: silabs, wfx: add prt, prtt1c-wfm200 antenna variant
Date:   Tue, 26 Apr 2022 10:56:47 +0200
Message-ID: <13694640.RDIVbhacDa@pc-42>
Organization: Silicon Labs
In-Reply-To: <20220426083305.GA17577@pengutronix.de>
References: <20220425132844.866743-1-o.rempel@pengutronix.de> <4686508.cEBGB3zze1@pc-42> <20220426083305.GA17577@pengutronix.de>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?HHUA5kT9/x4ayNI72IuVQofKyDZXirO/Gki3ehAxtk3TJq4Utyz7MczYVL?=
 =?iso-8859-1?Q?3wfuEYFHpUy+RmGkXezIUudGaxYY4Arvr9MXz2e+TVP/OkKQZFaErgudZs?=
 =?iso-8859-1?Q?s3o4iV81wzjOtEg94XcehPZIWjqWWTVtARhI5Ykc3gPgZc5+5edTp6XeUl?=
 =?iso-8859-1?Q?JwiU8dPcRhtg9d1ggGotwmgnNyAFcpHFkeJryroh0Eg13oHax+hGvRDN8C?=
 =?iso-8859-1?Q?ElYS4g8jeIy5bMV7dWTihalUAzCSFqFiI9jFEK98omF0c6xFD2+hN7Sj9i?=
 =?iso-8859-1?Q?Tllv06a6mD4L2hp4QAkvGZJCwH4ihYe8tWlYcC4NPemWGMr4ihdqlgKNIj?=
 =?iso-8859-1?Q?6Cbu3i0qhA+8WFAZ31sdcQo9SIVu1lD51bI0bF6DBqsKc7rA3PvZ3SeJ6k?=
 =?iso-8859-1?Q?1hrS+mAUmFBurBDyEUia4xIvv617U4lQzcQ2+x9ZqBWENQna/3WYfmnhoM?=
 =?iso-8859-1?Q?G68e9boYP8h/2VHQzBdV6iSChcZqy9f9BCosjux/gnImhxTHvwnloVfzQU?=
 =?iso-8859-1?Q?eHockuw46Gfi3XIjjmXTrYVem+iJO5KL5VVCISq76e4LlxMBVC/eouHFWZ?=
 =?iso-8859-1?Q?okRMeM6MNGwwj3/DWmkOJuGo4udnFflRzyp/OXeisHjFJnCPsdqwYS8GAe?=
 =?iso-8859-1?Q?lgTjFe7h0qM9cmuTs+hMQ56YJ5HsO+f6VQK6PtBR7ZNbUotnoRXOadiZFY?=
 =?iso-8859-1?Q?RrXyfY9dV7O/U0efcKu883x6qJxGO9BmRZspEjHBculCk+k+a92NtnBdvH?=
 =?iso-8859-1?Q?qvSfMVaAtvdATAO3tDUCC7JoOV8SRbd7yBT7dT6t6RjqdIbSN753Q8VUuB?=
 =?iso-8859-1?Q?LlbgDU6JWaq1AuPR6kG5R37/xPrY6itFJWMEN356Nh/LT0POuUq0QlZglY?=
 =?iso-8859-1?Q?ah96/4TaOSOCSmJEzgszlZZHmMourMgj0kAq6llvI250NFjRJCtZ3TYOuY?=
 =?iso-8859-1?Q?dVrvxs59rJkZYnkIzpaXbHaFODAA4TnnKCnXMQhEiZT5JkiegvYu/kUYIw?=
 =?iso-8859-1?Q?G3H4j2COwLMEclNJbCd1jzAlYprdJzQOMRIUVpnNnJPUgm7hor6CeLhBJ2?=
 =?iso-8859-1?Q?qgoyqol73JqT5dQFm5LbvfIauBscMPs4OAwq6hCX/khXQf+jmbARsUt6K1?=
 =?iso-8859-1?Q?UevQzj/hWm7XGWrc3UVVAiy0O+vfIgl+FVtMY4TIPA2A6x7Kn6b8US/Ix4?=
 =?iso-8859-1?Q?1D29GUqCnyDa9cviYx4at4jCVW7tmU3q8npSUXSppiB/9qFiB3YCHWxOt1?=
 =?iso-8859-1?Q?H6710TvAo48EvXfgvvCVnsatiudTiglHY/9jZWCvPOrSs7IcNoQ7oe6zC1?=
 =?iso-8859-1?Q?lTTCHeJ6Bf9F1wavDAo26ZW/TcTqcvA5vG0WIv6qqvR04Nhy1CSt6NZaqf?=
 =?iso-8859-1?Q?UF4qhw7NkuAli+npURNJ1Jy6aOu1kceN45QTvX6YRcwTVys/l9ReeTj1us?=
 =?iso-8859-1?Q?28gDgYc4HmQeJsCowQqXrhi/9eW+p6xFpwBS7tk4uMq/fMg4uBer+7khdN?=
 =?iso-8859-1?Q?xZoi2UBn1dA4dgW3B+6N25DjTjL4WYnpFdBWk8c+8M9cTgTiTn6U3AjG4c?=
 =?iso-8859-1?Q?znWAtjiURGGbBHG1j1JZIoh10tF5npA+0EsHmCjqTYdDEKnLxgf+TtcRTh?=
 =?iso-8859-1?Q?gsagGFmV3BvuYAjNCH9fizw5RYGCCptEVtvig3DE16BD3jDapte2zGerKR?=
 =?iso-8859-1?Q?QMsRkYTv0aVi7x/zQ6zdZFtd05WacQ0hHpgLxVgeeJvRiQAi0W8o+1cPCg?=
 =?iso-8859-1?Q?XM4Z3w5ZI+NWvBp67u25kXAHy3kpRWWOpk70KAVYZQTiQ//fN4cCJpNIai?=
 =?iso-8859-1?Q?5pZ+P0AGHA=3D=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bedf67c2-8edd-41ff-67aa-08da2762b612
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 08:56:54.2846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U0F0oubzvvepptJ8XLcGKyzB9WPZ53YbGUflbZueT+JbUz4APf90wKt8CZadPcC9JZtdzWB2ap6nHxHhqlD4wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3043
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 26 April 2022 10:33:05 CEST Oleksij Rempel wrote:
> On Tue, Apr 26, 2022 at 10:19:29AM +0200, J=E9r=F4me Pouiller wrote:
> > On Tuesday 26 April 2022 09:21:13 CEST Oleksij Rempel wrote:
> > > On Mon, Apr 25, 2022 at 05:38:20PM +0200, J=E9r=F4me Pouiller wrote:
> > > > On Monday 25 April 2022 15:28:42 CEST Oleksij Rempel wrote:
> > > > > Add compatible for wfm200 antenna configuration variant for Proto=
nic PRTT1C
> > > > > board.
> > > > >
> > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > > ---
> > > > >  .../devicetree/bindings/staging/net/wireless/silabs,wfx.yaml    =
 | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/staging/net/wirele=
ss/silabs,wfx.yaml b/Documentation/devicetree/bindings/staging/net/wireless=
/silabs,wfx.yaml
> > > > > index 105725a127ab..ce107fe45d7c 100644
> > > > > --- a/Documentation/devicetree/bindings/staging/net/wireless/sila=
bs,wfx.yaml
> > > > > +++ b/Documentation/devicetree/bindings/staging/net/wireless/sila=
bs,wfx.yaml
> > > > > @@ -39,6 +39,7 @@ properties:
> > > > >    compatible:
> > > > >      items:
> > > > >        - enum:
> > > > > +          - prt,prtt1c-wfm200 # Protonic PRTT1C Board
> > > > >            - silabs,brd4001a # WGM160P Evaluation Board
> > > > >            - silabs,brd8022a # WF200 Evaluation Board
> > > > >            - silabs,brd8023a # WFM200 Evaluation Board
> > > >
> > > > I think you also have to declare this new entry in wfx_sdio_of_matc=
h,
> > > > and/or wfx_spi_of_match and wfx_spi_id.
> > > >
> > > > On the WFM200 variant, the antenna is built in the chip. So I think=
 you
> > > > can point on the same configuration than the brd8023a.
> > >
> > > I assume driver update can be made in a separate patch. As soon as we
> > > reserved compatible for this boards there should be no conflicts. Thi=
s patches
> > > series is targeting only devicetree and needed DT schema changes.
> >
> > hmmm... I am not DT specialist, but it seems a bit weird to have a new
> > entry in the dt schema, but no new code in any of_match table.
>=20
> Here is one example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/devicetree/bindings/spi/fsl-imx-cspi.yaml?h=3Dv5.18-rc4
> properties:
>   compatible:
>     oneOf:
>       - const: fsl,imx1-cspi
>       - const: fsl,imx21-cspi
>       - const: fsl,imx27-cspi
>       - const: fsl,imx31-cspi
>       - const: fsl,imx35-cspi
>       - const: fsl,imx51-ecspi
>       - const: fsl,imx53-ecspi
>       - items:
>           - enum:
>               - fsl,imx50-ecspi
>               - fsl,imx6q-ecspi
>               - fsl,imx6sx-ecspi
>               - fsl,imx6sl-ecspi
>               - fsl,imx6sll-ecspi
>               - fsl,imx6ul-ecspi
>               - fsl,imx7d-ecspi
>               - fsl,imx8mq-ecspi
>               - fsl,imx8mm-ecspi
>               - fsl,imx8mn-ecspi
>               - fsl,imx8mp-ecspi
>           - const: fsl,imx51-ecspi
>=20
> httpt://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d=
rivers/spi/spi-imx.c?h=3Dv5.18-rc4#n1063
> static const struct of_device_id spi_imx_dt_ids[] =3D {
>         { .compatible =3D "fsl,imx1-cspi", .data =3D &imx1_cspi_devtype_d=
ata, },
>         { .compatible =3D "fsl,imx21-cspi", .data =3D &imx21_cspi_devtype=
_data, },
>         { .compatible =3D "fsl,imx27-cspi", .data =3D &imx27_cspi_devtype=
_data, },
>         { .compatible =3D "fsl,imx31-cspi", .data =3D &imx31_cspi_devtype=
_data, },
>         { .compatible =3D "fsl,imx35-cspi", .data =3D &imx35_cspi_devtype=
_data, },
>         { .compatible =3D "fsl,imx51-ecspi", .data =3D &imx51_ecspi_devty=
pe_data, },
>         { .compatible =3D "fsl,imx53-ecspi", .data =3D &imx53_ecspi_devty=
pe_data, },
>         { .compatible =3D "fsl,imx6ul-ecspi", .data =3D &imx6ul_ecspi_dev=
type_data, },
>         { /* sentinel */ }
> };

Right.


--=20
J=E9r=F4me Pouiller