Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4464786ioa; Wed, 27 Apr 2022 04:35:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymPZ7KYIAtnb25J5My+3CXHuxNB6R+W1YorPCj4n+MuxH7ybvkH/5WTFvgkmVujixXVnUO X-Received: by 2002:a17:90b:33ca:b0:1d4:d5ab:40b0 with SMTP id lk10-20020a17090b33ca00b001d4d5ab40b0mr41208728pjb.96.1651059311584; Wed, 27 Apr 2022 04:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651059311; cv=none; d=google.com; s=arc-20160816; b=lxKDxkxgx/3MFZP4rL4V6CNuWQ9JJc86Sg9azqRND4XSK7kjmRYAp7buxMAMTwkasv Syp1DFGnlHnejAQJXjrdwCJKwN5SGvJ/FNwJOGJ40vd/FFr1yG9lb5PPA7f6wCBA9SNx mFMsdt0duwV1YfColDTwBEx0W1WKG74TCH/GSB1rDrTiOxF6xisgvZmW1YIb+pYPjfn/ zpUXfpUHrdcEQLStKkCmrmkps/63K1bzPRMhhnJdRLMG7DpYNkZT+mpWr61tCuI7t/sw v7cRdTrFkgWrGhnKgnYmG6H/RDT+8WnsFyt74Gvr3//VcbIbHdxuBxRzoiK4AuJ1Urih 1Fmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=aNhaa4dZuwIsZ3bau/gdwYP34lare5fShqR6oe9C3Es=; b=lxF1NbRsYnE6IiNbD25smhugMELKEy0FJomjbsSNWgNLTU6oi9za4MrPqHrkxvU6G8 +vxrlRe7VUmCzqgLy3vSko2k7Ed0mi244gbQRQGl6KeYbx6hb7sfgtShtebbdGT4/wto snUtWi83UpKHjgc0iHUZ38riRMjQnIsL7MUM33WkcMcZkuotS71rvvKAK+vQc6rAp9yW ISXxJBQpoRzIoD0ry1vg3q+J/wnScG9705f21lIejVsQbO3t5702/0QshqqWnzW0fNBB 7epOTxAUk+EWMagL0b6f820uVV77/zy8judGTqzT8h2z2Rm77iGjYUo0WWEuf7nibvzM zpSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DGvdOV8v; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i20-20020a635854000000b003ab7e64a46dsi1272412pgm.157.2022.04.27.04.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 04:35:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DGvdOV8v; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8ADEC496514; Wed, 27 Apr 2022 03:24:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344579AbiDZIXY (ORCPT + 99 others); Tue, 26 Apr 2022 04:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344572AbiDZIXV (ORCPT ); Tue, 26 Apr 2022 04:23:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4ACE638193 for ; Tue, 26 Apr 2022 01:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650961213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNhaa4dZuwIsZ3bau/gdwYP34lare5fShqR6oe9C3Es=; b=DGvdOV8vBaOlcjy7sIvGds6ivaELNJGoK5J3jooTQItrSkjokA56Njbf8AwtM45RzplvzH ggcy7cchWL864/ZPYInvSMBHWxQvWenJPebMcyX2F3Tw095YBIfP4nLqstTOSJ8/F8jcaX H/9rXKbj8hQJJ0LE80j5fgHTtfQziDg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-466-TFfwwowKMQGeuFJuuGYKyw-1; Tue, 26 Apr 2022 04:20:11 -0400 X-MC-Unique: TFfwwowKMQGeuFJuuGYKyw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1DAB029ABA02; Tue, 26 Apr 2022 08:20:11 +0000 (UTC) Received: from rotkaeppchen (unknown [10.39.193.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A5B840D0160; Tue, 26 Apr 2022 08:20:09 +0000 (UTC) Date: Tue, 26 Apr 2022 10:20:08 +0200 From: Philipp Rudo To: lizhe Cc: "Baoquan He" , dyoung@redhat.com, vgoyal@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/crash_core.c: No judgment required Message-ID: <20220426102008.39718e00@rotkaeppchen> In-Reply-To: <20220426101718.765686a9@rotkaeppchen> References: <20211210032003.16278-1-sensor1010@163.com> <20211214173242.192f47e8@rhtmp> <62058381.3b6e.1805f62c8f4.Coremail.sensor1010@163.com> <20220426101718.765686a9@rotkaeppchen> Organization: Red Hat inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, 26 Apr 2022 10:17:18 +0200 Philipp Rudo wrote: > Hi lizhe, > > On Mon, 25 Apr 2022 14:22:31 +0800 (CST) > lizhe wrote: > > > HI : > > > > > > I found the problem at the first time and gave the solution, > > > > > > > > > > Pphilipp Rudo just saw the solution to the problem and gave an explanation. > > the author of this patch should only be me > > right, I only commented on the patch you sent. > > Could you please update the commit message and send a v2. should have checked the rest of my mails first...