Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <c24afde6-9f78-155e-c3ec-629e4e832005@arm.com>
Date:   Wed, 27 Apr 2022 10:21:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4] arch_topology: Trace the update thermal pressure
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, sudeep.holla@arm.com,
        dietmar.eggemann@arm.com, vincent.guittot@linaro.org,
        rafael@kernel.org, rostedt@goodmis.org, mingo@redhat.com
References: <20220427080806.1906-1-lukasz.luba@arm.com>
 <YmkK32iEJ6bVyoMU@kroah.com>
From:   Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <YmkK32iEJ6bVyoMU@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/27/22 10:20, Greg KH wrote:
> On Wed, Apr 27, 2022 at 09:08:06AM +0100, Lukasz Luba wrote:
>> Add trace event to capture the moment of the call for updating the thermal
>> pressure value. It's helpful to investigate how often those events occur
>> in a system dealing with throttling. This trace event is needed since the
>> old 'cdev_update' might not be used by some drivers.
>>
>> The old 'cdev_update' trace event only provides a cooling state
>> value: [0, n]. That state value then needs additional tools to translate
>> it: state -> freq -> capacity -> thermal pressure. This new trace event
>> just stores proper thermal pressure value in the trace buffer, no need
>> for additional logic. This is helpful for cooperation when someone can
>> simply sends to the list the trace buffer output from the platform (no
>> need from additional information from other subsystems).
>>
>> There are also platforms which due to some design reasons don't use
>> cooling devices and thus don't trigger old 'cdev_update' trace event.
>> They are also important and measuring latency for the thermal signal
>> raising/decaying characteristics is in scope. This new trace event
>> would cover them as well.
>>
>> We already have a trace point 'pelt_thermal_tp' which after a change to
>> trace event can be paired with this new 'thermal_pressure_update' and
>> derive more insight what is going on in the system under thermal pressure
>> (and why).
>>
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> 
> Much better, thanks.  I'll wait for Sudeep's comments/review before
> taking it into my tree.
> 
> greg k-h

Thank you Greg!