Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v2] bus: fsl-mc-msi: fix MSI descriptor mutex lock for
 msi_first_desc()
Thread-Topic: [PATCH v2] bus: fsl-mc-msi: fix MSI descriptor mutex lock for
 msi_first_desc()
Thread-Index: AQHYTkLZyTZGrgBEjUuE0crYEsKlAK0DqWwA
Date:   Wed, 27 Apr 2022 10:38:46 +0000
Message-ID: <20220427103846.hjnkfn5fpuqlzuap@shindev>
References: <20220412075636.755454-1-shinichiro.kawasaki@wdc.com>
In-Reply-To: <20220412075636.755454-1-shinichiro.kawasaki@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IEV5StX3CPlIkwDyGQrHQmt+GlNNyeBGIWkU8IUWTIUu5iSfjvy3vV/OGmpw?=
 =?us-ascii?Q?z3LygV1kCckVAxdGlehzfQOPSDKbGE98JfcOsgs/N5k/U8azEBntcb1KcNBs?=
 =?us-ascii?Q?Uk2IVrEeFv6ebB+++dkmuEp62gJmxJtGLGBHuNipcGL58UqavgGjqPZ1Hez2?=
 =?us-ascii?Q?i08Wo3mG/QFsURXJPsXcoRYghdhI0L4pKPkNWdGLxhMklqnMtVjEqnoK95kA?=
 =?us-ascii?Q?iSKthxMmhQ6Oc+nv3Y0haiufCAtnr7GnuSHKfgTjFr3d3S1kX9xt1t+iGJdr?=
 =?us-ascii?Q?ftIcxDEbVhWdnqeP8LqCaQvz/rjnTzxQNs8QoX5RX6ta7h/naJcn0DIM4nuw?=
 =?us-ascii?Q?IW8De217nBQV4B2RN3aFsmp/uGEBFCB8G/idxQC6yXHBatxQdAxkIpmOL8RO?=
 =?us-ascii?Q?PuMalseJpv2uPTwnzlNcq1gI1HxGxhnlL2147MjXcIGN3TpHL0nVied492LL?=
 =?us-ascii?Q?VCgLMlQnw1jkcz9ZXohQt4pkdn0UAfCgXBCjykwFCt9+/PgRyu4X+t9pMU6c?=
 =?us-ascii?Q?sugmorTb30bB8SAN0+rb3YYveVovjOnclZC1lTTYZ29FWkT7xbiWdAY2oX88?=
 =?us-ascii?Q?Mv42eY7JSYS4vmkanW+FKvUr1hoQpa8aPhare3mr/m0O52k5DGlZC6s7NZof?=
 =?us-ascii?Q?LbS9S+9Ven/wOhyRWJEeiDEvsvocyJSfArUf2alyQAOVzYkA876Q50KutAlT?=
 =?us-ascii?Q?RmmQmjWWwmttKiQDgWr6eF12fG7dlT/rzDulLiOQfy0bgECdy965bcPzlZqU?=
 =?us-ascii?Q?m3hNtxXHHyeADrH13LAXRfK/ervHmk7tJDO6bePsC+bBoiUTvDDU8xAoKEVO?=
 =?us-ascii?Q?nbt6UJET5iDHcp39teiheKVe6sl3gqan4j4cdRYZ0Z7MPcDZ4EEzNi1NIymh?=
 =?us-ascii?Q?Lm+Iov5qEIT4RSUbRyCBLtbUPMIe83yLwZ260qDhApGpDLkGK6ynkaxrIxLO?=
 =?us-ascii?Q?iU3MFkottns8ISGDHDVASCuEoUvWrC2co+rx126Ngh64aIcnVO4hFr5EIxSN?=
 =?us-ascii?Q?ur2zRFGcVtfDXbFlef1UZHl0BCh5G9d0pYHWNhu9zt3INh9mI7JEyy7Di3rm?=
 =?us-ascii?Q?uvr1bQodtUvFsVypMxPcWyhUUKXVxhBUaHDk8QViPE6wPUoEx3Uznt1HEYsi?=
 =?us-ascii?Q?t1JmqUQMImboXCVIxq4+5/q4eKK0IThThPzRk/fONlGF28KXphmvDbCEuw/N?=
 =?us-ascii?Q?T5csuLKetzpRCIrqnf7HwJDhjaSkWnHi85g8K5KVzksZtVKv2r1oKnnAhFG7?=
 =?us-ascii?Q?3Yrwxac83+Ag3w5dSO15ee9Lfri3x0x2W1JBDpdgM43aMjHqHkzy4+GxX48k?=
 =?us-ascii?Q?YyN83N1xkwu/2+OQyY1/nFTflWNvHceS4OwFINXVufJssB7jeMzu3QFdIHmh?=
 =?us-ascii?Q?63WPzLvNKOy7Zlykf4Z0byE7CmzjH6LhCTDmsmDmCt6zhybjvq72DVYNLs+N?=
 =?us-ascii?Q?G4U2ICXk8gbYbjfPi1oy7qCAfCQDMWmb8UeRcOBq73NgcMQNsM0s3KOrvKHL?=
 =?us-ascii?Q?m9Mz07mQrKFm1TPYNbABkQDcDk4qRLDyfCry27+DIoEkTIfto3jF6SMmwKjM?=
 =?us-ascii?Q?NST0ZG6BGyW9WYeoe7vWxbf91WQTTx+YVUKTA5KHecq4G3WL65IT5kYO50Fz?=
 =?us-ascii?Q?qYbrW8OJcT6N47vd85Jcc+6Bm1Rt22vtha2UkzLxehBGekP1KkMHJIujxorn?=
 =?us-ascii?Q?3MZwOCC/JniJNqY5XYAYC1N4xW8FLIZltw6dM8HyS9hkL1NyxSQ9WQQ11Xvn?=
 =?us-ascii?Q?NPdmE8Ny7h2tyZJ1o1OSjHnv79oDZwIub3yVEkFemQQo5e9XzEQ8?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1C2550650578DC4697607F1DE135A973@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2166fe34-f782-4de4-498c-08da283a1c17
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 10:38:47.0692
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L5GWfutzWOEtwKJEu938qSmt/yMb4E90+D0HobUJlinX8mCTLOgz0EeuH6rTufgtkke9ewRMoJmS0wqYnUDz30XUd5P1mLcCrBus+97I2Ag=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0401MB3696
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 12, 2022 / 16:56, Shin'ichiro Kawasaki wrote:
> Commit e8604b1447b4 ("bus: fsl-mc-msi: Simplify MSI descriptor
> handling") introduced a call to the helper function msi_first_desc(),
> which needs MSI descriptor mutex lock before call. However, the required
> mutex lock was not added. This resulted in lockdep assert WARNING [1].
> Fix this by adding the mutex lock and unlock around the function call.

This is a gentle reminder. Comments or merge to upstream will be appreciate=
d.

--=20
Best Regards,
Shin'ichiro Kawasaki=