Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] i915/gvt: Fix NULL pointer dereference in init_mmio_block_handlers
Date:   Wed, 27 Apr 2022 19:54:56 +0800
Message-Id: <20220427115457.836729-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mVswxLF4DPyKZyol2LOCj0ocz1yY5POlspM0EF+uPVxlp+QJe1mkTcMyCbJe?=
 =?us-ascii?Q?ItuqdFNHzz4772yH0SIiZsGvD304VTzVqxLxiW2NXggE1NJT/UwXDeQrez2F?=
 =?us-ascii?Q?yDO8HB1Rvz1kATl/YikqxDmJUdnFZQ3UBqIzeLysLiOBMesXFCwlMq7xf8Uk?=
 =?us-ascii?Q?Yu9FzfJpRbGNxI0OaOeSywQ3JcV2JG+8lel761XCQq7pP4/5r8lTn2tDLE3k?=
 =?us-ascii?Q?gPFOGbMec1/bswH5w30H/KMKMVbr1GBqPamGcpiB2h0h5hY1mMdtoc3dXpaj?=
 =?us-ascii?Q?E3+ZwArqjJZQ9OEMHD5owiQ8ElKXYUcTXS8eLehCKBmzlQ733oAOxckv8Cpu?=
 =?us-ascii?Q?27dXB12iHHBIu54qWGGfBLcWoXoi10zsR8gUmuzaP/t8ID2/z7fxqs6FhmGp?=
 =?us-ascii?Q?hXhitJVQPwm9rvNq+1EKY8stcbKps+gIWe8ddJAoLaYpV/invjNabf9gdmZm?=
 =?us-ascii?Q?xsHPGbrzsEmm1jBw2Qscp+06hrSkzEJSa5DinBcm5MJc7t+M77gXs9lSRUU6?=
 =?us-ascii?Q?+kSl5xG3r4Tz/ukPtE6+g7DHohCSWK/Ve3sPOQf2yZP1h9dv4rKXjfScKq4Y?=
 =?us-ascii?Q?XQaVUTa8Guto5xxyoM2r72i7VtlEDQ0haBBTJNp7gnr9+D0x5T7AP1SfKP06?=
 =?us-ascii?Q?D5tUppBTpI3Lfns2hsiO6rF23BfdVU429xo2y4gPzwcPcghHq9dSFbwOkohT?=
 =?us-ascii?Q?Q0fiSvy4jAOTIiKxfl0xp9gZ/IlQoPssY4ovXgCTz7F8poAENYpESGvqcCQP?=
 =?us-ascii?Q?rAYUESq3vXpmG36q/9IYfytEg1WVKsUE2XmwGF5i1tFVp+mDFVQf01ul+YsA?=
 =?us-ascii?Q?UBZz0u8pm3bUnD691wN4nOAR+RPM5dG1oDtDRFWWUethHjywZ+2RxZfQzXo4?=
 =?us-ascii?Q?A1CRBbh4W1IOnY2G1nhB9SxGqqvLwXB9LOTCw+qQP27MySKD+HDMc7XWuyZf?=
 =?us-ascii?Q?jqFqaRPC0wxXEUUPpzi/m9MvDleC080Ir+/84E+gdTRcite2UmyNrTDQIxUE?=
 =?us-ascii?Q?G9z7C3Vw6Q9zKf2jLcmuUf+6CCJP5gzs6ensogWIaYSPrqKuFuKWLqUVh42V?=
 =?us-ascii?Q?AFgqchNHLckFOlFkAmQBodqFovLlJnvcVgnXGZSpVIih7ZE4cXlw+cAWojJI?=
 =?us-ascii?Q?bbwK/e2NE4duP0jY6d2SsoTEw+o876czsbjOFvA1OL2HYiUAuRdSfnciSIVS?=
 =?us-ascii?Q?BO/NEnx3WlBP9mqtkEsDZkDO4Z36ifljx0TjWnbqQDv15YBj7x5OKp6aV09E?=
 =?us-ascii?Q?uAdLz0ZbwRyiE0usOtXU//AaTDUObBonUjxSjDHyNQR5yqX4zpWIt4hySxzt?=
 =?us-ascii?Q?S6ilYSyoTBhOYGoL6Euxcr8UNbf3G6cI2K3675yZeg5K8hiVZARq8YJNVXUi?=
 =?us-ascii?Q?4eLr2fhruBmE+FNh2TULNNMxgPgtShzKzRvc+yinlMmjMiXVt7a3ZWYxCcAv?=
 =?us-ascii?Q?5l4/xV7aqUzl7/1jiJrudNJe3L3yGWpv7ASliF5yW53q95nJflIeJBLk8bXj?=
 =?us-ascii?Q?aEPpOMJEkdGER64Drfpm4StIajiDLwuWmRcgfeg9cX7cLJ/2WghZKbQO3kK0?=
 =?us-ascii?Q?8Oo8Pqz8ArjfPjYYHHMuQ5PvbWNbhAIP5rAHJpQsmMwN+I9/eIUR3nvB57C4?=
 =?us-ascii?Q?f6ZzQYMP25mYh6/aZBu1digJMoFqfRDQcuu8DJwYuDN4VU2OF6xDRGdMH3RH?=
 =?us-ascii?Q?29zkoNyP/ljKkr61var84BggyJcYbs685I+Zy6l6ZHiWP36mYGgWQG38iP14?=
 =?us-ascii?Q?e4KYAFCi4g=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d925f00-9904-4202-5482-08da2844d086
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 11:55:25.0510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7sJBd54IljHaomMkdlcCNBN+1vOvz19Sltf32TuY6O3hJIS3leWpt2UEoJYhoNyfhSm2f2oYIyVtmSFfG5Ox3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB3992
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck error:
./drivers/gpu/drm/i915/gvt/handlers.c:2925:35-41: ERROR: block is NULL but dereferenced.

Use gvt->mmio.mmio_block instead of block to avoid NULL pointer
dereference when find_mmio_block returns NULL.

Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index cf00398c2870..7ffe0fb512a9 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -2922,7 +2922,7 @@ static int init_mmio_block_handlers(struct intel_gvt *gvt)
 	block = find_mmio_block(gvt, VGT_PVINFO_PAGE);
 	if (!block) {
 		WARN(1, "fail to assign handlers to mmio block %x\n",
-		     i915_mmio_reg_offset(block->offset));
+		     i915_mmio_reg_offset(gvt->mmio.mmio_block->offset));
 		return -ENODEV;
 	}
 
-- 
2.35.3