Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Ludovic Desroches <ludovic.desroches@microchip.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] mmc: atmel-mci: Simplify if(chan) and if(!chan)
Date:   Wed, 27 Apr 2022 20:03:09 +0800
Message-Id: <20220427120310.838843-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NFqP8QktZ9KFuzSvic6kiDznrnS3bPFqFM96V65Jb9trBfqK+M8InoOcD/Y0?=
 =?us-ascii?Q?ykrwq9gzOi4Pah9as8RyCpr+k53ESAmt8QR9HOcdxls3KGIWYxpyJGdGVIdE?=
 =?us-ascii?Q?rl31V9tMUiDnEKtW/Llhn0jPJXc9Re7psjGuOgT70IdHSIXeZTd72UqVEFRw?=
 =?us-ascii?Q?NSqvCnVXk9vBtDrgM6TAZxFF4gdVDs6iEooRBa2kZ0uF1xFikX8svQ20u7hS?=
 =?us-ascii?Q?Tbdt3N/r51XSh0CHqsIPEsfyhE6KueBgm+jZ2q3ewVDfpYXRBv8VqrHstiUR?=
 =?us-ascii?Q?CJfEGXreRQOe4BvqP+erYJ13dJdPedmqdVXHGsPRxVIXQBtIs7t52P30GQgC?=
 =?us-ascii?Q?4noGzmocq4wuidQFjb3e9NEDLecDkbzK96h03VpYepjA2MohBOuDQJYh2Szz?=
 =?us-ascii?Q?iL/Dxn1JckcIwRvwMEclrUNEuTiIcrnSnHHM9C0M6QpTu1dvU76uEHfyXu20?=
 =?us-ascii?Q?8H+fyoZ+wdYMKU3JcFkwbh6ArqpHDdSRRWX/6GOMKPSvEg2sTmfLKIcq/bOM?=
 =?us-ascii?Q?0kwzs8yU88TrCHCiE3AVDSQ0EcrWVHY8am+KAFjrvfeD1G4LFLkEoC50jR4d?=
 =?us-ascii?Q?xCSz+PXENu1lCiKOMiV2M8q9x2+1wM0qMkFv5+WsErnFMr90/KnABOqzt3ht?=
 =?us-ascii?Q?jIMzQhi9y+8S0UmdxOQIPHic/AYSG/ZrYj5ojfPr5EY0Wqk1hmjZDbo12Cyu?=
 =?us-ascii?Q?aTZGEeGgPD0ZjaRebkl+fateGW82oCyFrudDvJyeF7xCS0dFoM58srWANaHE?=
 =?us-ascii?Q?F0QLk8CbACRAirUwpmDhlBGuBQr0d+9jPPvMyx9cWLSa73BtkKzuHksKnOAw?=
 =?us-ascii?Q?GFprk0kh8xGklptimYjlB4WJNCT76IP4fnL18zqwtnlZMLatdwhr3P1qg7gE?=
 =?us-ascii?Q?IovaQs65nU2SZrG4y6sX4qBvZQMMop4t5GUjg+KHTokLxAuD2yaJ5zPWiBCa?=
 =?us-ascii?Q?AzgmACPqivkqMdWIw3VXfZn5zdjTyx5bRfwPW11VUWN6unWQUqd9asTX7s8I?=
 =?us-ascii?Q?/vKjCjHPaRaSRZ/chH90FNM8NG6lELxw+b0ehA4YcHaehokF3zkpbm61eipQ?=
 =?us-ascii?Q?O55KkXzRJbA3XCi86rgfyOeWa4GJN2LdppFLK8vNCFC0sfMMu5ZBhxoZ5TqN?=
 =?us-ascii?Q?tsx0HY83YkLTeFAFd5yNNlCNAU+7CUHVE5b/j/OoamE8V2YXWo+66gLEQj6S?=
 =?us-ascii?Q?fQGv70DVnwB5W5a0JFWiD6N7BWXlsyaUEPjQBrUS3TKbqIEP1jnXr51DKjca?=
 =?us-ascii?Q?/3wRt0dYYdj9Rr2nsmLOMBZzzkLinYMadcnwNdk3FWOoqUWRHoWz+Wu0++ih?=
 =?us-ascii?Q?oYn7NOhHZ3uNlU2iY9U0s68fu45AHZKfmKJtuqfnNaa6gljF+cJyBHfoFcRb?=
 =?us-ascii?Q?iTpgT0pvHlvLQv1cIGO8H+UkVXEWhtaD5e66r9CBUWkyv6nPCdnT8O2Onit4?=
 =?us-ascii?Q?DtzeezT4J0Oyeoi6gLzucYtZGA4wTBex7yVfXCwVOGj8whUvmTAsRyOOt1YP?=
 =?us-ascii?Q?C77L3PIpBWCZUHnTsnEunS/eTK5kcVoeex3hJSPGt+ajHUY5s+/S0w4i0Hi1?=
 =?us-ascii?Q?Bz8eouOsviT2jjRTa7/+WrrulIHTETFH/41woFjjI8VSZOt0LSHgeQu5QjYg?=
 =?us-ascii?Q?7mS5ltNPKSQQFl1VMiwWEpz8XH0Toh3Mt++ueIHvcbIkVcqKlI5ut5n8ymfE?=
 =?us-ascii?Q?7T7uTJEMnXWEia2ZET8x4Y0wDr/OEju05BZoiQeKTveNinCwb+Mz29bKeDif?=
 =?us-ascii?Q?xVfw33JlCQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb98a8c-365e-4f0e-e71d-08da2845f1c5
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 12:03:30.2667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YE7UHX6FggvKmwCj+5a1O/KIvMTmd8UcUqKtWwweNTJh8XsNf9zTFyJKvk9hn8ILItkIbZ2h8LU8nbIcCV9ZHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4980
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use if(!host->dma.chan) instead of if(chan) and if(!chan) to make
code better.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mmc/host/atmel-mci.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 807177c953f3..91d52ba7a39f 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1122,13 +1122,12 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
 	}
 
 	/* If we don't have a channel, we can't do DMA */
-	chan = host->dma.chan;
-	if (chan)
-		host->data_chan = chan;
-
-	if (!chan)
+	if (!host->dma.chan)
 		return -ENODEV;
 
+	chan = host->dma.chan;
+	host->data_chan = chan;
+
 	if (data->flags & MMC_DATA_READ) {
 		host->dma_conf.direction = slave_dirn = DMA_DEV_TO_MEM;
 		maxburst = atmci_convert_chksize(host,
-- 
2.35.3