Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220426134924.736104-1-jun.miao@intel.com> <9c951fe6-d354-5870-e91b-83d8346ac162@intel.com>
In-Reply-To: <9c951fe6-d354-5870-e91b-83d8346ac162@intel.com>
From:   Marco Elver <elver@google.com>
Date:   Wed, 27 Apr 2022 14:26:58 +0200
Message-ID: <CANpmjNNxOX12NcMjXJr3XWcoe6d+Dp74pR+2naVW0anwcYfmoQ@mail.gmail.com>
Subject: Re: [PATCH] irq_work: Make irq_work_queue_on() NMI-safe again
To:     Jun Miao <jun.miao@intel.com>
Cc:     ryabinin.a.a@gmail.com, Dmitry Vyukov <dvyukov@google.com>,
        bigeasy@linutronix.de, qiang1.zhang@intel.com,
        peterz@infradead.org, akpm@linux-foundation.org,
        andreyknvl@gmail.com, ying.huang@intel.com,
        kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 27 Apr 2022 at 03:49, Jun Miao <jun.miao@intel.com> wrote:
>
> Add  To/Cc : KASAN/MEM , since I only used the scripts/get_maintainer.pl
> to irq_work.c file.
>
> Thanks
> Jun Miao
>
>
> On 2022/4/26 21:49, Jun Miao wrote:
> > We should not put NMI unsafe code in irq_work_queue_on().
> >
> > The KASAN of kasan_record_aux_stack_noalloc() is not NMI safe. Because which
> > will call the spinlock. While the irq_work_queue_on() is also very carefully
> > carafted to be exactly that.

"crafted"

> > When unable CONFIG_SM or local CPU, the irq_work_queue_on() is even same to

CONFIG_SM -> CONFIG_SMP

> > irq_work_queue(). So delete KASAN instantly.
> >
> > Fixes: e2b5bcf9f5ba ("irq_work: record irq_work_queue() call stack")
> > Suggested by: "Huang, Ying" <ying.huang@intel.com>
> > Signed-off-by: Jun Miao <jun.miao@intel.com>

I thought this had already been removed, but apparently there were 2
places: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=156172a13ff0626d8e23276e741c7e2cb2f3b572

Acked-by: Marco Elver <elver@google.com>

> > ---
> >   kernel/irq_work.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> > index 7afa40fe5cc4..e7f48aa8d8af 100644
> > --- a/kernel/irq_work.c
> > +++ b/kernel/irq_work.c
> > @@ -20,7 +20,6 @@
> >   #include <linux/smp.h>
> >   #include <linux/smpboot.h>
> >   #include <asm/processor.h>
> > -#include <linux/kasan.h>
> >
> >   static DEFINE_PER_CPU(struct llist_head, raised_list);
> >   static DEFINE_PER_CPU(struct llist_head, lazy_list);
> > @@ -137,8 +136,6 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)
> >       if (!irq_work_claim(work))
> >               return false;
> >
> > -     kasan_record_aux_stack_noalloc(work);
> > -
> >       preempt_disable();
> >       if (cpu != smp_processor_id()) {
> >               /* Arch remote IPI send/receive backend aren't NMI safe */
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/9c951fe6-d354-5870-e91b-83d8346ac162%40intel.com.