Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220420211105.14654-1-jagathjog1996@gmail.com> <20220420211105.14654-6-jagathjog1996@gmail.com>
In-Reply-To: <20220420211105.14654-6-jagathjog1996@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 27 Apr 2022 14:34:21 +0200
Message-ID: <CAHp75Ve8mruPEyorSmydAHM27rnL9Wv+qNdWyQ9tVxz-+JJYiQ@mail.gmail.com>
Subject: Re: [PATCH v4 5/9] iio: accel: bma400: Add separate channel for step counter
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     Dan Robertson <dan@dlrobertson.com>,
        Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Apr 20, 2022 at 11:11 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Added channel for step counter which can be enable or disable
> through the sysfs interface.

...

> +static int bma400_enable_steps(struct bma400_data *data, int val)
> +{
> +       int ret;
> +
> +       if (data->steps_enabled == val)
> +               return 0;
> +
> +       ret = regmap_update_bits(data->regmap, BMA400_INT_CONFIG1_REG,
> +                                BMA400_STEP_INT_MSK,
> +                                FIELD_PREP(BMA400_STEP_INT_MSK, !!val));

> +       data->steps_enabled = val;

This will update the value even if we got an error and actual device
state is unknown here. Does this make sense?

> +       return ret;
> +}

...

I perhaps missed why kmalloc() is needed now. Any pointers to the discussion?

-- 
With Best Regards,
Andy Shevchenko