Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 27 Apr 2022 15:54:09 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Dong Aisheng <aisheng.dong@nxp.com>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] clk: imx: scu: Use pm_runtime_resume_and_get
 to fix pm_runtime_get_sync() usage
Message-ID: <Ymk88RJ2v9cwJvU2@abelvesa>
References: <20220425011117.25093-1-linmq006@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220425011117.25093-1-linmq006@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fLfayIgIwR2S1kCGVZZanFV5zghWzfsJUVqudpNNsECO4xiE3sav7coMAHGS?=
 =?us-ascii?Q?6y8DVra4yv9i5BQEysp+oSjsXxZrpq4sPhXla5LT1MMwiIZsztQr5pirX/5T?=
 =?us-ascii?Q?m8Y6p54K5xy6dutk4kpg2AP5sIe6B2uWv94rHqMtUxrLWs+KNFTlosu7rep1?=
 =?us-ascii?Q?UGINHr3LUdY/yKKPnac7UJbvpEGdoZeSKPZix1R9I+K1iJk9atrm7sJK5Pgd?=
 =?us-ascii?Q?73I0We5Jtv9W3Jg54I41fh2Hqbx7LSw9Afk0OXzltA3Gjwrj39KexlO5aGXd?=
 =?us-ascii?Q?k4v9J+pvxrXQuvj5/2Wder7jwdR+jUK2KxWkIAogkmJnywKc11/cDCspE0tP?=
 =?us-ascii?Q?kgeKio/YCFV2Bo4FJJFw45gwvYY7PIbeX9RJpBzkcuqgTIOUzxVsudrhtZFH?=
 =?us-ascii?Q?pMZ5etVPtyh7o4pcxZLWnhu4LIl2EDn56/U8FpuOT7o4JAj2K51/Aqfl7xfl?=
 =?us-ascii?Q?kfJrdZYyv3HC6ooQb6tdf3MWDAEXz03WAZq1tj2StJNFxFYS+dVr3lXL9FvA?=
 =?us-ascii?Q?phAjF2dHO24IK52qrhj+ffDq1AEPUD/Q/N3YTIhOmsrHrFYvX+BOs6gxjWmN?=
 =?us-ascii?Q?qqx7QM5RQM1j9N5ztFc0gLffYCUAmcxsHFkh3d/4al1PV4JgVpOr9Y7aC6WX?=
 =?us-ascii?Q?L67R0ZnfTZhs5Ni0x72yNfqhyR1Ufv93ouNC5zQsgq1IfUp9HOLJIIjuNSB1?=
 =?us-ascii?Q?mhqlCJL+z5lzLInnyBBCKM18V60ytP9NVHntbfA0PfyU4DGpJqj20c0PTDgy?=
 =?us-ascii?Q?2/RAavMn74vrVIFoU1JzHchqtCM7yrV5/s691m63W4Swxy3OAqnlHtOcihSB?=
 =?us-ascii?Q?UOTsqXmdB2EK5+/Gs0DGVX434e6NBo/H/nyQoYi3Sbju9mb/dEnFKn8MdEYI?=
 =?us-ascii?Q?cMMLgTsWVgMvGC28QczLsv+Ojvem68VLI+0p/XvCSM/ZCNdgqCDWutlbfkRx?=
 =?us-ascii?Q?LSW319H/8ZkQRdY7hcAEy46uc+YPyJTSv8qZILJIQSojOLJ7cNlTLx30+jeB?=
 =?us-ascii?Q?5m0x9bRz403rpHf3W9DNB7IiX9oGU3HW6X0XZnOyt4xOim8JOkMSvIGggpnN?=
 =?us-ascii?Q?dNw1qpblCEeapISusVV5k2IwD5CkmzA3EHUQmnOlpvVMQHJwMMZLRQIK1fhf?=
 =?us-ascii?Q?juQyPiYvseHrqqroZvOF4DUk4f5T9rYi/EtidkJSv3Y4RWrDk83X9IWNR9d2?=
 =?us-ascii?Q?1lH9jHQSEnqs8P+LT3O44xKHTb+0aW3DmWy1Hwt4yA3vj/GQ6hr+ADPuHwOx?=
 =?us-ascii?Q?Q/JSZ9ElNyrQUnTYu1M3U3PkI+qku+7XOVhXcPr/+XwzBmVZZbMBQhWtSpPp?=
 =?us-ascii?Q?jflKgH7o0BvXhDl2AMJFiiCqMIVQThbJvIIwiPbEeWEZcOKMLeR4IkYops72?=
 =?us-ascii?Q?lvrar8vh+vHZ7XbIxjOq8R92ACrp38tFYQ460qasbDPtbYAsATL1X7eKFq7b?=
 =?us-ascii?Q?7CAFuQs+o6QX1ohe3xv7K6vdAjo1TxTlYqNFJ6g/ah8TI3t+tDqRRJJOFWMj?=
 =?us-ascii?Q?N6Vba6uxea57CI6xCvBaiRRN/mTugeFGsMHZ9gaov84te3LJ2R/p6+vn4vv9?=
 =?us-ascii?Q?hADllgClP+xBe7MNiN0HDWI/w0POvtWe7+NzjEFqrvokux30lG/QaankAmRu?=
 =?us-ascii?Q?7Vzigiw2uYfnfbYGwnPvqS4c8Kk7fXgNP2xWRon/Kra2YuL8Kg++o2un5Ly/?=
 =?us-ascii?Q?MSU2BmFosxrXaRCMOYohlwclesP7zolKlIAWmvr1+FokZGJdy4s9LfzMfpB9?=
 =?us-ascii?Q?j3M2nh363g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4b7848b-84d5-4680-41f8-08da284d067f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 12:54:11.4192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bQ0GC7y2xxeJaAiE8HqFfrCccLFLLWtz1zsR1C49X7ztk7FiTTX6IwHfYaLTh9o62NdBX56v+X+wJnHlm/931g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2563
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-04-25 09:11:17, Miaoqian Lin wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1.
>
> Also, we need to call pm_runtime_put_noidle() when pm_runtime_get_sync()
> fails, so use pm_runtime_resume_and_get() instead. this function
> will handle this.
>
> Fixes: 78edeb080330 ("clk: imx: scu: add runtime pm support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

I'm fine with this.

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
> changes in v2:
> - change pm_runtime_get_sync to pm_runtime_resume_and_get
> - current check works fine for pm_runtime_resume_and_get() so stay the
> same.
> Link: https://lore.kernel.org/all/20220412065719.17735-1-linmq006@gmail.com/
> ---
>  drivers/clk/imx/clk-scu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 083da31dc3ea..2044e62980e3 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -528,7 +528,7 @@ static int imx_clk_scu_probe(struct platform_device *pdev)
>  		pm_runtime_use_autosuspend(&pdev->dev);
>  		pm_runtime_enable(dev);
>
> -		ret = pm_runtime_get_sync(dev);
> +		ret = pm_runtime_resume_and_get(dev);
>  		if (ret) {
>  			pm_genpd_remove_device(dev);
>  			pm_runtime_disable(dev);
> --
> 2.17.1
>