Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4591702ioa; Wed, 27 Apr 2022 07:07:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmS+L9DvypRXbfP55aMi1dxX9VZRWEhyCQruKT1jV+jGefiC+Io2rTrj0KkPKqkRnZVyMI X-Received: by 2002:a65:5286:0:b0:398:dad:c3d8 with SMTP id y6-20020a655286000000b003980dadc3d8mr24348771pgp.228.1651068422033; Wed, 27 Apr 2022 07:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651068422; cv=none; d=google.com; s=arc-20160816; b=ulghApySavohsM16ci3ij7dtFmy4gh3jjXF3h37Y/haL/TSxC9kMaHWl2f0KBDId1i ZRjm5lQbuHKXjmpXR2mJ9vOqsznZ7yykrDbBCNyKTlIO2q4o9Ff/WGtsbYS3AxuUG4gI dFLG2SnpslyFJlB/CVC2Fca34TmMi/fVJVrEWwX6ObBCj5AMRKbgzKuiehlXutHcr6VN WxDsbTpYkK0lYfhAsbuU0U58Sdt9Gly0MdwiEOUk+C7M6XsDJGXawC7S5saluA00Ufq5 aSCQLC2otHUsI3anu4QK1zkWebl4eqsVXYn/bD/9/GTELPbvBbGfVlqtuqAHuE1A49ed /f9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=MXFRRtg7IDTv2aR5vgjoqgln0V1RZDsx2lOr0tFcH0E=; b=c3I+K4O+NfORGfWKRuoDfQkwB905MwuukzE/rSQgAtKoMCCHcByyGouMtCjpqm6v6O J1OfaEtc30bN+WqkYlVCEOjEY6Qvk7GUyUR+1HIPJ3PfJZtvMUYRiFZkFFuCNYXqocjL zc5SXEQjWsZrpLYnEyBtivz9+LhsVR/pHCptJkNT424sArOR03tK+XTQ0fJ9fL/zbPHo L+LY40eXJsrxZqeVB0llenLVKBfxriZ0ZrOJZcxPq7CyP2rf1apsF6ISYSHbD9zF43KA 6BGQsNHddXaVxN5B850nirXEQmfBWm3Jp7Gy6+egZalVhpUUFbI7HvD6Lu3j9n6s8D3m 2yEw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id oo12-20020a17090b1c8c00b001ca8db710bcsi6050137pjb.179.2022.04.27.07.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 07:07:02 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E6D884C782; Wed, 27 Apr 2022 06:36:40 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236391AbiD0Njq (ORCPT + 99 others); Wed, 27 Apr 2022 09:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236491AbiD0Njc (ORCPT ); Wed, 27 Apr 2022 09:39:32 -0400 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C134B43A; Wed, 27 Apr 2022 06:36:20 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:46958) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1njhq4-00BNMo-N6; Wed, 27 Apr 2022 07:36:16 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:35834 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1njhq3-008HKf-Lv; Wed, 27 Apr 2022 07:36:16 -0600 From: "Eric W. Biederman" To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, Oleg Nesterov , mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , inux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn References: <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <20220426225211.308418-5-ebiederm@xmission.com> Date: Wed, 27 Apr 2022 08:35:47 -0500 In-Reply-To: (Sebastian Andrzej Siewior's message of "Wed, 27 Apr 2022 08:40:09 +0200") Message-ID: <87tuaebqdo.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1njhq3-008HKf-Lv;;;mid=<87tuaebqdo.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX186AxdiWfPFH1v/oamRbqPMj7VzLJuq57s= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Virus: No X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *****;Sebastian Andrzej Siewior X-Spam-Relay-Country: X-Spam-Timing: total 325 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 3.7 (1.1%), b_tie_ro: 2.6 (0.8%), parse: 0.96 (0.3%), extract_message_metadata: 15 (4.6%), get_uri_detail_list: 0.91 (0.3%), tests_pri_-1000: 23 (7.1%), tests_pri_-950: 1.40 (0.4%), tests_pri_-900: 1.22 (0.4%), tests_pri_-90: 75 (23.1%), check_bayes: 73 (22.6%), b_tokenize: 8 (2.4%), b_tok_get_all: 6 (1.8%), b_comp_prob: 1.93 (0.6%), b_tok_touch_all: 55 (17.0%), b_finish: 0.69 (0.2%), tests_pri_0: 194 (59.5%), check_dkim_signature: 0.37 (0.1%), check_dkim_adsp: 1.91 (0.6%), poll_dns_idle: 0.51 (0.2%), tests_pri_10: 1.77 (0.5%), tests_pri_500: 6 (2.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 5/9] signal: Protect parent child relationships by childs siglock X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian Andrzej Siewior writes: > On 2022-04-26 17:52:07 [-0500], Eric W. Biederman wrote: >> The functions ptrace_stop and do_signal_stop have to drop siglock >> and grab tasklist_lock because the parent/child relation ship >> is guarded by siglock and not siglock. > > "is guarded by tasklist_lock and not siglock." ? Yes. Thank you. I will fix that. >> Simplify things by guarding the parent/child relationship >> with siglock. For the most part this just requires a little bit >> of code motion. In a couple of places more locking was needed. >> >> >> Signed-off-by: "Eric W. Biederman" > > Sebastian Eric