Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d43d7e40-40d7-a89e-115f-04a305d7239b@linaro.org>
Date:   Wed, 27 Apr 2022 15:49:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] dt-bindings: mfd: wlf,arizona: Add spi-max-frequency
Content-Language: en-US
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        - <patches@opensource.cirrus.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
References: <20220427065102.109046-1-krzysztof.kozlowski@linaro.org>
 <20220427122143.GB38351@ediswmail.ad.cirrus.com>
 <20220427125801.GC38351@ediswmail.ad.cirrus.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220427125801.GC38351@ediswmail.ad.cirrus.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/04/2022 14:58, Charles Keepax wrote:
> On Wed, Apr 27, 2022 at 12:21:43PM +0000, Charles Keepax wrote:
>> On Wed, Apr 27, 2022 at 08:51:02AM +0200, Krzysztof Kozlowski wrote:
>>> The Wolfson Microelectronics Arizona audio can be connected via SPI bus
>>> (e.g. WM5110 on Exynos5433 TM2 board), so allow spi-max-frequency
>>> property.
>>>
>>> Reported-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>
>> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>>
> 
> Apologies but looking at this again I can't quite see why this is
> necessary. The Arizona schema should allow properties that arn't
> specified. Do you have an example of what failed to warrant this?

The Arizona schema has unevaluatedProperties: false, which means unknown
properties will not be accepted. Neither Arizona schema nor other
referenced schemas define spi-max-frequency, so when the schema is run,
the property will be unevaluated, thus cause a warning.

This is visible here at the bottom (with Rob's work-in-progress):
https://lore.kernel.org/linux-devicetree/345716e9-5624-5ba0-09f0-46e9850c546c@linaro.org/T/#m4b5d7cfdf34dbd410003b2faae4d840113050c51

Although I think that I did not fix it properly, because I missed
'controller-data', so instead this should be fixed with referencing
spi-peripheral-props like here:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.17.y&id=f412fe11c1a9d815565f3918c56f3fd02167c734


Best regards,
Krzysztof