Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220426064001.14241-1-jvgediya@linux.ibm.com>
 <YmfzJVPng1U8X+jV@smile.fi.intel.com> <Ymf/yyPLGErQji06@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com>
In-Reply-To: <Ymf/yyPLGErQji06@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 27 Apr 2022 15:50:49 +0200
Message-ID: <CAHp75VeAVFNA7faZjsHOyAM2ZKU=xWTVZDKiPwY2woKW712Qpw@mail.gmail.com>
Subject: Re: [PATCH v2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool
To:     Jagdish Gediya <jvgediya@linux.ibm.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>, ying.huang@intel.com,
        Dave Hansen <dave.hansen@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Petr Mladek <pmladek@suse.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 26, 2022 at 8:49 PM Jagdish Gediya <jvgediya@linux.ibm.com> wrote:
> On Tue, Apr 26, 2022 at 04:27:01PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 26, 2022 at 12:10:01PM +0530, Jagdish Gediya wrote:

> > > At many places in kernel, It is necessary to convert sysfs input
> > > to corrosponding bool value e.g. "false" or "0" need to be converted

corresponding

> > > to bool false, "true" or "1" need to be converted to bool true,
> > > places where such conversion is needed currently check the input
> > > string manually, kstrtobool can be utilized at such places but
> >
> > kstrtobool()
> >
> > > currently kstrtobool doesn't have support to "false"/"true".
> >
> >
> > Ditto.
> >
> > > Add "false"/"true" support to kstrtobool while string conversion
> >
> > Ditto.
> >
> > > to bool. Modify existing manual sysfs conversions to use kstrtobool().

...

> > Also Documentation update is missed.
> I am not finding any related documentation. I can update
> the comment on the function for true/false change.

Yes, please.

-- 
With Best Regards,
Andy Shevchenko