Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <c959d3ea-1187-3e88-287b-27e75f0225e8@amd.com>
Date:   Wed, 27 Apr 2022 09:09:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] virtio: replace
 arch_has_restricted_virtio_memory_access()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-hyperv@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        Arnd Bergmann <arnd@arndb.de>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20220426134021.11210-1-jgross@suse.com>
 <20220426134021.11210-3-jgross@suse.com> <Ymgtb2dSNYz7DBqx@zn.tnic>
 <1c1a4a7d-a273-c3b0-3683-195f6e09a027@suse.com> <Ymk2/N/DdAyxQnV0@zn.tnic>
 <2a340424-29e6-8ad8-0181-f70450eecb80@suse.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <2a340424-29e6-8ad8-0181-f70450eecb80@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NldiV3E1QkdtdzcwNzdsT0ljekxkeE4wcTRyZEZFQURzL0xzbmkvSzE1ME8x?=
 =?utf-8?B?NmErR3dQblYrYWd4bThWeWlTRS8yZUlNd3RJNGRhZFhmVnVjYTh3SVpCVm5h?=
 =?utf-8?B?N0M1TkFhS3NFSUNzc1NOUjdYdmNMWFVhcmxBRDIrTHdDTVpaVytmYVpvQVhk?=
 =?utf-8?B?NVdRWTBqOTVwSmF2N2pBcm1PNHdJdHRna3p5NjBqVWZVYWxHa1VxOU51enkv?=
 =?utf-8?B?NmVjVzZabHVpUFMvQ3laRzg5WFpleDRCZjloaVBZS3RWZXVnVmZLTUN3bDJV?=
 =?utf-8?B?d1NNV1Fnd1VydFBGUStHQmE1UDF5aktRMGVuQWR1bmdxQ1pmOHRKcVgxYVoz?=
 =?utf-8?B?VWZSYVNwdGtpK2RhQXZjSHV0QThjMnhHcDN0eUk2RFRGeisyaG5lb3JZQldO?=
 =?utf-8?B?eVdKSkhWdFlZMU16TmM5Q3lqQmJ0SE8xbHVPazc1aWM2WWNhazRxNzNkY0V2?=
 =?utf-8?B?ejFlYm5SNE1uZTYrR2NvK1dERFB5a2hUZFZnTU56Ry93MUNBWnZ0bDczV2Yv?=
 =?utf-8?B?NHJDN2J1SXV4ZXJLT3lIdnhUZHYyV01jbzlaZXIrTUtFbStyWUZhYmYvWUsz?=
 =?utf-8?B?WHdjV093U2gzWVUwQm45VStrWHQ2SVltbnZDbGYyU0NjNVNxZEY0MmhrVXQy?=
 =?utf-8?B?bWViUVNyWDhzRU4yRTl6TXVEVXh5b3VabXB5cFcwSm5NRzY0aFZlWmczRVpn?=
 =?utf-8?B?elVRNWpnaGw2THBPSzZLWlFYUGZnS0hHTHFHWGYyYXlDQTU1cDFibW00aVJh?=
 =?utf-8?B?L1VBTkNWTUtPc1pqYnZJWGM2akV3c3hTRXNkVG84em1iVFIvTjFZMEdMdjB0?=
 =?utf-8?B?SlJBOTlwUzBIS3Y3a2YyNUZ0NWVhRWFSN1ZPY1BiVmpja1dnM0pTWXpNK3dC?=
 =?utf-8?B?dkErR1UwSGdwWG1lVVJIQmFGZHg2YUpsNFJpaGlBak80MEROVHZGTHJLWUxD?=
 =?utf-8?B?c3I2OWVwTVdkSXBoVFhJbHRNQWtUdTVubyt2Y2dkOUM5dGVMWFJXeTFtMkRY?=
 =?utf-8?B?RXpVVnN0OGNlSmJWSGNaYmlqNUpBaEgweG1mQVd0SkdjVE1udysvc3NUMk1E?=
 =?utf-8?B?czllVkJGblNDdnhsbmFsV2NDaytFS1NoZ0QzVHpucHd0YUV1Z3FtdTJxbnJv?=
 =?utf-8?B?MStBTEZndzJ5MWtDSFNQM1prdzZaeUx6SzRwZlRuQithOHVXNHlTUFFtSXFh?=
 =?utf-8?B?a3lwa2tQZGsycElQMGl5L25hOFQvRVBJOGR4ZS9MMzNuWS9xUEg2QWFuSkdW?=
 =?utf-8?B?cFdreHRZZStsZmk5cmxmalJaenhCK01tZFpETldWOXdYbThESXFEdWR0YVV5?=
 =?utf-8?B?Tm9Na3hXK1RwczRnYnhPdlJWQjNVTlhMdWlsaUlkS2xoVW53U3RMQTBIenhl?=
 =?utf-8?B?dS9UWTJidGkvYXVrdzI4WUF6b0FkaElyWG51Q2liMkI5aXJhMnNLblJPenVs?=
 =?utf-8?B?ZjdrajdKajB1aVpjc1ZtYmNmOTg4VGdUUUlFSS9LL0szN3VEUkVzTnB6MUZY?=
 =?utf-8?B?VGpDOWFQeWd1elBqMXMrTzQ1SFh0NnNvMDdJZnJTeHBNbVNMVEprQnRsMmxT?=
 =?utf-8?B?T2tiSVZrSmxWQkFncVBDR3dDTEsyUk1sdmhFQ2s3MWlRb2dBMlFsS2Z2MGN4?=
 =?utf-8?B?RFNubFpkVzJtMlZKaWtjRmF6bWdCbHQyMXJwVnRhQmxrR1lZN2FwR2xzeGR4?=
 =?utf-8?B?S1VxKzhaeE5OQ1VNZnZ3T04wbGVQcDZldU1wZWR0KzZ5dDdQTmNubnY2aEJX?=
 =?utf-8?B?RDY0TnVLTmIrVjdKTEdPRkVVc0FtSGVRc3Mvb1BUL1phUk5uYjRnTFM5NnMz?=
 =?utf-8?B?V0JwVWFpSjBOMVkxYitwSnFUeXJPaHN4cVBHUFJsZXQ1MGcyZHZYUU1CSFN0?=
 =?utf-8?B?VUFYdE1la295WUoxNE9TakhzNGdmYjFHMFpVMnRRTXJXUG8yN0ZwdlU4RTIy?=
 =?utf-8?B?ZUpHbk1KZWdHMjN5ekNOV3VzR3NCbmZiVElRTlg3NWFpZjJIbThLLzFwUkdl?=
 =?utf-8?B?QndUMWdkTFhNaTdZQUt2NzB3SnNLOEcwUGpCZmxma0NIM1ZPVnNhV052bStC?=
 =?utf-8?B?L05scnRmL3RQajFqUHo1OGdEN3BMSzRhbS9hL2d4bzA4TXpLdk0wankvaDFN?=
 =?utf-8?B?OHd2bFJGMFFweUsvNDJoZWYzZ2FMTzFQMWMraGgvWW8rRkJodlU4cWw2M2M0?=
 =?utf-8?B?UklYRm56Z2ovMW9FSi9qT0FSSndsdWNPSFcxVWlUZWNDdnkrdWhFUTI0akVn?=
 =?utf-8?B?dmpsUEVwbnI4MXd2WTVveHIyNVg0a1RGSzhtbVlqVitiVE5EckY1SDhlcUN1?=
 =?utf-8?B?bUwzNlU3NGR0WG0raDhFQ2JucHdDYUdaSE03bmwvYzBHWlQya3JsUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76156ede-2110-476c-088f-08da28579cd2
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 14:09:58.6979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n1f2EgLdqJKQXQxH9kLGyqHC1IIoBdf7fcvVZRnIGHk3pYJ94mwD75Rx7z1yz8VsSgrDIJoRdtzmeWXbTcBV+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3118
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/27/22 07:37, Juergen Gross wrote:
> On 27.04.22 14:28, Borislav Petkov wrote:
>> On Wed, Apr 27, 2022 at 08:37:31AM +0200, Juergen Gross wrote:
>>> On 26.04.22 19:35, Borislav Petkov wrote:
>>>> On Tue, Apr 26, 2022 at 03:40:21PM +0200, Juergen Gross wrote:
>>>>>    /* protected virtualization */
>>>>>    static void pv_init(void)
>>>>>    {
>>>>>        if (!is_prot_virt_guest())
>>>>>            return;
>>>>> +    platform_set_feature(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS);
>>>>
>>>> Kinda long-ish for my taste. I'll probably call it:
>>>>
>>>>     platform_set()
>>>>
>>>> as it is implicit that it sets a feature bit.
>>>
>>> Okay, fine with me.
>>>
>>>>
>>>>> diff --git a/arch/x86/mm/mem_encrypt_identity.c 
>>>>> b/arch/x86/mm/mem_encrypt_identity.c
>>>>> index b43bc24d2bb6..6043ba6cd17d 100644
>>>>> --- a/arch/x86/mm/mem_encrypt_identity.c
>>>>> +++ b/arch/x86/mm/mem_encrypt_identity.c
>>>>> @@ -40,6 +40,7 @@
>>>>>    #include <linux/mm.h>
>>>>>    #include <linux/mem_encrypt.h>
>>>>>    #include <linux/cc_platform.h>
>>>>> +#include <linux/platform-feature.h>
>>>>>    #include <asm/setup.h>
>>>>>    #include <asm/sections.h>
>>>>> @@ -566,6 +567,10 @@ void __init sme_enable(struct boot_params *bp)
>>>>>        } else {
>>>>>            /* SEV state cannot be controlled by a command line option */
>>>>>            sme_me_mask = me_mask;
>>>>> +
>>>>> +        /* Set restricted memory access for virtio. */
>>>>> +        platform_set_feature(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS);

This is way early in the boot, but it appears that marking the platform 
feature bitmap as __read_mostly puts this in the .data section, so avoids 
the issue of bss being cleared.

TDX support also uses the arch_has_restricted_virtio_memory_access() 
function and will need to be updated.

Seems like a lot of changes, I just wonder if the the arch_has...() 
function couldn't be updated to also include a Xen check?

Thanks,
Tom

>>>>
>>>> Huh, what does that have to do with SME?
>>>
>>> I picked the function where sev_status is being set, as this seemed to be
>>> the correct place to set the feature bit.
>>
>> What I don't understand is what does restricted memory access have to do
>> with AMD SEV and how does play together with what you guys are trying to
>> do?
>>
>> The big picture pls.
> 
> Ah, okay.
> 
> For support of virtio with Xen we want to not only support the virtio
> devices like KVM, but use grants for letting the guest decide which
> pages are allowed to be mapped by the backend (dom0).
> 
> Instead of physical guest addresses the guest will use grant-ids (plus
> offset). In order to be able to handle this at the basic virtio level
> instead of the single virtio device drivers, we need to use dedicated
> dma-ops. And those will be used by virtio only, if the "restricted
> virtio memory request" flag is set, which is used by SEV, too. In order
> to let virtio set this flag, we need a way to communicate to virtio
> that the running system is either a SEV guest or a Xen guest.
> 
> HTH,
> 
> 
> Juergen