Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 27 Apr 2022 17:22:33 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc:     ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
        mchehab@kernel.org, gregkh@linuxfoundation.org,
        linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        jon@nanocrew.net, aford173@gmail.com, kernel@collabora.com
Subject: Re: [PATCH] media: hantro: HEVC: Fix tile info buffer value
 computation
Message-ID: <20220427142233.GS2462@kadam>
References: <20220427135517.381959-1-benjamin.gaignard@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220427135517.381959-1-benjamin.gaignard@collabora.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K5O3G8xebOW+ZAhYkttIZLegeN3/a1tzvOyl3V7jt99SCPVDB7zxJvAYs/7H?=
 =?us-ascii?Q?1KkMizWKx3fGyB2BHubD5Jr5pGenWgRx1qXwHzsVq1OuPW3H55oXWFADpdLp?=
 =?us-ascii?Q?SsPJR8zNedWR7PnHAJv3/1iMjDVFi4clqyojNaNE1NBjMNQE6AeH0mU03lmV?=
 =?us-ascii?Q?ESjfEAgFHgtIZnHMm0PR003/a1kLxs3NWJzJmc0lmwddcLaqKZbocsAdVUZe?=
 =?us-ascii?Q?ba6GwhOwqC9PMmvOAZMwZaqyPa3WH2gvn2s4i5EKsKdw7GovlukGERX0WfEL?=
 =?us-ascii?Q?JRIXPBEDGfp9luQrviP26m0/c47YmSF+QcOyNZOzQ9gc7pkuI0WY+gIrYNZQ?=
 =?us-ascii?Q?S/7168wUWMQZthUevMq+KYyB/IKbT5jp1mBr9G/BhzlfHku1c7yg9kndRAA5?=
 =?us-ascii?Q?nU5fROLeEfiaaS5jWhaB06TvFIHinfMUOIGJfe0Pa9VUMe8OKjDgrxisAqfn?=
 =?us-ascii?Q?Jg1l6tt99X6RFNAtUL6LNJcyxx3Xuwq+x8z5ZFUkRbe8Ij3peOeitC8in9M3?=
 =?us-ascii?Q?6uwmiET6lRFxi7asOJatENsqcWsT6LDZ9rvi2thVvo8GnxgQWTS78BKG8A4q?=
 =?us-ascii?Q?dtZwbYoP7dHLwifqe81dmxDnwu+TdG71gJkl/YiNVEgjz8R5U1HgR4yWdKnu?=
 =?us-ascii?Q?p5jq6EgOtY2Eqq1lSa27lA/8gEcXmwXww6NxKgeinarrlljDoEXoSDwXAR2+?=
 =?us-ascii?Q?mUMz0fKiMLJFS9rOhUUmMMbGsMGMZB5NtSsBnezBqE6S6X0aorGRm9G1id2u?=
 =?us-ascii?Q?3I3J3AqGvhfXgKurfTGdb09mNqjyBPUzX9ugmS7pr+caPEzM418UprKsuw4G?=
 =?us-ascii?Q?x4kATBJf1WSDmnKHsEM+CMHK4DPECcTpHdkxerPWBdZKLjY9YVvWjABE2iGu?=
 =?us-ascii?Q?m21GQlc4IFuc1AHh4l3pJvZMUzZVMCUxSH/SnKaQGGx0+UoQ3nRdaDyRVd6l?=
 =?us-ascii?Q?yBzs+AbLDXPjbISFGYKDMr0JERJneL7dkQwMMCtT2BRUZbRR8+/3lLUXz5hO?=
 =?us-ascii?Q?byrFM0U65ekGchTxw4pnYq0dEMPUJkz/FieXbcqYixd+GJgTPqIUYVjeUY8G?=
 =?us-ascii?Q?EdN+GciX2OyP15pQKeXPlAjMK9J3+rSA6ggsbaT0AW2Fn/Kr2+YXaXbsJNM5?=
 =?us-ascii?Q?493Enu0mUCaBM3Cs75ZLmM4M/JAR7k4mmq5hMjImkOu5D9GkRDU4OrfPecE/?=
 =?us-ascii?Q?LHeJhJ6YR/ttTIh9Dq98T9c2cEppB+oYdCQQLmCI+sWqFYeIJ6Wt1AT2DbxD?=
 =?us-ascii?Q?Rjqx2DEsLkhtdU5fJ5ut16u6BkJx5Q+Erq0n/Ex0yuFaofKhoIF06sdWjpxH?=
 =?us-ascii?Q?X46NkwOoUpMvGDnza8cvCYT8magLEZ7QwNEMoA5ewsci+xAe1pUYRajY1yHj?=
 =?us-ascii?Q?g74TMoC6Idj9RQicZXBrLYxWSxrnLSWd98J6CJL+Bnh+fkZiXJceVnKKmyCC?=
 =?us-ascii?Q?DzPw1eYcCW6F3/k1mzVeOQnLXkmyFAKQqki8ci9g3SI4OFswiUymkA+jwRaH?=
 =?us-ascii?Q?bPJTyicCERMVyZjl4HoTzgEC5ZAH/VX1AD6eYdv/bf0iIepBwoYfTrd+M0+U?=
 =?us-ascii?Q?r0pwlr4fEwO6i6WBQwY6ZFAhDeoSWq2Kmz2V5xSZQAgmKe4W5vYwiTvtnKOQ?=
 =?us-ascii?Q?ylQKp8cmSCCgldRi7SF0QP6jFsg9aOzEJP+EpuVa9QAQRNiV8ZxhBoS9IVOR?=
 =?us-ascii?Q?1MM+UD1ujZiCbc9iGslr3fj0UcIq0dE3ZvpdLMZax+pDa7mtF88nQ7fReRU2?=
 =?us-ascii?Q?kv2ng+j21D/ZuFreUi4WjvhNgyvyfqk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9d5161c-ebfd-4a49-95e0-08da28596f7a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 14:23:01.8070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 54JWItqz+UJ3Qk1IxuOzS8C/kvJqx0a3V6qD1diI+mrf6QiysKj6EKCbfhUFvTRlQPIPspveBXS/m2fNpWis2xMFDkzobS2Lpd+JdKLaIUQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4261
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-27_04:2022-04-27,2022-04-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204270091
X-Proofpoint-ORIG-GUID: U502A2r24-nDw4OiNrAophMYVsUBcRHH
X-Proofpoint-GUID: U502A2r24-nDw4OiNrAophMYVsUBcRHH
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 27, 2022 at 03:55:17PM +0200, Benjamin Gaignard wrote:
> Use pps->column_width_minus1[j] + 1 as value for the tile info buffer
> instead of pps->column_width_minus1[j + 1].
> The patch fix DBLK_E_VIXS_2, DBLK_F_VIXS_2, DBLK_G_VIXS_2,
> SAO_B_MediaTek_5, TILES_A_Cisco_2 and TILES_B_Cisco_1 tests in fluster.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Fixes: cb5dd5a0fa51 ("media: hantro: Introduce G2/HEVC decoder")

> ---
>  drivers/staging/media/hantro/hantro_g2_hevc_dec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
> index bb512389c1a5..ffeb2fbeefd2 100644
> --- a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
> +++ b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
> @@ -74,7 +74,7 @@ static void prepare_tile_info_buffer(struct hantro_ctx *ctx)
>  					no_chroma = 1;
>  				for (j = 0, tmp_w = 0; j < num_tile_cols - 1; j++) {
                                                                        ^^^^
Is this "- 1" still required?  I would have assumed the "- 1" here was
connected with the [j + 1].  What is stored in the last element of the
->column_width_minus1 array?

>  					tmp_w += pps->column_width_minus1[j] + 1;
> -					*p++ = pps->column_width_minus1[j + 1];
                                                                        ^^^^^

> +					*p++ = pps->column_width_minus1[j] + 1;
>  					*p++ = h;
>  					if (i == 0 && h == 1 && ctb_size == 16)
>  						no_chroma = 1;

regards,
dan carpenter