Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220426235718.1634359-1-marmarek@invisiblethingslab.com>
In-Reply-To: <20220426235718.1634359-1-marmarek@invisiblethingslab.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 27 Apr 2022 10:47:36 -0400
Message-ID: <CADnq5_Pbaz9omsd6sHmOzTM=7c9fNBa5PAUfW4GOT=rtT4Anjg@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: do not use passthrough mode in Xen dom0
To:     =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Lijo Lazar <lijo.lazar@amd.com>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Guchun Chen <guchun.chen@amd.com>,
        David Airlie <airlied@linux.ie>,
        Bokun Zhang <bokun.zhang@amd.com>,
        Jingwen Chen <Jingwen.Chen2@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        "for 3.8" <stable@vger.kernel.org>,
        Victor Skvortsov <victor.skvortsov@amd.com>,
        =?UTF-8?Q?Michel_D=C3=A4nzer?= <mdaenzer@redhat.com>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>, Bernard Zhao <bernard@vivo.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Candice Li <candice.li@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Hawking Zhang <Hawking.Zhang@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Apr 27, 2022 at 3:12 AM Marek Marczykowski-G=C3=B3recki
<marmarek@invisiblethingslab.com> wrote:
>
> While technically Xen dom0 is a virtual machine too, it does have
> access to most of the hardware so it doesn't need to be considered a
> "passthrough". Commit b818a5d37454 ("drm/amdgpu/gmc: use PCI BARs for
> APUs in passthrough") changed how FB is accessed based on passthrough
> mode. This breaks amdgpu in Xen dom0 with message like this:
>
>     [drm:dc_dmub_srv_wait_idle [amdgpu]] *ERROR* Error waiting for DMUB i=
dle: status=3D3
>
> While the reason for this failure is unclear, the passthrough mode is
> not really necessary in Xen dom0 anyway. So, to unbreak booting affected
> kernels, disable passthrough mode in this case.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1985
> Fixes: b818a5d37454 ("drm/amdgpu/gmc: use PCI BARs for APUs in passthroug=
h")
> Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingsl=
ab.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/a=
md/amdgpu/amdgpu_virt.c
> index a025f080aa6a..5e3756643da3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -24,6 +24,7 @@
>  #include <linux/module.h>
>
>  #include <drm/drm_drv.h>
> +#include <xen/xen.h>
>
>  #include "amdgpu.h"
>  #include "amdgpu_ras.h"
> @@ -710,7 +711,8 @@ void amdgpu_detect_virtualization(struct amdgpu_devic=
e *adev)
>                 adev->virt.caps |=3D AMDGPU_SRIOV_CAPS_ENABLE_IOV;
>
>         if (!reg) {
> -               if (is_virtual_machine())       /* passthrough mode exclu=
s sriov mod */
> +               /* passthrough mode exclus sriov mod */
> +               if (is_virtual_machine() && !xen_initial_domain())
>                         adev->virt.caps |=3D AMDGPU_PASSTHROUGH_MODE;
>         }
>
> --
> 2.35.1
>