Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 27 Apr 2022 08:01:39 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Chris Mason <clm@fb.com>
Cc:     Christoph Bartoschek <bartoschek@google.com>,
        Giuseppe Scrivano <gscrivan@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "riel@surriel.com" <riel@surriel.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RFC fs/namespace] Make kern_unmount() use
 synchronize_rcu_expedited()
Message-ID: <20220427150139.GO4285@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <8E281DF1-248F-4861-A3C0-2573A5EFEE61@fb.com>
 <20220426065917.3123488-1-bartoschek@google.com>
 <20220426140919.GD4285@paulmck-ThinkPad-P17-Gen-1>
 <CAAQBG5jnvSxcjwr+L5nuxwh87bv=D=tzU325W2Zp3DVpn-VmcQ@mail.gmail.com>
 <20220426231100.GL4285@paulmck-ThinkPad-P17-Gen-1>
 <2A61C695-450E-499B-BCFA-411A36008D72@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2A61C695-450E-499B-BCFA-411A36008D72@fb.com>
Precedence: bulk

On Wed, Apr 27, 2022 at 12:19:56PM +0000, Chris Mason wrote:
> 
> > On Apr 26, 2022, at 7:11 PM, Paul E. McKenney <paulmck@kernel.org> wrote:
> > 
> > On Wed, Apr 27, 2022 at 12:58:34AM +0200, Christoph Bartoschek wrote:
> >>> 3. https://lore.kernel.org/lkml/20220218183114.2867528-1-riel@surriel.com/
> >>> Refined queue_rcu_work() approach.
> >>> 
> >>> #1 should work, but the resulting IPIs are not going to make the real-time
> >>> guys happy. #2 and #3 have been subject to reasonably heavy testing
> >>> and did fix a very similar issue to the one that you are reporting,
> >>> but last I knew there were doubts about the concurrency consequences.
> >>> 
> >>> Could you please give at least #3 a shot and see if it helps you?
> >> 
> >> I have tried #3 and it works well with my testcases as far as I can see it.
> > 
> > Thank you for giving it a try!
> > 
> > Al, are further adjustments needed to make this patch cover all the
> > corner cases?
> 
> Did we end up addressing all of Al’s comments here?
> 
> https://lore.kernel.org/lkml/YhCFKyVMtOSyBDJh@zeniv-ca.linux.org.uk/

Indeed we have not!  Thank you for the reminder, and I will get with
Rik to look into this.

							Thanx, Paul