Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d802f305-90d6-decf-c7ad-547d3c8a80da@ti.com>
Date:   Wed, 27 Apr 2022 20:54:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-mcu: Enable MCU GPIO module
Content-Language: en-US
To:     Aswath Govindraju <a-govindraju@ti.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>
References: <20220421061938.122317-1-vigneshr@ti.com>
 <96894353-2b4e-52a7-bd48-c65eb674d6f5@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <96894353-2b4e-52a7-bd48-c65eb674d6f5@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27/04/22 4:36 pm, Aswath Govindraju wrote:
> On 21/04/22 11:49, Vignesh Raghavendra wrote:
>> AM62 has x1 GPIO module and associated interrupt router in MCU Domain.
>> Add DT nodes for the same.
>>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 28 +++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
>> index d103824c963f..45343381ad0b 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
>> @@ -53,4 +53,32 @@ mcu_spi1: spi@4b10000 {
>>  		power-domains = <&k3_pds 148 TI_SCI_PD_EXCLUSIVE>;
>>  		clocks = <&k3_clks 148 0>;
>>  	};
>> +
>> +	mcu_gpio_intr: interrupt-controller@4210000 {
>> +		compatible = "ti,sci-intr";
>> +		reg = <0x00 0x04210000 0x00 0x200>;
>> +		ti,intr-trigger-type = <1>;
>> +		interrupt-controller;
>> +		interrupt-parent = <&gic500>;
>> +		#interrupt-cells = <1>;
>> +		ti,sci = <&dmsc>;
>> +		ti,sci-dev-id = <5>;
>> +		ti,interrupt-ranges = <0 104 4>;
>> +	};
>> +
>> +	mcu_gpio0: gpio@4201000 {
>> +		compatible = "ti,am64-gpio", "ti,keystone-gpio";
>> +		reg = <0x0 0x4201000 0x0 0x100>;
> 
> nitpick: reg = <0x00 0x04201000 0x00 0x100>;

Ah, yes.. Will fix locally before merging.

> 
>> +		gpio-controller;
>> +		#gpio-cells = <2>;
>> +		interrupt-parent = <&mcu_gpio_intr>;
>> +		interrupts = <30>, <31>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +		ti,ngpio = <24>;
>> +		ti,davinci-gpio-unbanked = <0>;
>> +		power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
>> +		clocks = <&k3_clks 79 0>;
>> +		clock-names = "gpio";
>> +	};
>>  };
> 
> 
> Aside from the above minor change,
> 
> Reviewed-by: Aswath Govindraju <a-govindraju@ti.com>
> 

Thanks!

Regards
Vignesh