Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <cover.1650568579.git.jhpark1013@gmail.com> <bba338ae5f9992dbf2a64b388f7702e6b287d8c2.1650568579.git.jhpark1013@gmail.com>
 <YmK/o23YIeXwKlep@kroah.com>
In-Reply-To: <YmK/o23YIeXwKlep@kroah.com>
From:   Jaehee <jhpark1013@gmail.com>
Date:   Wed, 27 Apr 2022 11:37:19 -0400
Message-ID: <CAA1TwFDMpNuWjKDBW2L0q31FHHUcQ8RyrYBpVDAOmQCHV+qxTw@mail.gmail.com>
Subject: Re: [PATCH v4 7/7] staging: r8188eu: remove unused else condition
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Outreachy Linux Kernel <outreachy@lists.linux.dev>,
        Pavel Skripkin <paskripkin@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 22, 2022 at 10:45 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Apr 21, 2022 at 03:20:32PM -0400, Jaehee Park wrote:
> > s_ret cannot return '2' so this else condition is unused. Remove this
> > unnecessary else statement.
>
> s_ret is not a function, it is a value.
> rtw_select_and_join_from_scanned_queue() is the function here.
>
> Can you fix up the wording in this changelog text and resubmit?
>
> thanks,
>
> greg k-h

Sorry about the delay! I've sent the revised patch just now.
Thanks,
Jaehee