Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <05d21d85-7b59-a8f9-73dc-89189986db11@fb.com>
Date:   Wed, 27 Apr 2022 08:54:53 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH bpf-next 08/11] samples: bpf: fix shifting unsigned long
 by 32 positions
Content-Language: en-US
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Alexander Lobakin <alobakin@pm.me>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Dmitrii Dolgov <9erthalion6@gmail.com>,
        Quentin Monnet <quentin@isovalent.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Chenbo Feng <fengc@google.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniel Wagner <daniel.wagner@bmw-carit.de>,
        Thomas Graf <tgraf@suug.ch>,
        Ong Boon Leong <boon.leong.ong@intel.com>,
        "linux-perf-use." <linux-perf-users@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        llvm@lists.linux.dev
References: <20220414223704.341028-1-alobakin@pm.me>
 <20220414223704.341028-9-alobakin@pm.me>
 <CAEf4BzZVohaHdCTz_KFVdEus2pndLTZvg=BHfujpgt29qbio3Q@mail.gmail.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <CAEf4BzZVohaHdCTz_KFVdEus2pndLTZvg=BHfujpgt29qbio3Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmpkcnB3VzRFWWEwaDNuWGp5TmtLQVgzTmovbytkM1Z1L3lPYWwvZjVmSS9Q?=
 =?utf-8?B?WDZPRElaNTFnbmVsSXg4c1NVMHpRTWQybElzTWdUOEM1bGM0YW1xczd0QXdW?=
 =?utf-8?B?V2dndnFkK1gzSnlSbkxqbFdqNjNBcHBFZHJKL0ZZdG9vRTdKa3NRZjFTaTJY?=
 =?utf-8?B?M25iRWRWZ3dRd1ZRYUQ3b2JMdk1DbGI5UDZadVBYWkhnVTlEa2FjTVZ0U3BR?=
 =?utf-8?B?R3F2TFlsQXFTUDZlTzE1bFdNb0lwZGFMZm0rM0xodWs5TExHQmlDeGM3SVds?=
 =?utf-8?B?UFZjWkwrc1YzNmRrUXgrRmJ0RTNkWUVYRGs0dmpMSS9xM1dJVmN5N3AvMy95?=
 =?utf-8?B?SnA0d3VKMmxveGhJVWJvUm05dkhkSDlpM05KWlBvTDJBRUwrWGlvZXBjQ2pL?=
 =?utf-8?B?UVluWTBFUVROcmVEZVJhdlErWVNnTUp6eW5qOEZXNG5hKzJCdHFaN3c3Ymhl?=
 =?utf-8?B?eVVmZW9HQjRjcGg2WjU5cGRRQkozNTFNZER6NFJ6TjBRb2pLQmFMd1RKSS8v?=
 =?utf-8?B?UmpOYjdRRnNpMTBVK3Uwc3BRWVVlSmIxUWVXUUJxOEwzUDZ4bSt6MjkzS3Fl?=
 =?utf-8?B?R3VEd0trazNyMlhwSUsyQUt5V2FxR1lvV3dVazNBTGpjOW5FYnBHNkdHNGdD?=
 =?utf-8?B?N2FEdUl4ckcwQ2l1eFFKOHdSMXdla0ZKZ1VBKzlOZjRZYndsUk14dFprK2s1?=
 =?utf-8?B?Z2ZEYlRTSGtaZ3JtSFRKakxINlVhN2NhVllhbTV0dzdSNTdoZ0cyR0JCWHFy?=
 =?utf-8?B?Z0RlVHlIbVJ1YmNaUVd0VEdwTlp2M3BHbWFwR3FkTHdKcjVmbXhMeHFiTFZy?=
 =?utf-8?B?NUlMeW90NUhEalM4YkJZNCt6bmxma2RJK25KejFuVVg4eUlKaTIvdzMzTEhy?=
 =?utf-8?B?WFVUaHVnWjVuYUxwSGJuOUtQVG9UQTRQcG5teUNxOExROWlhWFMyM0tsTTNs?=
 =?utf-8?B?eDhKUEptOVJIZWtwdXFYUWZPd1FhZFp2S0lYbmdPcmRXQmhZeFYzeVJRSHRP?=
 =?utf-8?B?Tmc2dytweFZkUnFKSldjNnFtWm5wL3N5T09WcGVIMmNpQVBqbVVhcUpTMHJS?=
 =?utf-8?B?SUtwMlJZeVdrdk4vRHRFQWViaHBDeUs5UWRWV0ltaVNBbmZNMXdiWjBMU0RJ?=
 =?utf-8?B?RUw5RnVsdkJkY3hZcktiS2hhNXNXWThDRDhsdDNSanErQTRzQmdoajR1eDFN?=
 =?utf-8?B?NW40SkM4WWZYcEZ6am5VU21oTFY0WlJZN25zNVVnUEkzNGdWVVNvQ29hSlZO?=
 =?utf-8?B?emd4T1pyVHg2NGlKMXhnR2I0SC9IUmQ0MDg0MmNvMk1WMUZrbU9BREZINGJG?=
 =?utf-8?B?L05iUDEwT3ErbTcrNHJ1ZFpoS0h5bWxTeDJ3YzM0d1RtSUhGZ2tBUlJ5UmJU?=
 =?utf-8?B?ZGNXTHVVOWNESEJZV1NKVUdXUFk1RnBiNXRaQkkwbVpwOEovRUp6eHJYUlNX?=
 =?utf-8?B?SG10M0IzMXBiUzdyS3hZYmF4NGdGb1FVM3o2MEtGN1FQTmZVUW9vcEl4cUlj?=
 =?utf-8?B?UjVjeTU0c2lsUXJuNGcxTlBuVjdiczZPeEUyWi9IVWp2YnZaNy9WdUhKcSs3?=
 =?utf-8?B?ejUxeHdWT1BQVzJNcnRiRE50SXZrYm9ocyttY0pJRVg5WjVpdS9WSDFKV3ZG?=
 =?utf-8?B?U0dpWVAvYVU2TnBlTGVZM1ZDMTdqb0ZTdnZ5ZC9aSHN6WFgvR2hLSitUN1F5?=
 =?utf-8?B?OXN1YnpTRkdOU01oMlZSZCtqNVZka1g1cDg4R21EU1pDUGdQZUU3OWRhRGRG?=
 =?utf-8?B?SlhaSGY0dmQvY2NacjVlQU5Hdkh1TUo1U0Q0UFhJdUljOHBWMkNWSDl0TVll?=
 =?utf-8?B?NjZkNjJWa3JiNUptek12RTIrZVl4azZXbEVZeVBGcitqWWt2RjdFbDE5WU9Q?=
 =?utf-8?B?Z3Y3RlFmTzNZeEV2dXdKb0hha2dXL0xrTWRHTDdycVNNSWpJeGVKNk81Mkt1?=
 =?utf-8?B?bWkzL2ZLSVNsa3k1L0M5cTZ3RWJhVWR3VVFWU3BQWGJCTmNlUWl3MTZmbkxB?=
 =?utf-8?B?YmF6dUZoTVlUWGVvckJCUlM0aUtrR2RrOHE2d3gvL0x2cTBOSURBWWhOaW81?=
 =?utf-8?B?ZkVRQWlFMnc3VCs0UHBjdVhvaXZMUkUyRTFCSzc1S0cwdUdQRTNLYVBFK04r?=
 =?utf-8?B?VGtZR3ZCNjRKZGtLWEp3OUR5Q2VJZkxpb3hzdEpmUHNscEsya2hsTnBKaWE5?=
 =?utf-8?B?OWNEUjZFanN1VG9naW5OTzRiUUVnSWx3blFZbUYwMFFSSXBYcHNXc0d5MmF4?=
 =?utf-8?B?RkZRYnpxY25OQk1yUytvd3N5UmswbENodUxuVGNkSXQxc0FHK0hyQlB3d2JW?=
 =?utf-8?B?R2JzWGY2dm9uNUlhOHJwd0I0QTErYnRnT1ZDaGRLSVg3MHltS3BzOGVIMDhM?=
 =?utf-8?Q?oRk8ak6b0oIKHM0w=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a379d6b-d542-44da-5e8a-08da2866476b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 15:54:57.8215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s+MdR2PK1Nci78PfYM6OIHOiRb9zCsb3R+GTmUlEx3mMZHRl5oG9MVarIHIKR/VY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1851
X-Proofpoint-GUID: GV9-L0tchi0YLPySx0A7_35j8Ye5OtNq
X-Proofpoint-ORIG-GUID: GV9-L0tchi0YLPySx0A7_35j8Ye5OtNq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-27_04,2022-04-27_01,2022-02-23_01
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/20/22 10:18 AM, Andrii Nakryiko wrote:
> On Thu, Apr 14, 2022 at 3:46 PM Alexander Lobakin <alobakin@pm.me> wrote:
>>
>> On 32 bit systems, shifting an unsigned long by 32 positions
>> yields the following warning:
>>
>> samples/bpf/tracex2_kern.c:60:23: warning: shift count >= width of type [-Wshift-count-overflow]
>>          unsigned int hi = v >> 32;
>>                              ^  ~~
>>
> 
> long is always 64-bit in BPF, but I suspect this is due to
> samples/bpf/Makefile still using this clang + llc combo, where clang
> is called with native target and llc for -target bpf. Not sure if we
> are ready to ditch that complicated combination. Yonghong, do we still
> need that or can we just use -target bpf in samples/bpf?

Current most bpf programs in samples/bpf do not use vmlinux.h and CO-RE.
They direct use kernel header files. That is why clang C -> IR 
compilation still needs to be native.

We could just use -target bpf for the whole compilation but that needs 
to change the code to use vmlinux.h and CO-RE. There are already a 
couple of sample bpf programs did this.

> 
> 
>> The usual way to avoid this is to shift by 16 two times (see
>> upper_32_bits() macro in the kernel). Use it across the BPF sample
>> code as well.
>>
>> Fixes: d822a1926849 ("samples/bpf: Add counting example for kfree_skb() function calls and the write() syscall")
>> Fixes: 0fb1170ee68a ("bpf: BPF based latency tracing")
>> Fixes: f74599f7c530 ("bpf: Add tests and samples for LWT-BPF")
>> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
>> ---
>>   samples/bpf/lathist_kern.c      | 2 +-
>>   samples/bpf/lwt_len_hist_kern.c | 2 +-
>>   samples/bpf/tracex2_kern.c      | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
> 
> [...]