Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4717943ioa; Wed, 27 Apr 2022 09:34:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxMC44F3SrL3a5sV2EYP+H3C56S6g6nFTAaIR7aTMx2GqRE9NZ9radfLtBKx66tzmwt8s0 X-Received: by 2002:a63:5020:0:b0:39e:5d26:4316 with SMTP id e32-20020a635020000000b0039e5d264316mr24728207pgb.294.1651077254848; Wed, 27 Apr 2022 09:34:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651077254; cv=none; d=google.com; s=arc-20160816; b=ki2W3DcHT9DDEVudzwCAV3DxryA44Wj18GxbvP2fceT4XydYD3xPtIG2qUu6M2FjP1 KjmuXCHZM4XO94ZvK4Qn769HXLmIQJUG9JCtpnHCrJKIJDAyPhwecnyk3mh5JtU83VTv EcYayicG8skCiIbT0zzTZbL4BQuMUXG+IisNI39qCGwli8tE9uxhnwHJ5PS+XS0oseIe ErxFRgyghuolkg0iC7XxaI49EOp2XhwfOt6QKWbS29+KpxSNGxpHr7hMTcibC1kMEWWe Z8dQZ5xJwwVPkwsKivLMUPRn1VRouMXCB5rOZ9KGLL3MYzuvdN8t5qfZjE8Dnyglb1T2 sSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B7bCPSAqni/eXnk1LqJkGqy1IOK7BdN/WKgexnP+sSs=; b=kfNL9F0iP4M5KoIrtKyud+ewLlzE/VxJ1r5t6/wTBmgR2BmJ7W8AAfzt/Su8I1bHnV v3OTkKwbU0BG6tV8gAA3aCSpjNwO9HtnVCjl+8sJ4tX0zqF+dJJkOhmtIeusPR2Gl1+h pBAymNoGKgXxAba7IMl0W2FSfJjRZpWDYMp5jVwhjR/3bIkW0nngooDM9QW2Ktj/ckmh l1MZrxCk+IOjupkr2n5+5Lhi6PHyH756zarmoUOKk6SUZxuwalgF+ZqL3a017ra0m6wz Mf75SFg4REwZ+m9oUxJohTqrLPNI+VmFMSOwHKh5b3R7ddcliVb2/uBcoFetr1il8IOu mtbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wm5xTSYC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id mu17-20020a17090b389100b001d94259f3dfsi6287746pjb.95.2022.04.27.09.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 09:34:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wm5xTSYC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4824B3ECE91; Wed, 27 Apr 2022 09:04:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241477AbiD0QDt (ORCPT + 99 others); Wed, 27 Apr 2022 12:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241160AbiD0QDg (ORCPT ); Wed, 27 Apr 2022 12:03:36 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA560288EE4 for ; Wed, 27 Apr 2022 08:59:49 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id z16so1955173pfh.3 for ; Wed, 27 Apr 2022 08:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=B7bCPSAqni/eXnk1LqJkGqy1IOK7BdN/WKgexnP+sSs=; b=wm5xTSYCz9ImGQOBbgtUP1ff6okO5z5MEKS4Ra9Q+9ZGRX4Sh2LozU7GiIrBErvXAR 3+Sv9iMqS+IT+wyhnbLG1cg59xi8BU96rjrfGqmrslU5A1fQ8/9xQpyxAsqScgLnvusw haUA8dCRMZgbI5h2voBta7cefY4wYB+UQRRLm9fESog4XJpY0cjCQHVsNN+H7teOrdSU SSajLEtZzEFwrOHv6JT22Qdii4pXDEzZwU5bxCebqkwdMdpJegLzdSOd3+GQUfjhqiSu iGt31/fPbboUzAhv9SpTWYKuJ9HhuIu1o6fNCofEufP/1VaBAOrVOauzGH3I7cq+f0uv EXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=B7bCPSAqni/eXnk1LqJkGqy1IOK7BdN/WKgexnP+sSs=; b=1Ee8SXUCSOJFSGc4kT7FO+C7BBwFcMi8lFPtq9DUoyXpMbMmK69EDWMdnT3o3a4zqO YANQ3wBXZtEwbjsxjtvRKcrR2iaD2Iyr/80Q3k1kbkrlfU1VfTWfQbpfy/ul3/yGbDeP TvsJryZ2FyDEA8NHzHsgapr9bR7Ozw0ccdSMbIgjLB/1qrkkpkbNxcbMJkwjM3s6Hssp GIJSnwz402ofO8EFVsFevmm6L9MG3lOdLaBe9VGFtBS2OKBSkhhtGXQd7jizht1E5giJ Yz6SrMf4eqDd3eeXzBfHmI62jRfqf43UHbXdBPTum6Sesikq8o0eeIiL3z2ErsOxJcGD Q//g== X-Gm-Message-State: AOAM530XB8NtJNdOXR9PS3gOp0oJtkYLxerF0eahSKvDwqJDj7eEPkoQ qrX9hPmCEwrlsenaO6BksziivA== X-Received: by 2002:a62:2742:0:b0:505:89a5:2023 with SMTP id n63-20020a622742000000b0050589a52023mr30923743pfn.18.1651075183688; Wed, 27 Apr 2022 08:59:43 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([134.195.101.46]) by smtp.gmail.com with ESMTPSA id k198-20020a633dcf000000b003aa9116ba17sm16707374pga.35.2022.04.27.08.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 08:59:43 -0700 (PDT) Date: Wed, 27 Apr 2022 23:59:34 +0800 From: Leo Yan To: Ali Saidi Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, acme@kernel.org, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v7 5/5] perf arm-spe: Use SPE data source for neoverse cores Message-ID: <20220427155934.GC562576@leoy-ThinkPad-X240s> References: <20220426135937.18497-1-alisaidi@amazon.com> <20220426135937.18497-6-alisaidi@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220426135937.18497-6-alisaidi@amazon.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2022 at 01:59:37PM +0000, Ali Saidi wrote: > When synthesizing data from SPE, augment the type with source information > for Arm Neoverse cores. The field is IMPLDEF but the Neoverse cores all use > the same encoding. I can't find encoding information for any other SPE > implementations to unify their choices with Arm's thus that is left for > future work. > > This change populates the mem_lvl_num for Neoverse cores as well as the > deprecated mem_lvl namespace. > > Signed-off-by: Ali Saidi I tested this patch and also did the integration testing with perf ć2c tool, this patch looks good to me: Reviewed-by: Leo Yan Tested-by: Leo Yan James, German, it's better if this patch set can get the green light from you. So please take a look, thanks! Leo