Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     syzbot <syzbot+7728e4ab5371cebc9c00@syzkaller.appspotmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>,
        Peter Xu <peterx@redhat.com>,
        Qian Cai <quic_qiancai@quicinc.com>
Subject: Re: [syzbot] WARNING in vma_merge
Thread-Topic: [syzbot] WARNING in vma_merge
Thread-Index: AQHYWjRmy9YwbzHJ/0e8lY/ldotJ+K0DvUcAgABEggCAAAjgAA==
Date:   Wed, 27 Apr 2022 17:52:24 +0000
Message-ID: <20220427175218.cazytgdlpc6lpn45@revolver>
References: <000000000000a23c8505dda227eb@google.com>
 <000000000000f28f0005dda29992@google.com>
 <20220427102032.5a87283eb64d06c1a6d682fd@linux-foundation.org>
In-Reply-To: <20220427102032.5a87283eb64d06c1a6d682fd@linux-foundation.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ishVF/IjrwXHYsC4vDOgegejM9yAToepgVGLJnuwPUm0ai8Y5L7Vf9fjrfSN?=
 =?us-ascii?Q?QBy/bkHLzP0le5hz/zIHgRNivAYWy1Ft21Dw/6hDvTlaAA8OwLXVcWqEcFsF?=
 =?us-ascii?Q?mpEpb0jI3qLkn1nyyk00xaRe2ykKGHszwo0go8nkqN2/JQm9vEfr3E4bdp7p?=
 =?us-ascii?Q?mPXYJ2ho6t2qoagnswkEFKlsD6bkiZCIfzlsCWzU9hdb+dJFTliii143CXs4?=
 =?us-ascii?Q?R5ix3RQqW2KXZOmMc44RDhuqpR/l6a339Nk5/izZ3LNcxCO/bJNpPvb8kZoR?=
 =?us-ascii?Q?8SAreAybrlL2rh4uNn9BPKkgKfK13h5nTTQAJZdws5m+jQhWnbMVs8gh3T1N?=
 =?us-ascii?Q?Nm/VB6M3DH6U8ZUnJ3dZuHVgU4pIpoL+wHord2Hb9XR4Eo1HSXia+f2e07l9?=
 =?us-ascii?Q?Syi9XPxhWsuOk3pU8GUluoOHFSdZH/0kky3a0Y826JdNS6Jkb9f2oG1yOJKE?=
 =?us-ascii?Q?eWJrd0N7SdKFRBvp80UG96qcWedSRhLDkss+5gltiHNVo3m/QynlEd0c+MdK?=
 =?us-ascii?Q?vEBjrsUtl8hyplH3dakObwvDZV4GHyBEfK8OSGjO2Ya30vGuq7ivJ9t9PryP?=
 =?us-ascii?Q?jURF0Yd6bYhhPYbQAJjDsrOWCwI+njNRw24JI54YL3XuwajzVW4xz3W7/Ks0?=
 =?us-ascii?Q?iezVbgMg6VaOV1j6aEqLJIClNSbSy3fV4BVkwh1XuAFYipKM2jY2de1+rrpw?=
 =?us-ascii?Q?CS6At6AWIaKqnKNfM/HRPltwaQVjW9uQPbcjOqgVFOqY8+e7vqUGpgyYl1/S?=
 =?us-ascii?Q?AmUaKr56AsOcIR0eSPyIC3o8mhi6WGNXaUSSkH4j/uxFT63UxylHeIONLVVC?=
 =?us-ascii?Q?ryLPY4M7RWEssjjJjJ4ujRdYWeF/iD9tn6YLQ85QZam8AZmmWTmBXqbSzn7A?=
 =?us-ascii?Q?yK49V1gutkNrUqr/op5sxMOZANtNgb4dsOWFLFWpqhkpARxtnP2J2n1qxPIL?=
 =?us-ascii?Q?yix15KYWcI3nzqMkXX1Qx/pMwOJCcEgs3utAtNNf5xT3+J+tQy+5p8guT/a7?=
 =?us-ascii?Q?oLSWbzWwl3lcNIIGip94i913K52ZCItbotn8UIErD5IO65Ce1NdkWU7tikIv?=
 =?us-ascii?Q?tTmNGQJCFyg2NJeP4Aex/7tY0HXan7/AAgiSUHDaricQkcQHBLj/4Mepq+5v?=
 =?us-ascii?Q?hcBy0JpsWFnLteupuHdabrLhXIVYdpAhlHnVQK08rioN2t9SzDAgIR6JBlun?=
 =?us-ascii?Q?QSBq6D8EPewjz2YHQwEnZc3k11FCglaBS3/MvtMVS9ae9vAigmYVFx87Xlos?=
 =?us-ascii?Q?gr0IuXCbWslmFeVu8RecYkpQ/HLIRpWGnG0QaHK1/DyHEKxIsbem0OJTyMlE?=
 =?us-ascii?Q?3Sxm/LHISl95ZwNAMMRNzLl56mHKDL2WjH/drvNyNqlZVnbMuQWEqBmCi4og?=
 =?us-ascii?Q?N9kF4coIeHClGJ0ZpFPOnyvKODCwhyndOIW4iGRhYW2eqAERbamRkP7MWSFc?=
 =?us-ascii?Q?twU+F+/xysAUbvOsGSUVCJPR1cZzMEWuFxz+HPDsZcXij3xZpnQD5N2DKWru?=
 =?us-ascii?Q?a5TUalzKAhxcXRTpbJfAulRDckbiD9UqoHv4Zx6es1yg4Sy4JijiIrmRJF5W?=
 =?us-ascii?Q?bHMmWJhaUfczTMGtCr/SL4a9PaWxTqAYOXt8dQzmepzKfW2cUUla6zRNSNnf?=
 =?us-ascii?Q?bS5euMrQL4MnyV12djL0leJ9TY1LlTLiZC9I1kmES4v+h2G0swdEL6rQ0alb?=
 =?us-ascii?Q?nEWteoXUBvczk3hrqeuhr6nhHywmvYuwZsfW1b9tMgYfSlhwdamdtKvyxLlM?=
 =?us-ascii?Q?6ED5UL2KObPauqZjx1ioZc7AfgUdlCY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D7E0166E401D6C43831B249BFBEB56DC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8b5e9c-656e-4947-a3a3-08da2876af90
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2022 17:52:24.2621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tkkmXmmqmzv48aQEGnGvUH0fyWzBn6ew6YYUD5LsKN1+ZArWLCABTrHKyDJeO78GC5GxuQnj4Yiws84x8haJKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2965
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-27_04:2022-04-27,2022-04-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=991
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204270111
X-Proofpoint-GUID: 74Fg3yWUxHeHoznMAquRratOfZiX1YqN
X-Proofpoint-ORIG-GUID: 74Fg3yWUxHeHoznMAquRratOfZiX1YqN
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Andrew Morton <akpm@linux-foundation.org> [220427 13:20]:
> On Wed, 27 Apr 2022 06:15:20 -0700 syzbot <syzbot+7728e4ab5371cebc9c00@sy=
zkaller.appspotmail.com> wrote:
>=20
> > syzbot has found a reproducer for the following issue on:
>=20
> Thanks.
>=20
> userfaultfd_release() appears to have offended vma_merge().

Potentially apply_mlockall_flags() and not userfaultfd_release(). There
is a potential that the vma iterator is stale if a split/merge succeeds,
although KASAN should pick this up and KASAN is active according to the
config below. I've sent a patch for the mlockall issue after Qian Cai's
reported it to linux-mm.

>=20
> I'm not seeing any changes in that area from Peter, but Liam's
> mapletree work changed things around a bit.  Gents, could you please
> take a look?
>=20
>=20
> > HEAD commit:    f02ac5c95dfd Add linux-next specific files for 20220427
> > git tree:       linux-next
> > console output: https://syzkaller.appspot.com/x/log.txt?x=3D105a33a2f00=
000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=3De9256c70f58=
6da8a
> > dashboard link: https://syzkaller.appspot.com/bug?extid=3D7728e4ab5371c=
ebc9c00
> > compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binu=
tils for Debian) 2.35.2
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D15f76f82f=
00000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D12b42c3cf00=
000
> >=20
> > IMPORTANT: if you fix the issue, please add the following tag to the co=
mmit:
> > Reported-by: syzbot+7728e4ab5371cebc9c00@syzkaller.appspotmail.com
> >=20
> > ------------[ cut here ]------------
> > WARNING: CPU: 0 PID: 3593 at mm/mmap.c:1072 vma_merge+0x428/0x950 mm/mm=
ap.c:1072
>=20
> I assume this is
>=20
> 		VM_WARN_ON(area && end > area->vm_end);
>=20
> But lines change around a lot.  It would be great if the script which
> generates these reports could quote the code around the indicated file
> and line.  Like:
>=20
> 	next =3D find_vma(mm, prev ? prev->vm_end : 0);
> 	area =3D next;
> 	if (area && area->vm_end =3D=3D end)		/* cases 6, 7, 8 */
> 		next =3D find_vma(mm, next->vm_end);
>=20
> 	/* verify some invariant that must be enforced by the caller */
> 	VM_WARN_ON(prev && addr <=3D prev->vm_start);
> -->	VM_WARN_ON(area && end > area->vm_end);
> 	VM_WARN_ON(addr >=3D end);
>=20
> 	/*
> 	 * Can it merge with the predecessor?
> 	 */
> 	if (prev && prev->vm_end =3D=3D addr &&


That is the correct line according to the git tree and HEAD commit
listed above.

I cannot get this issue to trigger with the given tree and git repo with
my config.  I will try again with the kernel config above.

Thanks,
Liam